refactor: refine a test

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

diff --git a/ReforceXY/user_data/freqaimodels/ReforceXY.py b/ReforceXY/user_data/freqaimodels/ReforceXY.py
index c500b060d4da9d0babba5f5938ed5ae6b757bc32..7e21c9df385397a242f400c5e68cfc9435d0ef7e 100644 (file)
--- a/ReforceXY/user_data/freqaimodels/ReforceXY.py
+++ b/ReforceXY/user_data/freqaimodels/ReforceXY.py
@@ -502,7 +502,7 @@ class ReforceXY(BaseReinforcementLearningModel):
         return storage
 
     def study_has_best_trial_params(self, study: Study | None) -> bool:
-        if not study:
+        if study is None:
             return False
         try:
             _ = study.best_trial.params

diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
index bea7910cce5bc7fdd75c209618ff69c303839c44..98c7e33d7facc3ae218a25b6dc434d46bef06075 100644 (file)
--- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
@@ -484,7 +484,7 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
         return study
 
     def optuna_study_has_best_params(self, study: optuna.study.Study | None) -> bool:
-        if not study:
+        if study is None:
             return False
         try:
             _ = study.best_params

diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
index e2cabdd47262033f05c757acd3ec3bc123372b8d..b2a40aedf19160864fd7ff67e2c67ad09c044d80 100644 (file)
--- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
@@ -487,7 +487,7 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
         return study
 
     def optuna_study_has_best_params(self, study: optuna.study.Study | None) -> bool:
-        if not study:
+        if study is None:
             return False
         try:
             _ = study.best_params