]> Piment Noir Git Repositories - e-mobility-charging-stations-simulator.git/commitdiff
refactor(ocpp2): use enum values instead of string literals in variable registry
authorJérôme Benoit <jerome.benoit@sap.com>
Sat, 21 Mar 2026 20:29:59 +0000 (21:29 +0100)
committerJérôme Benoit <jerome.benoit@sap.com>
Sat, 21 Mar 2026 20:29:59 +0000 (21:29 +0100)
Replace all string literals that have corresponding TypeScript enums:
- OCPP20OperationalStatusEnumType for AvailabilityState defaultValue/enumeration
- OCPP20ChargingRateUnitEnumType for ChargingScheduleAllowedChargingRateUnit
  defaultValue, enumeration, and description

src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts

index dfabb2cc9525bb013063bef3ede97812d785e96b..c37be16aa85e460324fbced7974f1f3e16ed1c94 100644 (file)
@@ -6,6 +6,7 @@ import {
   AttributeEnumType,
   DataEnumType,
   MutabilityEnumType,
+  OCPP20ChargingRateUnitEnumType,
   OCPP20ComponentName,
   OCPP20DeviceInfoVariableName,
   OCPP20MeasurandEnumType,
@@ -2152,10 +2153,9 @@ export const VARIABLE_REGISTRY: Record<string, VariableMetadata> = {
   [buildRegistryKey(OCPP20ComponentName.SmartChargingCtrlr as string, 'RateUnit')]: {
     component: OCPP20ComponentName.SmartChargingCtrlr as string,
     dataType: DataEnumType.MemberList,
-    defaultValue: 'A,W',
-    description:
-      "A list of supported quantities for use in a ChargingSchedule. Allowed values: 'A' and 'W'",
-    enumeration: ['A', 'W'],
+    defaultValue: `${OCPP20ChargingRateUnitEnumType.A},${OCPP20ChargingRateUnitEnumType.W}`,
+    description: `A list of supported quantities for use in a ChargingSchedule. Allowed values: '${OCPP20ChargingRateUnitEnumType.A}' and '${OCPP20ChargingRateUnitEnumType.W}'`,
+    enumeration: [OCPP20ChargingRateUnitEnumType.A, OCPP20ChargingRateUnitEnumType.W],
     mutability: MutabilityEnumType.ReadOnly,
     persistence: PersistenceEnumType.Persistent,
     required: true,