fixed empty list response to LIST_CHARGING_STATIONS

diff --git a/src/charging-station/Bootstrap.ts b/src/charging-station/Bootstrap.ts
index 725105cef9cfcfeb9ef11b1c8cc21ab4a91d13e7..18e934db0351ace719cf67f4ca44dd606f0a09e5 100644 (file)
--- a/src/charging-station/Bootstrap.ts
+++ b/src/charging-station/Bootstrap.ts
@@ -34,18 +34,17 @@ export default class Bootstrap {
   private constructor() {
     this.started = false;
     this.workerScript = path.join(
-      // wouldn't path.resolve(./ChargingStationWorker.js) faster & simpler ?
-      path.resolve(__dirname, '../'),
+      path.resolve(__dirname, '../'), // wouldn't path.resolve(./ChargingStationWorker.js) achieve the same result ?
       'charging-station',
       'ChargingStationWorker.js'
     );
-    this.initWorkerImplementation(); // init thread
-    Configuration.getUIWebSocketServer().enabled && // create webSocket
+    this.initWorkerImplementation();
+    Configuration.getUIWebSocketServer().enabled &&
       (this.uiWebSocketServer = new UIWebSocketServer({
         ...Configuration.getUIWebSocketServer().options,
         handleProtocols: UIServiceUtils.handleProtocols,
       }));
-    Configuration.getPerformanceStorage().enabled && // create storage ??? but for what
+    Configuration.getPerformanceStorage().enabled &&
       (this.storage = StorageFactory.getStorage(
         Configuration.getPerformanceStorage().type,
         Configuration.getPerformanceStorage().uri,
@@ -152,10 +151,8 @@ export default class Bootstrap {
           workerChoiceStrategy: Configuration.getWorkerPoolStrategy(),
         },
         messageHandler: async (msg: ChargingStationWorkerMessage) => {
-          console.log('initWorkerImplementation: messageHandler: ', msg);
           if (msg.id === ChargingStationWorkerMessageEvents.STARTED) {
             this.uiWebSocketServer.chargingStations.add(msg.data.id as string);
-            console.log(this.uiWebSocketServer.chargingStations);
           } else if (msg.id === ChargingStationWorkerMessageEvents.STOPPED) {
             this.uiWebSocketServer.chargingStations.delete(msg.data.id as string);
           } else if (msg.id === ChargingStationWorkerMessageEvents.PERFORMANCE_STATISTICS) {

diff --git a/src/charging-station/ui-websocket-services/AbstractUIService.ts b/src/charging-station/ui-websocket-services/AbstractUIService.ts
index 6755cd6e0fd3e1f8b2571cf43b7aad8f285304f7..42cfa428f1373cc36e1b67bca96661d1eebf6b19 100644 (file)
--- a/src/charging-station/ui-websocket-services/AbstractUIService.ts
+++ b/src/charging-station/ui-websocket-services/AbstractUIService.ts
@@ -42,12 +42,10 @@ export default abstract class AbstractUIService {
   }
 
   protected buildProtocolMessage(command: ProtocolCommand, payload: JsonType): string {
-    console.log(JSON.stringify([command, payload])); // DEBUG
     return JSON.stringify([command, payload]);
   }
 
   private handleListChargingStations(): string[] {
-    // FIXED
     return Array.from(this.uiWebSocketServer.chargingStations);
   }
 }

diff --git a/src/worker/WorkerFactory.ts b/src/worker/WorkerFactory.ts
index 7e69fc56d974469ecfb6574f1a2c4246cad2cddc..70bcc3862c4fca8c42a66d7e0f52e7568bfbef80 100644 (file)
--- a/src/worker/WorkerFactory.ts
+++ b/src/worker/WorkerFactory.ts
@@ -21,9 +21,9 @@ export default class WorkerFactory {
     if (!isMainThread) {
       throw new Error('Trying to get a worker implementation outside the main thread');
     }
-    workerOptions = workerOptions ?? ({} as WorkerOptions); // why not default parameter ?
+    workerOptions = workerOptions ?? ({} as WorkerOptions);
     workerOptions.workerStartDelay =
-      workerOptions?.workerStartDelay ?? WorkerConstants.DEFAULT_WORKER_START_DELAY; // why null safety  ?
+      workerOptions?.workerStartDelay ?? WorkerConstants.DEFAULT_WORKER_START_DELAY;
     workerOptions.elementStartDelay =
       workerOptions?.elementStartDelay ?? WorkerConstants.DEFAULT_ELEMENT_START_DELAY;
     workerOptions.poolOptions = workerOptions?.poolOptions ?? ({} as PoolOptions<Worker>);
@@ -31,7 +31,7 @@ export default class WorkerFactory {
       // eslint-disable-next-line @typescript-eslint/no-misused-promises
       (workerOptions.poolOptions.messageHandler = workerOptions.messageHandler);
     console.log('before');
-    let workerImplementation: WorkerAbstract<T> = null; // enabling strictNullChecks would be safer ?
+    let workerImplementation: WorkerAbstract<T> = null;
     console.log(workerImplementation);
     switch (workerProcessType) {
       case WorkerProcessType.WORKER_SET:

diff --git a/src/worker/WorkerSet.ts b/src/worker/WorkerSet.ts
index 782284f3d00447286ad13ca62fb00093be9df243..6e890902d8f8c769e726a262e5c013c39334b604 100644 (file)
--- a/src/worker/WorkerSet.ts
+++ b/src/worker/WorkerSet.ts
@@ -54,7 +54,7 @@ export default class WorkerSet extends WorkerAbstract<WorkerData> {
       id: WorkerMessageEvents.START_WORKER_ELEMENT,
       data: elementData,
     });
-    this.getLastWorkerSetElement().numberOfWorkerElements++; // should there not be a hanshake to be safer ?
+    this.getLastWorkerSetElement().numberOfWorkerElements++;
     // Start element sequentially to optimize memory at startup
     if (this.workerOptions.elementStartDelay > 0) {
       await Utils.sleep(this.workerOptions.elementStartDelay);