fix: fix events listener cleanup

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c7a27c609541350fca4acea30fec2b78653f8b6d..24762e5f0033f807de9901e216ed73216dd4bd18 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Remove all pool events listener at pool destroying.
+- Remove all worker node events listener at worker node destroying.
+
 ## [3.0.8] - 2023-11-25
 
 ### Fixed

diff --git a/src/pools/abstract-pool.ts b/src/pools/abstract-pool.ts
index eb92eb548903a719169f15e658ccbfe86cefe4be..53b7b430efcc626c317e2186e7dbd4b409944dd6 100644 (file)
--- a/src/pools/abstract-pool.ts
+++ b/src/pools/abstract-pool.ts
@@ -989,6 +989,7 @@ export abstract class AbstractPool<
     )
     this.emitter?.emit(PoolEvents.destroy, this.info)
     this.emitter?.emitDestroy()
+    this.emitter?.removeAllListeners()
     this.readyEventEmitted = false
     this.destroying = false
     this.started = false

diff --git a/src/pools/cluster/fixed.ts b/src/pools/cluster/fixed.ts
index 5f067bd7fb4a716f20297f2c907c7632a9607a1b..b74f034bc199d9d4e89f77f0856b00855cf1685a 100644 (file)
--- a/src/pools/cluster/fixed.ts
+++ b/src/pools/cluster/fixed.ts
@@ -75,6 +75,7 @@ export class FixedClusterPool<
       worker.kill()
     })
     await this.sendKillMessageToWorker(workerNodeKey)
+    workerNode.removeAllListeners()
     worker.disconnect()
     await waitWorkerExit
   }

diff --git a/src/pools/thread/fixed.ts b/src/pools/thread/fixed.ts
index ddda04b113ec9028b0cd24c8f53001d12714a901..73740baa92110e213b427fe0ca1f8aeafebe307c 100644 (file)
--- a/src/pools/thread/fixed.ts
+++ b/src/pools/thread/fixed.ts
@@ -70,6 +70,7 @@ export class FixedThreadPool<
     })
     await this.sendKillMessageToWorker(workerNodeKey)
     workerNode.closeChannel()
+    workerNode.removeAllListeners()
     await worker.terminate()
     await waitWorkerExit
   }