]> Piment Noir Git Repositories - freqai-strategies.git/commitdiff
refactor(ci): consolidate strategy QA jobs
authorJérôme Benoit <jerome.benoit@piment-noir.org>
Wed, 23 Sep 2026 22:10:57 +0000 (00:10 +0200)
committerJérôme Benoit <jerome.benoit@piment-noir.org>
Wed, 23 Sep 2026 22:10:57 +0000 (00:10 +0200)
.github/workflows/quality.yml
README.md

index 81f5fe1b1ebc96f45130b812441df90e2213eaa6..1f6fdefd8e79eea2cce46e04b36a8c8548551af2 100644 (file)
@@ -31,8 +31,8 @@ jobs:
       - name: Check repository formatting
         run: uvx ruff@latest format --check .
 
-  type-check:
-    name: BasedPyright (${{ matrix.name }})
+  strategy-qa:
+    name: QA (${{ matrix.name }})
     runs-on: ubuntu-latest
     timeout-minutes: 30
     strategy:
@@ -63,39 +63,23 @@ jobs:
             "${{ matrix.image }}" \
             /workspace/scripts/check_basedpyright.py \
             --project "${{ matrix.project }}"
-      - name: QuickAdapter runtime regressions
-        if: matrix.project == 'quickadapter'
+      - name: Run runtime regressions
         run: |
           docker run --rm \
             --mount "type=bind,src=${GITHUB_WORKSPACE},dst=/workspace,readonly" \
             --workdir /workspace \
-            --env PYTHONPATH=/workspace/quickadapter/user_data/strategies \
+            --env PYTHONPATH=/workspace/${{ matrix.context }}/user_data/strategies \
             --entrypoint python \
             "${{ matrix.image }}" \
-            -m unittest discover -s quickadapter/tests -v
+            -m unittest discover -s "${{ matrix.context }}/tests" -v
 
-  reforcexy-tests:
-    name: ReforceXY tests
+  reward-space-analysis:
+    name: Reward space analysis
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    env:
-      REFORCEXY_QA_IMAGE: freqai-strategies-reforcexy-qa:ci
     steps:
       - name: Check out repository
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
-      - name: Build QA image
-        run: >-
-          docker build --pull --target qa
-          --tag "${REFORCEXY_QA_IMAGE}"
-          ReforceXY
-      - name: Run runtime regressions
-        run: |
-          docker run --rm \
-            --mount "type=bind,src=${GITHUB_WORKSPACE},dst=/workspace,readonly" \
-            --workdir /workspace \
-            --entrypoint python \
-            "${REFORCEXY_QA_IMAGE}" \
-            -m unittest discover -s ReforceXY/tests -v
       - name: Set up uv
         uses: astral-sh/setup-uv@c18668ad3cf93ea998bef934396af7bb5c839dc7 # v10.2.0
         with:
index 96b324c9ec58bcca8b35a4ff3031ef1489696745..1daffd1d203364da074f995aeca11868945c935e 100644 (file)
--- a/README.md
+++ b/README.md
@@ -481,6 +481,9 @@ PYTHONPATH=/workspace/quickadapter/user_data/strategies \
   python -m unittest discover -s quickadapter/tests -v
 ```
 
+CI runs type checks and runtime regressions in one QA matrix entry per strategy.
+The reward-space analysis suite runs separately with `uv`, without a Freqtrade image.
+
 ### Quality checks
 
 Run repository quality checks from the repository root: