fix(qav3): return only optimized params at HPO

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
index 1ca845323a65449a8344ede02c604b2a648f66d3..45c169e4f66e909ae6a5a609daf7a211303acc70 100644 (file)
--- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
@@ -309,9 +309,9 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
             logger.error(f"Optuna hp hyperopt failed: {e}", exc_info=True)
             return None
 
-        params = {"rmse": study.best_value, **study.best_params}
+        params = study.best_params
         # log params
-        for key, value in params.items():
+        for key, value in {"rmse": study.best_value, **params}.items():
             logger.info(f"Optuna hp hyperopt | {key:>20s} : {value}")
         return params
 

diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
index 27e4e4848f3a826da6c5fd99c20fa8bd1c0c3f8d..189f0b8ec38b373a63d0ef9976912f6c0267b8ce 100644 (file)
--- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
@@ -310,9 +310,9 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
             logger.error(f"Optuna hp hyperopt failed: {e}", exc_info=True)
             return None
 
-        params = {"rmse": study.best_value, **study.best_params}
+        params = study.best_params
         # log params
-        for key, value in params.items():
+        for key, value in {"rmse": study.best_value, **params}.items():
             logger.info(f"Optuna hp hyperopt | {key:>20s} : {value}")
         return params