refactor: cleanup RFID authorization code

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

diff --git a/src/charging-station/ocpp/OCPPServiceUtils.ts b/src/charging-station/ocpp/OCPPServiceUtils.ts
index b74740875b2753642eb673ae3dcd9a8cb5a3c89a..f5bbe1602290dbba4699600570c46a76a10c44f4 100644 (file)
--- a/src/charging-station/ocpp/OCPPServiceUtils.ts
+++ b/src/charging-station/ocpp/OCPPServiceUtils.ts
@@ -232,7 +232,6 @@ export class OCPPServiceUtils {
         `${chargingStation.logPrefix()} The charging station expects to authorize RFID tags but nor local authorization nor remote authorization are enabled. Misbehavior may occur`,
       );
     }
-    let authorized = false;
     if (
       chargingStation.getLocalAuthListEnabled() === true &&
       OCPPServiceUtils.isIdTagLocalAuthorized(chargingStation, idTag)
@@ -240,15 +239,11 @@ export class OCPPServiceUtils {
       const connectorStatus: ConnectorStatus = chargingStation.getConnectorStatus(connectorId)!;
       connectorStatus.localAuthorizeIdTag = idTag;
       connectorStatus.idTagLocalAuthorized = true;
-      authorized = true;
+      return true;
     } else if (chargingStation.getRemoteAuthorization()) {
-      authorized = await OCPPServiceUtils.isIdTagRemoteAuthorized(
-        chargingStation,
-        connectorId,
-        idTag,
-      );
+      return await OCPPServiceUtils.isIdTagRemoteAuthorized(chargingStation, connectorId, idTag);
     }
-    return authorized;
+    return false;
   }
 
   protected static checkConnectorStatusTransition(