fix(qav3): refine optuna loaded study validation test

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
index 8820b80fb284a90abf35ba47e06eebf945e30e89..04152a8caf6eb6fea92df037346f56dec849e616 100644 (file)
--- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
@@ -394,14 +394,8 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
         if not study:
             return False
         try:
-            # Check if there are completed trials
-            if len(study.trials) == 0:
-                return False
-
-            # Check if best_params exists (raises ValueError if no trials succeeded)
-            _ = study.best_params
-            return True
-        except ValueError:
+            _ = study.trials
+        except KeyError:
             return False
 
 

diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
index fa3fedfede36642d1f990be516e5fffc95639c76..0872136c9cdb2f21bf930decdfa2efae9778c377 100644 (file)
--- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
@@ -395,14 +395,8 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
         if not study:
             return False
         try:
-            # Check if there are completed trials
-            if len(study.trials) == 0:
-                return False
-
-            # Check if best_params exists (raises ValueError if no trials succeeded)
-            _ = study.best_params
-            return True
-        except ValueError:
+            _ = study.trials
+        except KeyError:
             return False