]> Piment Noir Git Repositories - e-mobility-charging-stations-simulator.git/commitdiff
refactor(ocpp2): harmonize and condense audit comments to match existing FR style
authorJérôme Benoit <jerome.benoit@sap.com>
Thu, 19 Mar 2026 11:29:15 +0000 (12:29 +0100)
committerJérôme Benoit <jerome.benoit@sap.com>
Thu, 19 Mar 2026 11:29:15 +0000 (12:29 +0100)
src/charging-station/ocpp/2.0/OCPP20ResponseService.ts
src/charging-station/ocpp/2.0/OCPP20ServiceUtils.ts
src/types/ConnectorStatus.ts

index 6b6bcf2f51fefe35fdf5654d89ea3467564f5cc6..9810439b4eaaec213552706d56e5884ccc94a92d 100644 (file)
@@ -306,8 +306,7 @@ export class OCPP20ResponseService extends OCPPResponseService {
 
     switch (requestPayload.eventType) {
       case OCPP20TransactionEventEnumType.Ended:
-        // Cleanup (stopTxUpdatedInterval, resetConnectorStatus, StatusNotification) is owned by
-        // the caller that sends TransactionEvent(Ended) — see requestStopTransaction in OCPP20ServiceUtils.
+        // Cleanup owned by caller (see requestStopTransaction/requestDeauthorizeTransaction)
         if (connectorId != null) {
           logger.info(
             `${chargingStation.logPrefix()} ${moduleName}.handleResponseTransactionEvent: Transaction ${requestPayload.transactionInfo.transactionId} ENDED on connector ${connectorId.toString()}`
index c22147d076e0a071587e65bb9ff152490dd086d4..866a36b5bad11ca6a7f83171319ce33c9330b4c7 100644 (file)
@@ -292,9 +292,7 @@ export class OCPP20ServiceUtils extends OCPPServiceUtils {
     return { bytesLimit, itemsLimit }
   }
 
-  // E05.FR.09/FR.10 + E06.FR.04: Deauthorization flow when CSMS rejects idToken.
-  // Assumes StopTxOnInvalidId=true (simulator default). Sends Updated(Deauthorized, SuspendedEVSE)
-  // then Ended(Deauthorized, DeAuthorized) then cleanup.
+  // E05.FR.09/FR.10 + E06.FR.04: Updated(Deauthorized) → Ended(DeAuthorized). Assumes StopTxOnInvalidId=true.
   public static async requestDeauthorizeTransaction (
     chargingStation: ChargingStation,
     connectorId: number,
index c6b407c10d98a24beaf363ed84b59cf950653b0e..f6f40ec1b0ff4535f9d095bb9aa173c82dd9826b 100644 (file)
@@ -44,9 +44,8 @@ export interface ConnectorStatus {
    */
   transactionIdTokenSent?: boolean
   /**
-   * OCPP 2.0.1: Transaction is pending CSMS acknowledgment via TransactionEvent response.
-   * Set by RequestStartTransaction handler to block duplicate starts before the response
-   * handler finalizes the transaction state with transactionStarted = true.
+   * OCPP 2.0.1 E02 compliance: Transaction pending CSMS acknowledgment.
+   * Blocks duplicate RequestStartTransaction until response handler sets transactionStarted.
    */
   transactionPending?: boolean
   transactionRemoteStarted?: boolean