From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date: Tue, 21 Jun 2011 08:33:50 +0000 (+1000)
Subject: Add a very subtle bug in nfs_set_error()
X-Git-Tag: upstream/1.9.6^2~390
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;ds=inline;h=1e8994af0fde29bb03c52c5c4a972ef8d8ddbc33;hp=1e8994af0fde29bb03c52c5c4a972ef8d8ddbc33;p=deb_libnfs.git

Add a very subtle bug in nfs_set_error()
when nfs_set_error is called with error_string being the result of a lower layer
problem so it is passed as "rpc_get_error()"

This meant that since free that nfs->rpc->error_string before we reference it a few lines further down in the vasprintf(..., error_string,
adn memory corruption triggers.

Valgrind found this, Valgrind rules!
---