From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Thu, 9 Oct 2025 20:24:19 +0000 (+0200)
Subject: test(reforcexy): fix np.isclose() invocation
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=29106f8f272ca143ec091c67cd1e8faacc0725c8;p=freqai-strategies.git

test(reforcexy): fix np.isclose() invocation

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/ReforceXY/reward_space_analysis/reward_space_analysis.py b/ReforceXY/reward_space_analysis/reward_space_analysis.py
index c9c88e0..eaf9b4f 100644
--- a/ReforceXY/reward_space_analysis/reward_space_analysis.py
+++ b/ReforceXY/reward_space_analysis/reward_space_analysis.py
@@ -1378,7 +1378,7 @@ def compute_distribution_shift_metrics(
         # Guard against degenerate distributions (all values identical)
         if not np.isfinite(min_val) or not np.isfinite(max_val):
             continue
-        if np.isclose(max_val, min_val, rel_tol=0, abs_tol=1e-12):
+        if np.isclose(max_val, min_val, rtol=0, atol=1e-12):
             # All mass at a single point -> shift metrics are all zero by definition
             metrics[f"{feature}_kl_divergence"] = 0.0
             metrics[f"{feature}_js_distance"] = 0.0