From: Jérôme Benoit <jerome.benoit@sap.com>
Date: Thu, 27 Oct 2022 19:52:32 +0000 (+0200)
Subject: Use similar type check for is-empty-object benchmark
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=2d1206f1242a122d7682e44cf08472abe85013bc;hp=adad2e802d5120d237bb9620a1987535271f9784;p=benchmarks-js.git

Use similar type check for is-empty-object benchmark

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---

diff --git a/is-empty-object.js b/is-empty-object.js
index d5d7fd7..43059bb 100644
--- a/is-empty-object.js
+++ b/is-empty-object.js
@@ -1,7 +1,7 @@
 const Benchmark = require('benny')
 const { generateRandomInteger } = require('./benchmark-utils')
 
-const size = generateRandomInteger(100000)
+const size = generateRandomInteger(500)
 const testObject = {}
 for (let i = 0; i < size; i++) {
   testObject[i.toString()] = i
@@ -10,7 +10,7 @@ for (let i = 0; i < size; i++) {
 Benchmark.suite(
   `Is empty object with ${size} keys`,
   Benchmark.add('Reflect keys', (obj = testObject) => {
-    return Reflect.ownKeys(obj).length === 0 && obj?.constructor === Object
+    return obj?.constructor === Object && Reflect.ownKeys(obj).length === 0
   }),
   Benchmark.add('Keys iteration', (obj = testObject) => {
     if (obj?.constructor !== Object) return false
@@ -21,7 +21,7 @@ Benchmark.suite(
     return true
   }),
   Benchmark.add('Object keys', (obj = testObject) => {
-    return obj?.constructor === Object && !Object.keys(obj).length
+    return obj?.constructor === Object && Object.keys(obj).length === 0
   }),
   Benchmark.cycle(),
   Benchmark.complete(),