From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Mon, 25 Sep 2023 09:10:45 +0000 (+0200)
Subject: refactor: use delete on properties
X-Git-Tag: v2.7.4~4
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=410724041bab556be1385c56f9a32e5030f6f2cf;hp=b04bd0f17e1ef9d2b5bd13ec69405f03ee86ff51;p=poolifier.git

refactor: use delete on properties

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/src/deque.ts b/src/deque.ts
index 2eae8034..723f1a49 100644
--- a/src/deque.ts
+++ b/src/deque.ts
@@ -76,14 +76,14 @@ export class Deque<T> {
    */
   public pop (): T | undefined {
     if (this.head == null) {
-      return undefined
+      return
     }
     const tail = this.tail
     this.tail = (this.tail as Node<T>).prev
     if (this.tail == null) {
-      this.head = undefined
+      delete this.head
     } else {
-      this.tail.next = undefined
+      delete this.tail.next
     }
     --this.size
     return tail?.data
@@ -96,14 +96,14 @@ export class Deque<T> {
    */
   public shift (): T | undefined {
     if (this.head == null) {
-      return undefined
+      return
     }
     const head = this.head
     this.head = this.head.next
     if (this.head == null) {
-      this.tail = undefined
+      delete this.tail
     } else {
-      this.head.prev = undefined
+      delete this.head.prev
     }
     --this.size
     return head?.data
@@ -129,8 +129,8 @@ export class Deque<T> {
    * Clears the deque.
    */
   public clear (): void {
-    this.head = undefined
-    this.tail = undefined
+    delete this.head
+    delete this.tail
     this.size = 0
     this.maxSize = 0
   }
diff --git a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
index 5ec7cedc..630a2258 100644
--- a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
+++ b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
@@ -208,7 +208,7 @@ export abstract class AbstractWorkerChoiceStrategy<
    */
   protected checkNextWorkerNodeEligibility (): void {
     if (!this.isWorkerNodeEligible(this.nextWorkerNodeKey as number)) {
-      this.nextWorkerNodeKey = undefined
+      delete this.nextWorkerNodeKey
     }
   }
 
diff --git a/tests/worker/abstract-worker.test.js b/tests/worker/abstract-worker.test.js
index 200b05ac..1b055217 100644
--- a/tests/worker/abstract-worker.test.js
+++ b/tests/worker/abstract-worker.test.js
@@ -7,7 +7,7 @@ describe('Abstract worker test suite', () => {
   class StubWorkerWithMainWorker extends ThreadWorker {
     constructor (fn, opts) {
       super(fn, opts)
-      this.mainWorker = undefined
+      delete this.mainWorker
     }
   }