From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Sun, 16 Feb 2025 11:25:26 +0000 (+0100)
Subject: fix(qav3): brown paper bag bug in optuna_study_has_best_params()
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=56c884e35992d6971e771fc605449c91314e8635;p=freqai-strategies.git

fix(qav3): brown paper bag bug in optuna_study_has_best_params()

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
index 5438566..69d50fb 100644
--- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
@@ -407,7 +407,8 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
         if not study:
             return False
         try:
-            _ = study.trials
+            _ = study.best_params
+            return True
         except KeyError:
             return False
 
diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
index 7038dff..cdc6dce 100644
--- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
@@ -408,7 +408,8 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
         if not study:
             return False
         try:
-            _ = study.trials
+            _ = study.best_params
+            return True
         except KeyError:
             return False