From: Jérôme Benoit Date: Sat, 15 Mar 2025 16:27:20 +0000 (+0100) Subject: refactor: refine a test X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=60d3a7c589929c9132de81d158c7d639066a3d33;p=freqai-strategies.git refactor: refine a test Signed-off-by: Jérôme Benoit --- diff --git a/ReforceXY/user_data/freqaimodels/ReforceXY.py b/ReforceXY/user_data/freqaimodels/ReforceXY.py index c500b06..7e21c9d 100644 --- a/ReforceXY/user_data/freqaimodels/ReforceXY.py +++ b/ReforceXY/user_data/freqaimodels/ReforceXY.py @@ -502,7 +502,7 @@ class ReforceXY(BaseReinforcementLearningModel): return storage def study_has_best_trial_params(self, study: Study | None) -> bool: - if not study: + if study is None: return False try: _ = study.best_trial.params diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py index bea7910..98c7e33 100644 --- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py @@ -484,7 +484,7 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): return study def optuna_study_has_best_params(self, study: optuna.study.Study | None) -> bool: - if not study: + if study is None: return False try: _ = study.best_params diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py index e2cabdd..b2a40ae 100644 --- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py @@ -487,7 +487,7 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel): return study def optuna_study_has_best_params(self, study: optuna.study.Study | None) -> bool: - if not study: + if study is None: return False try: _ = study.best_params