From: Jérôme Benoit Date: Fri, 21 Nov 2025 19:38:45 +0000 (+0100) Subject: refactor(qav3): code cleanups X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=831fc13a0af4d852e4844ac39d64606892521ed4;p=freqai-strategies.git refactor(qav3): code cleanups Signed-off-by: Jérôme Benoit --- diff --git a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py index 1c8cdbf..427c126 100644 --- a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py +++ b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py @@ -303,7 +303,7 @@ class QuickAdapterRegressorV3(BaseRegressionModel): self._optuna_label_candles[pair] = 0 self.regressor: Regressor = self.freqai_info.get("regressor", REGRESSORS[0]) - if self.regressor not in REGRESSORS: + if self.regressor not in set(REGRESSORS): self.regressor = REGRESSORS[0] self.freqai_info["regressor"] = self.regressor logger.info( diff --git a/quickadapter/user_data/strategies/Utils.py b/quickadapter/user_data/strategies/Utils.py index 34bd96e..d727698 100644 --- a/quickadapter/user_data/strategies/Utils.py +++ b/quickadapter/user_data/strategies/Utils.py @@ -980,11 +980,11 @@ def zigzag( pivots_values.append(value) pivots_directions.append(direction) if len(pivots_values) > 1: - prev_value = pivots_values[-2] - if np.isclose(prev_value, 0.0): + prev_pivot_value = pivots_values[-2] + if np.isclose(prev_pivot_value, 0.0): amplitude = np.nan else: - amplitude = abs(value - prev_value) / abs(prev_value) + amplitude = abs(value - prev_pivot_value) / abs(prev_pivot_value) current_threshold = thresholds[pos] if ( np.isfinite(current_threshold)