From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Mon, 17 Feb 2025 13:52:49 +0000 (+0100)
Subject: refactor(qav3): trivial cleanup
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=87a981bd94279c1980da2e54618eb1a4e75bde99;p=freqai-strategies.git

refactor(qav3): trivial cleanup

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
index 0de8167..8e71c3c 100644
--- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
@@ -176,8 +176,8 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
         )
 
         if not warmed_up:
-            dk.data["extra_returns_per_train"][MAXIMA_THRESHOLD_COLUMN] = 2
             dk.data["extra_returns_per_train"][MINIMA_THRESHOLD_COLUMN] = -2
+            dk.data["extra_returns_per_train"][MAXIMA_THRESHOLD_COLUMN] = 2
         else:
             if self.__optuna_hyperopt:
                 label_period_candles = self.__optuna_period_params.get(pair, {}).get(
diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
index 6618be3..65e1ffe 100644
--- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
@@ -177,8 +177,8 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
         )
 
         if not warmed_up:
-            dk.data["extra_returns_per_train"][MAXIMA_THRESHOLD_COLUMN] = 2
             dk.data["extra_returns_per_train"][MINIMA_THRESHOLD_COLUMN] = -2
+            dk.data["extra_returns_per_train"][MAXIMA_THRESHOLD_COLUMN] = 2
         else:
             if self.__optuna_hyperopt:
                 label_period_candles = self.__optuna_period_params.get(pair, {}).get(