From: Jérôme Benoit <jerome.benoit@sap.com>
Date: Thu, 13 Oct 2022 21:54:51 +0000 (+0200)
Subject: Tests: be more strict on number expectation
X-Git-Tag: v2.3.2~19
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=978aad6fbbc3042c2890893ae3ae7ff34af0385e;p=poolifier.git

Tests: be more strict on number expectation

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---

diff --git a/benchmarks/versus-external-pools/dynamic-piscina.js b/benchmarks/versus-external-pools/dynamic-piscina.js
index d78dd568c..83190d43c 100644
--- a/benchmarks/versus-external-pools/dynamic-piscina.js
+++ b/benchmarks/versus-external-pools/dynamic-piscina.js
@@ -12,7 +12,7 @@ const piscina = new Piscina({
   filename: './workers/piscina/function-to-bench-worker.js',
   minThreads: size,
   maxThreads: size * 3,
-  idleTimeout: 1000 * 60 // this is the same as poolifier default
+  idleTimeout: 60000 // this is the same as poolifier default
 })
 
 async function run () {
diff --git a/benchmarks/versus-external-pools/fixed-piscina.js b/benchmarks/versus-external-pools/fixed-piscina.js
index d1f785ede..c89a951d2 100644
--- a/benchmarks/versus-external-pools/fixed-piscina.js
+++ b/benchmarks/versus-external-pools/fixed-piscina.js
@@ -11,7 +11,7 @@ const data = {
 const piscina = new Piscina({
   filename: './workers/piscina/function-to-bench-worker.js',
   minThreads: size,
-  idleTimeout: 1000 * 60 // this is the same as poolifier default
+  idleTimeout: 60000 // this is the same as poolifier default
 })
 
 async function run () {
diff --git a/src/worker/abstract-worker.ts b/src/worker/abstract-worker.ts
index 4aad8e626..52143fe30 100644
--- a/src/worker/abstract-worker.ts
+++ b/src/worker/abstract-worker.ts
@@ -6,7 +6,7 @@ import { EMPTY_FUNCTION } from '../utils'
 import type { KillBehavior, WorkerOptions } from './worker-options'
 import { KillBehaviors } from './worker-options'
 
-const DEFAULT_MAX_INACTIVE_TIME = 1000 * 60
+const DEFAULT_MAX_INACTIVE_TIME = 60000
 const DEFAULT_KILL_BEHAVIOR: KillBehavior = KillBehaviors.SOFT
 
 /**
diff --git a/tests/worker/abstract-worker.test.js b/tests/worker/abstract-worker.test.js
index 9c8dd0973..c75227cc0 100644
--- a/tests/worker/abstract-worker.test.js
+++ b/tests/worker/abstract-worker.test.js
@@ -17,7 +17,7 @@ describe('Abstract worker test suite', () => {
 
   it('Verify worker options default values', () => {
     const worker = new ThreadWorker(() => {})
-    expect(worker.opts.maxInactiveTime).toBe(1000 * 60)
+    expect(worker.opts.maxInactiveTime).toStrictEqual(60000)
     expect(worker.opts.killBehavior).toBe(KillBehaviors.SOFT)
     expect(worker.opts.async).toBe(false)
   })
@@ -28,7 +28,7 @@ describe('Abstract worker test suite', () => {
       async: true,
       killBehavior: KillBehaviors.HARD
     })
-    expect(worker.opts.maxInactiveTime).toBe(6000)
+    expect(worker.opts.maxInactiveTime).toStrictEqual(6000)
     expect(worker.opts.killBehavior).toBe(KillBehaviors.HARD)
     expect(worker.opts.async).toBe(true)
   })