From: Jérôme Benoit <jerome.benoit@sap.com>
Date: Fri, 14 Oct 2022 06:40:51 +0000 (+0200)
Subject: Default random integer generation to maximun safe value
X-Git-Tag: v2.3.2~17
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=9bc18a6d9bba455b461e484e182fae3dc56a5549;p=poolifier.git

Default random integer generation to maximun safe value

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---

diff --git a/benchmarks/internal/benchmark-utils.js b/benchmarks/internal/benchmark-utils.js
index a7e4ddecd..60cecbe5c 100644
--- a/benchmarks/internal/benchmark-utils.js
+++ b/benchmarks/internal/benchmark-utils.js
@@ -34,7 +34,7 @@ function jsonIntegerSerialization (n) {
   }
 }
 
-function generateRandomInteger (max, min = 0) {
+function generateRandomInteger (max = Number.MAX_SAFE_INTEGER, min = 0) {
   max = Math.floor(max)
   if (min) {
     min = Math.ceil(min)
diff --git a/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js b/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js
index 41c7751cc..9d87c6997 100644
--- a/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js
+++ b/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js
@@ -25,12 +25,8 @@ describe('Weighted round robin strategy worker choice strategy test suite', () =
 
   it('Verify that reset() resets internals', () => {
     const strategy = new WeightedRoundRobinWorkerChoiceStrategy(pool)
-    strategy.previousWorkerIndex = TestUtils.generateRandomInteger(
-      Number.MAX_SAFE_INTEGER
-    )
-    strategy.currentWorkerIndex = TestUtils.generateRandomInteger(
-      Number.MAX_SAFE_INTEGER
-    )
+    strategy.previousWorkerIndex = TestUtils.generateRandomInteger()
+    strategy.currentWorkerIndex = TestUtils.generateRandomInteger()
     const workersTaskRunTimeClearStub = sinon
       .stub(strategy.workersTaskRunTime, 'clear')
       .returns()
diff --git a/tests/test-utils.js b/tests/test-utils.js
index a3affb61c..9a49c8229 100644
--- a/tests/test-utils.js
+++ b/tests/test-utils.js
@@ -36,7 +36,7 @@ class TestUtils {
     })
   }
 
-  static generateRandomInteger (max, min = 0) {
+  static generateRandomInteger (max = Number.MAX_SAFE_INTEGER, min = 0) {
     max = Math.floor(max)
     if (min) {
       min = Math.ceil(min)