From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Fri, 25 Aug 2023 15:42:56 +0000 (+0200)
Subject: refactor: ensure stolen tasks account is done safely
X-Git-Tag: v2.6.35~10
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=b2559a74817131f03cd8184013084cc8314a6167;p=poolifier.git

refactor: ensure stolen tasks account is done safely

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/src/pools/abstract-pool.ts b/src/pools/abstract-pool.ts
index 4abbd615..3cc8b220 100644
--- a/src/pools/abstract-pool.ts
+++ b/src/pools/abstract-pool.ts
@@ -1238,6 +1238,17 @@ export abstract class AbstractPool<
     }
   }
 
+  // private incrementTasksStolen (workerNodeKey: number, workerNode: WorkerNode): void {
+  //   ++workerNode.usage.tasks.stolen
+  //   if (this.shallUpdateTaskFunctionWorkerUsage(workerNodeKey)) {
+  //     const taskFunctionWorkerUsage =
+  //       workerNode.getTaskFunctionWorkerUsage(
+  //         task.name as string
+  //       ) as WorkerUsage
+  //     ++taskFunctionWorkerUsage.tasks.stolen
+  //   }
+  // }
+
   private taskStealingOnEmptyQueue (workerId: number): void {
     const destinationWorkerNodeKey = this.getWorkerNodeKeyByWorkerId(workerId)
     const destinationWorkerNode = this.workerNodes[destinationWorkerNodeKey]
@@ -1269,8 +1280,15 @@ export abstract class AbstractPool<
         } else {
           this.enqueueTask(destinationWorkerNodeKey, task)
         }
-        ++destinationWorkerNode.usage.tasks.stolen
-        if (this.shallUpdateTaskFunctionWorkerUsage(destinationWorkerNodeKey)) {
+        if (destinationWorkerNode?.usage != null) {
+          ++destinationWorkerNode.usage.tasks.stolen
+        }
+        if (
+          this.shallUpdateTaskFunctionWorkerUsage(destinationWorkerNodeKey) &&
+          destinationWorkerNode.getTaskFunctionWorkerUsage(
+            task.name as string
+          ) != null
+        ) {
           const taskFunctionWorkerUsage =
             destinationWorkerNode.getTaskFunctionWorkerUsage(
               task.name as string
@@ -1312,8 +1330,13 @@ export abstract class AbstractPool<
         } else {
           this.enqueueTask(workerNodeKey, task)
         }
-        ++workerNode.usage.tasks.stolen
-        if (this.shallUpdateTaskFunctionWorkerUsage(workerNodeKey)) {
+        if (workerNode?.usage != null) {
+          ++workerNode.usage.tasks.stolen
+        }
+        if (
+          this.shallUpdateTaskFunctionWorkerUsage(workerNodeKey) &&
+          workerNode.getTaskFunctionWorkerUsage(task.name as string) != null
+        ) {
           const taskFunctionWorkerUsage = workerNode.getTaskFunctionWorkerUsage(
             task.name as string
           ) as WorkerUsage