From: Arne Redlich <arne.redlich@googlemail.com>
Date: Mon, 17 Feb 2014 22:51:48 +0000 (+0100)
Subject: nfs_fchown_async: fix use-after-free
X-Git-Tag: upstream/1.9.6^2~95
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=b41762c0d85faddf7a2d553c164abd6f881be398;p=deb_libnfs.git

nfs_fchown_async: fix use-after-free

Spotted by clang analyzer.

Signed-off-by: Arne Redlich <arne.redlich@googlemail.com>
---

diff --git a/lib/libnfs.c b/lib/libnfs.c
index b064028..910e4d2 100644
--- a/lib/libnfs.c
+++ b/lib/libnfs.c
@@ -3446,7 +3446,6 @@ int nfs_fchown_async(struct nfs_context *nfs, struct nfsfh *nfsfh, int uid, int
 	memcpy(data->fh.data.data_val, nfsfh->fh.data.data_val, data->fh.data.data_len);
 
 	if (nfs_chown_continue_internal(nfs, data) != 0) {
-		free_nfs_cb_data(data);
 		return -1;
 	}