From: Jérôme Benoit <jerome.benoit@sap.com>
Date: Sat, 28 Feb 2026 13:09:50 +0000 (+0100)
Subject: refactor(tests): remove file-level eslint-disable and fix as any casts
X-Git-Tag: v3~93
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=b63423200a90fd704738e7694920dcc6c83e9326;p=e-mobility-charging-stations-simulator.git

refactor(tests): remove file-level eslint-disable and fix as any casts

- Remove blanket eslint-disable comments from OCPP 2.0 test files
- Fix improper 'as any' casts in afterEach cleanup (use union types)
- Add targeted inline eslint-disable-next-line for legitimate test cases
  (testing null/undefined inputs for edge case validation)
---

diff --git a/tests/charging-station/ocpp/2.0/OCPP20CertificateManager.test.ts b/tests/charging-station/ocpp/2.0/OCPP20CertificateManager.test.ts
index b126c688..ea73f677 100644
--- a/tests/charging-station/ocpp/2.0/OCPP20CertificateManager.test.ts
+++ b/tests/charging-station/ocpp/2.0/OCPP20CertificateManager.test.ts
@@ -2,7 +2,6 @@
  * @file Tests for OCPP20CertificateManager
  * @description Unit tests for OCPP 2.0 certificate management and validation
  */
-/* eslint-disable @typescript-eslint/no-explicit-any */
 
 import { expect } from '@std/expect'
 import { rm } from 'node:fs/promises'
@@ -322,7 +321,9 @@ await describe('OCPP20CertificateManager', async () => {
     await it('should return false for null/undefined input', () => {
       const manager = new OCPP20CertificateManager()
 
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any -- testing invalid null input
       expect(manager.validateCertificateFormat(null as any)).toBe(false)
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any -- testing invalid undefined input
       expect(manager.validateCertificateFormat(undefined as any)).toBe(false)
     })
 
diff --git a/tests/charging-station/ocpp/2.0/OCPP20IncomingRequestService-RemoteStartAuth.test.ts b/tests/charging-station/ocpp/2.0/OCPP20IncomingRequestService-RemoteStartAuth.test.ts
index 5d4b9e5e..eb510b71 100644
--- a/tests/charging-station/ocpp/2.0/OCPP20IncomingRequestService-RemoteStartAuth.test.ts
+++ b/tests/charging-station/ocpp/2.0/OCPP20IncomingRequestService-RemoteStartAuth.test.ts
@@ -2,9 +2,6 @@
  * @file Tests for OCPP20IncomingRequestService RemoteStartAuth
  * @description Unit tests for OCPP 2.0 remote start pre-authorization (G03.FR.03)
  */
-/* eslint-disable @typescript-eslint/no-unsafe-assignment */
-
-/* eslint-disable @typescript-eslint/no-explicit-any */
 
 import { expect } from '@std/expect'
 import { afterEach, beforeEach, describe, it } from 'node:test'
@@ -28,8 +25,8 @@ import {
 import { OCPPVersion } from '../../../../src/types/ocpp/OCPPVersion.js'
 
 await describe('OCPP20IncomingRequestService - G03.FR.03 Remote Start Pre-Authorization', async () => {
-  let service: OCPP20IncomingRequestService
-  let mockChargingStation: ChargingStation
+  let service: OCPP20IncomingRequestService | undefined
+  let mockChargingStation: ChargingStation | undefined
 
   beforeEach(() => {
     // Mock charging station with EVSE configuration
@@ -64,8 +61,8 @@ await describe('OCPP20IncomingRequestService - G03.FR.03 Remote Start Pre-Author
 
   afterEach(() => {
     // Reset service and mock charging station state
-    mockChargingStation = undefined as any
-    service = undefined as any
+    mockChargingStation = undefined
+    service = undefined
   })
 
   await describe('G03.FR.03.001 - Successful remote start with valid token', async () => {
@@ -202,6 +199,7 @@ await describe('OCPP20IncomingRequestService - G03.FR.03 Remote Start Pre-Author
       // Given: Request without evseId (null)
 
       const request: OCPP20RequestStartTransactionRequest = {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any -- testing invalid null input
         evseId: null as any,
         idToken: {
           idToken: 'VALID_TOKEN_005',
@@ -218,6 +216,7 @@ await describe('OCPP20IncomingRequestService - G03.FR.03 Remote Start Pre-Author
       // Given: Request without evseId (undefined)
 
       const request: OCPP20RequestStartTransactionRequest = {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any -- testing invalid undefined input
         evseId: undefined as any,
         idToken: {
           idToken: 'VALID_TOKEN_006',