From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Sun, 11 Feb 2024 15:25:16 +0000 (+0100)
Subject: fix: ensure `worker_threads` workers are unreferenced at termination
X-Git-Tag: v3.1.20~2
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=d20cde8460b36578a4a7c1dedb3a8805f2e8bffa;p=poolifier.git

fix: ensure `worker_threads` workers are unreferenced at termination

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ab225e96..36a6bc50 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Ensure `worker_threads` workers are unreferenced at termination.
+
 ## [3.1.19] - 2024-01-16
 
 ### Fixed
diff --git a/src/pools/worker-node.ts b/src/pools/worker-node.ts
index 30821517..523036a5 100644
--- a/src/pools/worker-node.ts
+++ b/src/pools/worker-node.ts
@@ -137,6 +137,7 @@ export class WorkerNode<Worker extends IWorker, Data = unknown>
     this.removeAllListeners()
     switch (this.info.type) {
       case WorkerTypes.thread:
+        this.worker.unref?.()
         await this.worker.terminate?.()
         break
       case WorkerTypes.cluster:
diff --git a/src/pools/worker.ts b/src/pools/worker.ts
index 05f6606e..d4075483 100644
--- a/src/pools/worker.ts
+++ b/src/pools/worker.ts
@@ -235,6 +235,12 @@ export interface IWorker extends EventEmitter {
    * @param handler - The event handler.
    */
   readonly once: (event: string, handler: EventHandler<this>) => this
+  /**
+   * Calling `unref()` on a worker allows the thread to exit if this is the only
+   * active handle in the event system. If the worker is already `unref()`ed calling`unref()` again has no effect.
+   * @since v10.5.0
+   */
+  readonly unref?: () => void
   /**
    * Stop all JavaScript execution in the worker thread as soon as possible.
    * Returns a Promise for the exit code that is fulfilled when the `'exit' event` is emitted.