From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Sat, 15 Feb 2025 13:37:20 +0000 (+0100)
Subject: fix(qav3): return only optimized params at HPO
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=dbde74d20c745d775800b818a0c18728a27ec945;p=freqai-strategies.git

fix(qav3): return only optimized params at HPO

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
index 1ca8453..45c169e 100644
--- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
@@ -309,9 +309,9 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
             logger.error(f"Optuna hp hyperopt failed: {e}", exc_info=True)
             return None
 
-        params = {"rmse": study.best_value, **study.best_params}
+        params = study.best_params
         # log params
-        for key, value in params.items():
+        for key, value in {"rmse": study.best_value, **params}.items():
             logger.info(f"Optuna hp hyperopt | {key:>20s} : {value}")
         return params
 
diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
index 27e4e48..189f0b8 100644
--- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
@@ -310,9 +310,9 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
             logger.error(f"Optuna hp hyperopt failed: {e}", exc_info=True)
             return None
 
-        params = {"rmse": study.best_value, **study.best_params}
+        params = study.best_params
         # log params
-        for key, value in params.items():
+        for key, value in {"rmse": study.best_value, **params}.items():
             logger.info(f"Optuna hp hyperopt | {key:>20s} : {value}")
         return params