From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Wed, 24 Dec 2025 21:15:55 +0000 (+0100)
Subject: refactor(ReforceXY): align methods signature
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=e6d7ce108f688bb91b0a244f9837591cfce9e70c;p=freqai-strategies.git

refactor(ReforceXY): align methods signature

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/ReforceXY/user_data/freqaimodels/ReforceXY.py b/ReforceXY/user_data/freqaimodels/ReforceXY.py
index e88efb6..1e55c47 100644
--- a/ReforceXY/user_data/freqaimodels/ReforceXY.py
+++ b/ReforceXY/user_data/freqaimodels/ReforceXY.py
@@ -2012,9 +2012,9 @@ class MyRLEnv(Base5ActionRLEnv):
     def _compute_hold_potential(
         self,
         position: Positions,
-        duration_ratio: float,
         pnl: float,
         pnl_target: float,
+        duration_ratio: float,
         scale: float,
     ) -> float:
         """Compute PBRS potential Φ(s) for position holding states.
@@ -2432,9 +2432,9 @@ class MyRLEnv(Base5ActionRLEnv):
             if self._hold_potential_enabled:
                 next_potential = self._compute_hold_potential(
                     next_position,
-                    next_duration_ratio,
                     next_pnl,
                     pnl_target,
+                    next_duration_ratio,
                     hold_potential_scale,
                 )
                 reward_shaping = gamma * next_potential - prev_potential