From: Jérôme Benoit <jerome.benoit@piment-noir.org>
Date: Fri, 20 Jun 2025 11:06:10 +0000 (+0200)
Subject: refactor: cleanup error handling
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=f1547a41afe0521f58a9027aad04f7436d97a47e;p=freqai-strategies.git

refactor: cleanup error handling

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---

diff --git a/ReforceXY/user_data/freqaimodels/ReforceXY.py b/ReforceXY/user_data/freqaimodels/ReforceXY.py
index d9ef7fe..8f068bb 100644
--- a/ReforceXY/user_data/freqaimodels/ReforceXY.py
+++ b/ReforceXY/user_data/freqaimodels/ReforceXY.py
@@ -520,11 +520,7 @@ class ReforceXY(BaseReinforcementLearningModel):
         try:
             _ = study.best_trial
             return True
-        # file backend storage raises KeyError
-        except KeyError:
-            return False
-        # sqlite backend storage raises ValueError
-        except ValueError:
+        except (ValueError, KeyError):
             return False
 
     def study(
diff --git a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
index 09397e5..f9d3a06 100644
--- a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
+++ b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
@@ -1000,11 +1000,7 @@ class QuickAdapterRegressorV3(BaseRegressionModel):
         try:
             _ = study.best_trial
             return True
-        # file backend storage raises KeyError
-        except KeyError:
-            return False
-        # sqlite backend storage raises ValueError
-        except ValueError:
+        except (ValueError, KeyError):
             return False
 
     @staticmethod
@@ -1014,11 +1010,7 @@ class QuickAdapterRegressorV3(BaseRegressionModel):
         try:
             _ = study.best_trials
             return True
-        # file backend storage raises KeyError
-        except KeyError:
-            return False
-        # sqlite backend storage raises ValueError
-        except ValueError:
+        except (ValueError, KeyError):
             return False