From: Arne Redlich <arne.redlich@googlemail.com>
Date: Mon, 17 Feb 2014 22:50:17 +0000 (+0100)
Subject: nfs_fchmod_async: fix use-after-free
X-Git-Tag: upstream/1.9.6^2~96
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=faa15589f173e93279d32330030a6257600214c2;p=deb_libnfs.git

nfs_fchmod_async: fix use-after-free

Spotted by clang analyzer

Signed-off-by: Arne Redlich <arne.redlich@googlemail.com>
---

diff --git a/lib/libnfs.c b/lib/libnfs.c
index 9dbd234..b064028 100644
--- a/lib/libnfs.c
+++ b/lib/libnfs.c
@@ -3312,7 +3312,6 @@ int nfs_fchmod_async(struct nfs_context *nfs, struct nfsfh *nfsfh, int mode, nfs
 	memcpy(data->fh.data.data_val, nfsfh->fh.data.data_val, data->fh.data.data_len);
 
 	if (nfs_chmod_continue_internal(nfs, data) != 0) {
-		free_nfs_cb_data(data);
 		return -1;
 	}