From: Jérôme Benoit <jerome.benoit@sap.com>
Date: Wed, 22 Oct 2025 12:21:30 +0000 (+0200)
Subject: refactor: cleanup GetBaseReport implementation
X-Git-Url: https://git.piment-noir.org/?a=commitdiff_plain;h=refs%2Fheads%2Ffeat%2Fget-variables;p=e-mobility-charging-stations-simulator.git

refactor: cleanup GetBaseReport implementation

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---

diff --git a/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts b/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts
index 94935c8a..489f6e95 100644
--- a/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts
+++ b/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts
@@ -528,13 +528,7 @@ export class OCPP20IncomingRequestService extends OCPPIncomingRequestService {
       `${chargingStation.logPrefix()} ${moduleName}.handleRequestGetBaseReport: GetBaseReport request received with requestId ${commandPayload.requestId} and reportBase ${commandPayload.reportBase}`
     )
 
-    const supportedReportBases = [
-      ReportBaseEnumType.ConfigurationInventory,
-      ReportBaseEnumType.FullInventory,
-      ReportBaseEnumType.SummaryInventory,
-    ]
-
-    if (!supportedReportBases.includes(commandPayload.reportBase)) {
+    if (!Object.values(ReportBaseEnumType).includes(commandPayload.reportBase)) {
       logger.warn(
         `${chargingStation.logPrefix()} ${moduleName}.handleRequestGetBaseReport: Unsupported reportBase ${commandPayload.reportBase}`
       )