poolifier.git
16 months agobuild(deps-dev): apply updates
Jérôme Benoit [Sun, 9 Jul 2023 22:18:42 +0000 (00:18 +0200)] 
build(deps-dev): apply updates

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: incrementation consistency
Jérôme Benoit [Sun, 9 Jul 2023 22:04:47 +0000 (00:04 +0200)] 
refactor: incrementation consistency

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: cleanups to variable namespace
Jérôme Benoit [Sun, 9 Jul 2023 21:41:49 +0000 (23:41 +0200)] 
refactor: cleanups to variable namespace

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Sun, 9 Jul 2023 21:31:12 +0000 (23:31 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agorefactor: improve task functions type checking
Jérôme Benoit [Sun, 9 Jul 2023 21:29:41 +0000 (23:29 +0200)] 
refactor: improve task functions type checking

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sun, 9 Jul 2023 21:24:22 +0000 (21:24 +0000)] 
chore: generate documentation

16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Sun, 9 Jul 2023 21:20:49 +0000 (23:20 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agorefactor: cleanup task handling in worker code
Jérôme Benoit [Sun, 9 Jul 2023 21:19:13 +0000 (23:19 +0200)] 
refactor: cleanup task handling in worker code

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sun, 9 Jul 2023 20:49:46 +0000 (20:49 +0000)] 
chore: generate documentation

16 months agodocs: refine worker node code comments
Jérôme Benoit [Sun, 9 Jul 2023 20:46:39 +0000 (22:46 +0200)] 
docs: refine worker node code comments

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: cleanup task usage method namespace
Jérôme Benoit [Sun, 9 Jul 2023 20:29:26 +0000 (22:29 +0200)] 
refactor: cleanup task usage method namespace

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Sun, 9 Jul 2023 20:26:06 +0000 (22:26 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agodocs: fix README.md indentation
Jérôme Benoit [Sun, 9 Jul 2023 20:24:34 +0000 (22:24 +0200)] 
docs: fix README.md indentation

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sun, 9 Jul 2023 19:50:21 +0000 (19:50 +0000)] 
chore: generate documentation

16 months agodocs: fix typedoc warnings
Jérôme Benoit [Sun, 9 Jul 2023 19:46:40 +0000 (21:46 +0200)] 
docs: fix typedoc warnings

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofeat: add public methods to manipulate task functions
Jérôme Benoit [Sun, 9 Jul 2023 19:36:56 +0000 (21:36 +0200)] 
feat: add public methods to manipulate task functions

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofix: fix tasks usage accounting initializer
Jérôme Benoit [Sun, 9 Jul 2023 14:32:05 +0000 (16:32 +0200)] 
fix: fix tasks usage accounting initializer

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofix: fix async task statistics accounting
Jérôme Benoit [Sun, 9 Jul 2023 13:44:03 +0000 (15:44 +0200)] 
fix: fix async task statistics accounting

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Sun, 9 Jul 2023 13:39:28 +0000 (15:39 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agofeat: add initial infrastructure to track per task statistics
Jérôme Benoit [Sun, 9 Jul 2023 13:37:28 +0000 (15:37 +0200)] 
feat: add initial infrastructure to track per task statistics

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: add task function name to task performance
Jérôme Benoit [Sun, 9 Jul 2023 12:33:24 +0000 (14:33 +0200)] 
refactor: add task function name to task performance

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sun, 9 Jul 2023 12:17:46 +0000 (12:17 +0000)] 
chore: generate documentation

16 months agodocs: refine comments
Jérôme Benoit [Sun, 9 Jul 2023 12:14:09 +0000 (14:14 +0200)] 
docs: refine comments

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Sun, 9 Jul 2023 01:49:13 +0000 (03:49 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agorefactor: cleanup message handler conditions
Jérôme Benoit [Sun, 9 Jul 2023 01:47:54 +0000 (03:47 +0200)] 
refactor: cleanup message handler conditions

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sun, 9 Jul 2023 00:07:47 +0000 (00:07 +0000)] 
chore: generate documentation

16 months agochore: v2.6.12 v2.6.12
Jérôme Benoit [Sun, 9 Jul 2023 00:04:41 +0000 (02:04 +0200)] 
chore: v2.6.12

16 months agoMerge branch 'master' of github.com:jerome-benoit/poolifier
Jérôme Benoit [Sun, 9 Jul 2023 00:02:52 +0000 (02:02 +0200)] 
Merge branch 'master' of github.com:jerome-benoit/poolifier

16 months agofix: workaround import issue with `node:os` module in node 16.x.x
Jérôme Benoit [Sun, 9 Jul 2023 00:02:05 +0000 (02:02 +0200)] 
fix: workaround import issue with `node:os` module in node 16.x.x

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agodocs: update benchmark vs. external pools
Jérôme Benoit [Sat, 8 Jul 2023 23:48:20 +0000 (01:48 +0200)] 
docs: update benchmark vs. external pools

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
16 months agotest: improve pool and worker readiness tests
Jérôme Benoit [Sat, 8 Jul 2023 23:33:05 +0000 (01:33 +0200)] 
test: improve pool and worker readiness tests

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sat, 8 Jul 2023 23:17:14 +0000 (23:17 +0000)] 
chore: generate documentation

16 months agochore: v2.6.11 v2.6.11
Jérôme Benoit [Sat, 8 Jul 2023 23:14:56 +0000 (01:14 +0200)] 
chore: v2.6.11

16 months agofix: fix pool readiness semantic
Jérôme Benoit [Sat, 8 Jul 2023 23:10:44 +0000 (01:10 +0200)] 
fix: fix pool readiness semantic

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Sat, 8 Jul 2023 22:36:58 +0000 (00:36 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agotest: fix wrong async/await usage in describe()
Jérôme Benoit [Sat, 8 Jul 2023 22:34:53 +0000 (00:34 +0200)] 
test: fix wrong async/await usage in describe()

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sat, 8 Jul 2023 21:45:16 +0000 (21:45 +0000)] 
chore: generate documentation

16 months agochore: v2.6.10 v2.6.10
Jérôme Benoit [Sat, 8 Jul 2023 21:24:47 +0000 (23:24 +0200)] 
chore: v2.6.10

16 months agodocs: refine CHANGELOG.md
Jérôme Benoit [Sat, 8 Jul 2023 21:21:48 +0000 (23:21 +0200)] 
docs: refine CHANGELOG.md

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sat, 8 Jul 2023 21:18:04 +0000 (21:18 +0000)] 
chore: generate documentation

16 months agobuild(deps-dev): apply updates
Jérôme Benoit [Sat, 8 Jul 2023 21:15:18 +0000 (23:15 +0200)] 
build(deps-dev): apply updates

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agotest: improve pool events check tests
Jérôme Benoit [Sat, 8 Jul 2023 21:02:45 +0000 (23:02 +0200)] 
test: improve pool events check tests

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Sat, 8 Jul 2023 20:44:11 +0000 (22:44 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agofeat: internal messaging strict worker id checking
Jérôme Benoit [Sat, 8 Jul 2023 20:42:41 +0000 (22:42 +0200)] 
feat: internal messaging strict worker id checking

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Sat, 8 Jul 2023 19:14:17 +0000 (19:14 +0000)] 
chore: generate documentation

16 months agofeat: add pool and worker readyness tracking infrastructure
Jérôme Benoit [Sat, 8 Jul 2023 19:05:52 +0000 (21:05 +0200)] 
feat: add pool and worker readyness tracking infrastructure

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: rename worker `started` flag to `ready`
Jérôme Benoit [Fri, 7 Jul 2023 23:05:03 +0000 (01:05 +0200)] 
refactor: rename worker `started` flag to `ready`

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agodocs: add comments to worker node class
Jérôme Benoit [Fri, 7 Jul 2023 22:53:53 +0000 (00:53 +0200)] 
docs: add comments to worker node class

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Fri, 7 Jul 2023 22:40:07 +0000 (00:40 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agotest: cleanup worker functions return
Jérôme Benoit [Fri, 7 Jul 2023 22:37:57 +0000 (00:37 +0200)] 
test: cleanup worker functions return

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Fri, 7 Jul 2023 18:17:13 +0000 (18:17 +0000)] 
chore: generate documentation

16 months agorefactor: remove dead comment
Jérôme Benoit [Fri, 7 Jul 2023 18:05:56 +0000 (20:05 +0200)] 
refactor: remove dead comment

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: cleanups
Jérôme Benoit [Fri, 7 Jul 2023 18:00:55 +0000 (20:00 +0200)] 
refactor: cleanups

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: cleanup message passing code
Jérôme Benoit [Fri, 7 Jul 2023 17:33:38 +0000 (19:33 +0200)] 
refactor: cleanup message passing code

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Fri, 7 Jul 2023 16:09:56 +0000 (18:09 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agorefactor: encapsulate worker node handling logic into its own class
Jérôme Benoit [Fri, 7 Jul 2023 16:08:11 +0000 (18:08 +0200)] 
refactor: encapsulate worker node handling logic into its own class

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Fri, 7 Jul 2023 06:45:07 +0000 (06:45 +0000)] 
chore: generate documentation

16 months agochore: v2.6.9
Jérôme Benoit [Fri, 7 Jul 2023 06:41:09 +0000 (08:41 +0200)] 
chore: v2.6.9

16 months agochore: generate documentation
github-actions[bot] [Fri, 7 Jul 2023 06:37:02 +0000 (06:37 +0000)] 
chore: generate documentation

16 months agoMerge branch 'master' of github.com:jerome-benoit/poolifier
Jérôme Benoit [Thu, 6 Jul 2023 22:28:38 +0000 (00:28 +0200)] 
Merge branch 'master' of github.com:jerome-benoit/poolifier

16 months agodocs: update benchmark vs. external pools
Jérôme Benoit [Thu, 6 Jul 2023 22:27:41 +0000 (00:27 +0200)] 
docs: update benchmark vs. external pools

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
16 months agorefactor: cleanup worker message handling code
Jérôme Benoit [Thu, 6 Jul 2023 22:25:35 +0000 (00:25 +0200)] 
refactor: cleanup worker message handling code

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofeat: check worker inactive time only on dynamic worker
Jérôme Benoit [Thu, 6 Jul 2023 22:14:47 +0000 (00:14 +0200)] 
feat: check worker inactive time only on dynamic worker

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:poolifier/poolifier
Jérôme Benoit [Thu, 6 Jul 2023 21:42:54 +0000 (23:42 +0200)] 
Merge branch 'master' of github.com:poolifier/poolifier

16 months agodocs: refine README.md
Jérôme Benoit [Thu, 6 Jul 2023 21:41:37 +0000 (23:41 +0200)] 
docs: refine README.md

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: generate documentation
github-actions[bot] [Thu, 6 Jul 2023 20:14:04 +0000 (20:14 +0000)] 
chore: generate documentation

16 months agodocs: add poolifier version to typedoc
Jérôme Benoit [Thu, 6 Jul 2023 19:59:06 +0000 (21:59 +0200)] 
docs: add poolifier version to typedoc

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agodocs: refine benchmarks/README.md
Jérôme Benoit [Thu, 6 Jul 2023 18:54:05 +0000 (20:54 +0200)] 
docs: refine benchmarks/README.md

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofeat: add nanothreads to external pools benchmark
Jérôme Benoit [Thu, 6 Jul 2023 18:44:20 +0000 (20:44 +0200)] 
feat: add nanothreads to external pools benchmark

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agobuild(deps-dev): apply updates
Jérôme Benoit [Thu, 6 Jul 2023 17:42:20 +0000 (19:42 +0200)] 
build(deps-dev): apply updates

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agobuild(deps-dev): apply updates
Jérôme Benoit [Thu, 6 Jul 2023 17:13:19 +0000 (19:13 +0200)] 
build(deps-dev): apply updates

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: factor out code to redistribute queued tasks
Jérôme Benoit [Thu, 6 Jul 2023 00:21:07 +0000 (02:21 +0200)] 
refactor: factor out code to redistribute queued tasks

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofeat: add average and median to pool info runTime and waitTime
Jérôme Benoit [Wed, 5 Jul 2023 23:06:49 +0000 (01:06 +0200)] 
feat: add average and median to pool info runTime and waitTime

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: remove unneeded condition in measurement statistics code
Jérôme Benoit [Wed, 5 Jul 2023 22:09:25 +0000 (00:09 +0200)] 
refactor: remove unneeded condition in measurement statistics code

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofix: revert now unneeded workaround
Jérôme Benoit [Wed, 5 Jul 2023 22:02:30 +0000 (00:02 +0200)] 
fix: revert now unneeded workaround

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agodocs: refine FIXME comment
Jérôme Benoit [Wed, 5 Jul 2023 21:52:20 +0000 (23:52 +0200)] 
docs: refine FIXME comment

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofix: fix internal measurements handling
Jérôme Benoit [Wed, 5 Jul 2023 21:41:47 +0000 (23:41 +0200)] 
fix: fix internal measurements handling

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: use Set() instead of array in benchmarking code
Jérôme Benoit [Wed, 5 Jul 2023 17:13:02 +0000 (19:13 +0200)] 
refactor: use Set() instead of array in benchmarking code

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofeat: add task statistics to pool info: runTime and waitTime
Jérôme Benoit [Wed, 5 Jul 2023 07:13:26 +0000 (09:13 +0200)] 
feat: add task statistics to pool info: runTime and waitTime

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agobuild: disable esModuleInterop from TS configuration
Jérôme Benoit [Tue, 4 Jul 2023 21:02:09 +0000 (23:02 +0200)] 
build: disable esModuleInterop from TS configuration

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agorefactor: safer Math.{min,max} usage
Jérôme Benoit [Tue, 4 Jul 2023 20:22:27 +0000 (22:22 +0200)] 
refactor: safer Math.{min,max} usage

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofix: recreate the right worker type on uncaught error
Jérôme Benoit [Tue, 4 Jul 2023 20:00:44 +0000 (22:00 +0200)] 
fix: recreate the right worker type on uncaught error

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofeat: add minimum and maximum to internal measurements
Jérôme Benoit [Tue, 4 Jul 2023 18:28:58 +0000 (20:28 +0200)] 
feat: add minimum and maximum to internal measurements

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agodocs: update benchmark vs. external pools
Jérôme Benoit [Tue, 4 Jul 2023 17:49:24 +0000 (19:49 +0200)] 
docs: update benchmark vs. external pools

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
16 months agofix: use same task timeout default as poolifier when possible
Jérôme Benoit [Tue, 4 Jul 2023 15:41:17 +0000 (17:41 +0200)] 
fix: use same task timeout default as poolifier when possible

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoMerge branch 'master' of github.com:jerome-benoit/poolifier
Jérôme Benoit [Tue, 4 Jul 2023 15:14:04 +0000 (17:14 +0200)] 
Merge branch 'master' of github.com:jerome-benoit/poolifier

16 months agodocs: update benchmarks vs. external pools
Jérôme Benoit [Tue, 4 Jul 2023 15:13:20 +0000 (17:13 +0200)] 
docs: update benchmarks vs. external pools

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
16 months agorefactor: remove unneeded private getter
Jérôme Benoit [Tue, 4 Jul 2023 15:08:57 +0000 (17:08 +0200)] 
refactor: remove unneeded private getter

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agoRevert "fix: use version from package.json"
Jérôme Benoit [Tue, 4 Jul 2023 14:43:11 +0000 (16:43 +0200)] 
Revert "fix: use version from package.json"

This reverts commit 3f547eaffb7b81eac5389d8ddb40b4957770f400.

16 months agofix: use version from package.json
Jérôme Benoit [Tue, 4 Jul 2023 14:34:51 +0000 (16:34 +0200)] 
fix: use version from package.json

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agobuild(deps-dev): apply updates
Jérôme Benoit [Tue, 4 Jul 2023 12:31:31 +0000 (14:31 +0200)] 
build(deps-dev): apply updates

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agobuild: bump volta pnpm version
Jérôme Benoit [Tue, 4 Jul 2023 12:13:37 +0000 (14:13 +0200)] 
build: bump volta pnpm version

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofix: properly size the pools in benchmarking code
Jérôme Benoit [Tue, 4 Jul 2023 12:07:43 +0000 (14:07 +0200)] 
fix: properly size the pools in benchmarking code

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: v2.6.8 v2.6.8
Jérôme Benoit [Mon, 3 Jul 2023 21:48:56 +0000 (23:48 +0200)] 
chore: v2.6.8

16 months agochore: generate documentation
github-actions[bot] [Mon, 3 Jul 2023 21:47:30 +0000 (21:47 +0000)] 
chore: generate documentation

16 months agofix: fix version handling in pool information
Jérôme Benoit [Mon, 3 Jul 2023 21:45:12 +0000 (23:45 +0200)] 
fix: fix version handling in pool information

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agochore: v2.6.7 v2.6.7
Jérôme Benoit [Mon, 3 Jul 2023 21:22:14 +0000 (23:22 +0200)] 
chore: v2.6.7

16 months agochore: generate documentation
github-actions[bot] [Mon, 3 Jul 2023 21:20:33 +0000 (21:20 +0000)] 
chore: generate documentation

16 months agobuild(deps-dev): apply updates
Jérôme Benoit [Mon, 3 Jul 2023 21:18:16 +0000 (23:18 +0200)] 
build(deps-dev): apply updates

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
16 months agofix: fix availableParallelism() usage for pool min size
Jérôme Benoit [Mon, 3 Jul 2023 20:52:20 +0000 (22:52 +0200)] 
fix: fix availableParallelism() usage for pool min size

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>