Jérôme Benoit [Sun, 15 Mar 2026 23:13:20 +0000 (00:13 +0100)]
refactor: replace 54 unsafe error casts with instanceof guards
All 'error as Error', 'error as OCPPError', and 'error as
NodeJS.ErrnoException' casts replaced with proper instanceof
type narrowing across 16 files. Uses the pattern already
established in the auth strategies module:
error instanceof Error ? error.message : String(error)
For call sites that pass error objects to functions, wraps
non-Error values: error instanceof Error ? error : new Error(String(error))
Jérôme Benoit [Sun, 15 Mar 2026 22:57:20 +0000 (23:57 +0100)]
refactor(ocpp): extract responseHandler and incomingRequestHandler into base classes
Both methods were 95% identical across OCPP 1.6 and 2.0 subclasses
(~160 lines of pure duplication). Move the shared logic into the base
classes, parameterized by 3 abstract properties each subclass provides:
- bootNotificationRequestCommand / pendingStateBlockedCommands
- csmsName ('central system' vs 'CSMS')
- isRequestCommandSupported / isIncomingRequestCommandSupported
Zero behavior change — pure refactoring validated by 1853 passing tests.
Jérôme Benoit [Sun, 15 Mar 2026 22:37:22 +0000 (23:37 +0100)]
fix(ocpp): use per-subclass singleton map to prevent version collision
The singleton instance was stored as a single static field on the base
class. In mixed OCPP 1.6/2.0 workers, the first getInstance() call
wins — subsequent calls for a different version silently return the
wrong instance cast via 'as T'.
Replace with Map<Constructor, Instance> keyed by the concrete subclass
constructor. Each version now gets its own singleton entry. Zero
changes needed in subclasses or calling code.
Jérôme Benoit [Sun, 15 Mar 2026 22:24:20 +0000 (23:24 +0100)]
fix(charging-station): add try/finally guards to lifecycle methods
Prevent zombie state flags when exceptions occur:
- start(): wrap in try/finally to always reset starting=false
- stop(): wrap in try/finally to always reset stopping=false
- reset(): catch stop() failure and abort instead of proceeding
with sleep+start on a half-stopped station
- delete(): catch stop() failure so cleanup always proceeds
Jérôme Benoit [Sun, 15 Mar 2026 20:43:50 +0000 (21:43 +0100)]
chore(ocpp-server): migrate pyproject.toml to PEP 621 project metadata
Move name, version, description, authors, readme from deprecated
[tool.poetry.*] to [project.*] per PEP 621. Move dependencies from
[tool.poetry.dependencies] to [project.dependencies] with PEP 508
specifiers. Set requires-python to >=3.12,<4.0 to match ocpp package
constraint. Regenerate poetry.lock.
Jérôme Benoit [Sun, 15 Mar 2026 20:29:21 +0000 (21:29 +0100)]
fix(tests): remove stale optional chaining on now-required variableAttribute
ReportDataType.variableAttribute was made required in 429cdbe3 but
test files still used ?. and ?? [] on the field. The stale eslint
cache masked these errors locally; CI (no cache) correctly rejected.
Jérôme Benoit [Sun, 15 Mar 2026 20:16:10 +0000 (21:16 +0100)]
fix(ocpp20): implement proper M04.FR.06 guard via isChargingStationCertificateHash
The previous M04.FR.06 guard was ineffective: it called
getInstalledCertificates() which scans root cert directories and
maps types via mapInstallTypeToGetType(), which has no case for
ChargingStationCertificate (stored via CertificateSigned, not
InstallCertificate). The V2GCertificateChain filter never matched.
Add isChargingStationCertificateHash() to OCPP20CertificateManager
that directly scans the ChargingStationCertificate directory and
compares certificate hashes. Use it in handleRequestDeleteCertificate
for a reliable M04.FR.06 guard.
Jérôme Benoit [Sun, 15 Mar 2026 20:04:35 +0000 (21:04 +0100)]
fix(ocpp20): remediate 4 conformance findings from cross-audit
- M04.FR.06: Narrow DeleteCertificate guard to V2GCertificateChain type
only, allowing legitimate deletion of root certificates (CSMSRoot,
ManufacturerRoot, MORootCert, V2GRoot)
- B09.FR.05: Use InvalidConfSlot reasonCode per errata 2025-09 when
configurationSlot is not in NetworkConfigurationPriority list
- B09.FR.04/FR.31: Check AllowSecurityProfileDowngrade variable before
rejecting downgrades — allow 3→2 when true, never allow to profile 1
(errata 2025-09 §2.12)
- L01.FR.06: Wait for active transactions to end before commencing
firmware installation via polling loop in lifecycle simulation
Jérôme Benoit [Sun, 15 Mar 2026 19:22:37 +0000 (20:22 +0100)]
refactor(ocpp16): track diagnosticsStatus and extract composite schedule helper
- Add diagnosticsStatus to ChargingStationInfo, set at each
DiagnosticsStatusNotification send point (Uploading, Uploaded,
UploadFailed). TriggerMessage now reports actual diagnostics status
instead of hardcoded Idle, mirroring the firmwareStatus pattern.
- Extract composeCompositeSchedule() private method, eliminating
~120 lines of duplicated profile preparation logic between the
connectorId=0 and connectorId>0 branches of GetCompositeSchedule.
Jérôme Benoit [Sun, 15 Mar 2026 18:53:54 +0000 (19:53 +0100)]
fix(ocpp16): fix StopTransaction unit schema and ChargingSchedule field name
- Add missing 'Celsius' to StopTransaction.json unit enum (M-2/SP-1)
The runtime schema had only 'Celcius' (legacy typo) while the OCA
official schema has both. TS enum produces 'Celsius' which was
rejected by AJV when ocppStrictCompliance was enabled.
- Rename minChargeRate to minChargingRate in OCPP16ChargingSchedule (RST-01)
Field name typo caused JSON serialization mismatch with spec §7.13
and schema 'minChargingRate', breaking SetChargingProfile and
GetCompositeSchedule payloads.
Jérôme Benoit [Sun, 15 Mar 2026 18:23:00 +0000 (19:23 +0100)]
fix(ocpp20): clean up VariableManager mappings cache on station stop
invalidateMappingsCache was never called on station stop, leaking
invalidVariables and validatedStations entries for each stopped station.
Call it alongside resetRuntimeOverrides in stop() for complete cleanup.
Jérôme Benoit [Sun, 15 Mar 2026 18:19:07 +0000 (19:19 +0100)]
fix(ocpp20): isolate VariableManager overrides per station
runtimeOverrides, minSetOverrides, and maxSetOverrides were stored as flat
Maps on the singleton OCPP20VariableManager, causing SetVariables on one
station to affect all others sharing the same service instance.
Apply the same Map<stationId, Map<key, value>> pattern already used by
invalidVariables in the same class. resetRuntimeOverrides now accepts
optional stationId, matching the invalidateMappingsCache API.
Jérôme Benoit [Sun, 15 Mar 2026 18:04:39 +0000 (19:04 +0100)]
refactor(ocpp20): isolate per-station state with WeakMap instead of singleton properties
Per-station state (firmware update tracking, report cache, connector status
backup) was incorrectly stored as flat properties on the singleton
OCPP20IncomingRequestService, causing cross-station pollution when multiple
stations share the same service instance.
Introduce OCPP20PerStationState interface and a WeakMap<ChargingStation, ...>
to properly isolate state per station, matching the stateless service pattern
used by OCPP16IncomingRequestService. State is lazily initialized and
automatically garbage collected when the station is released.
Jérôme Benoit [Sat, 14 Mar 2026 22:46:56 +0000 (23:46 +0100)]
fix(renovate): enable Poetry dependency detection for OCPP2 mock server
Override :ignoreModulesAndTests preset to remove **/tests/** from
ignorePaths, allowing Renovate to discover tests/ocpp-server/pyproject.toml
and manage its Python/Poetry dependencies.
Jérôme Benoit [Sat, 14 Mar 2026 00:15:41 +0000 (01:15 +0100)]
docs: fix root README coherence with codebase
- Add missing NotifyCustomerInformation to OCPP 2.0.x section
- Add undocumented station template fields (iccid, imsi,
meterSerialNumberPrefix, meterType)
- List all available OCPP command procedure names in UI Protocol section
with separate OCPP 1.6 and 2.0.x lists
- Update copyright year to 2026 in README and LICENSE
Jérôme Benoit [Fri, 13 Mar 2026 21:08:30 +0000 (22:08 +0100)]
fix(ocpp-server): share charge_points set across connections and harden test quality
- Fix charge_points set created per-connection instead of shared across
all connections via ServerConfig
- Remove AuthConfig.__getitem__ dict-compat hack and isinstance(dict)
coercion branch from ChargePoint.__init__
- Migrate all test fixtures from raw dicts to AuthConfig instances
- Replace 11 weak 'assert X is not None' with typed assertions
(isinstance, enum equality)
- Hoist Action import to module level in test_server.py
- Add centralized error handling in _send_command dispatch for
TimeoutError, OCPPError, and ConnectionClosed
- Make host/port configurable via --host and --port CLI args
- Make boot notification status configurable via --boot-status
- Make TransactionEvent total cost configurable via --total-cost
- Extract server defaults as module-level constants
- Fix asyncio.iscoroutine() deprecation in timer.py: use
inspect.iscoroutinefunction() + inspect.isawaitable() for Python 3.14+
- Add proper type annotations and docstrings to timer.py
- Add pytest-asyncio for async handler testing (82 tests total)
- Add async tests for all 15 incoming OCPP handlers
- Add error handling tests for command dispatch layer
- Add tests for configurable boot_status and total_cost
- Update README with new server and charging behavior CLI options
Jérôme Benoit [Fri, 13 Mar 2026 18:39:58 +0000 (19:39 +0100)]
feat(ocpp-server): overhaul OCPP 2.0.1 mock server with full command coverage
- Add 4 new @on handlers: Get15118EVCertificate, GetCertificateStatus,
SignCertificate, NotifyCustomerInformation
- Add 9 new outgoing commands: CertificateSigned, CustomerInformation,
DeleteCertificate, GetInstalledCertificateIds, GetLog,
GetTransactionStatus, InstallCertificate, SetNetworkProfile,
UpdateFirmware (20 total)
- Fix camelCase key access bug in authorize/transaction handlers
(ocpp library converts to snake_case)
- Extract _resolve_auth_status() to eliminate duplicated auth logic
- Replace ConnectionError with InternalError for offline simulation
- Use set.discard() instead of set.remove() for safe cleanup
- Add match default case for unknown TransactionEvent types
- Modernize type hints: Optional[X] -> X | None
- Rewrite test suite with pytest (51 tests, 4 test classes)
- Update ruff to ^0.15, add pytest ^8 dev dependency
- Update README with all 20 outgoing commands and 15 incoming handlers
Jérôme Benoit [Fri, 13 Mar 2026 16:29:36 +0000 (17:29 +0100)]
test: remove 24 tautological enum value assertion tests
Remove tests that assert compile-time constant enum values (e.g.
EnumName.MEMBER === 'hardcodedString'), which always pass by definition
and exercise no production code.
- Delete ConfigurationData.test.ts (3 tautological tests)
- Remove ProcedureName/BroadcastChannelProcedureName enum groups (16 tests)
- Remove AuthTypes Enums block (4 tests)
- Remove OutputFormat enum test (1 test)
- Fix assert.strictEqual(true, false) to assert.fail() in OCPPAuthServiceFactory
All quality gates pass. Coverage unchanged (1800 tests, 0 failures).
* feat(broadcast-channel): add OCPP 2.0.1 command handlers and response mapping
- Add 8 new command handlers: get15118EVCertificate, getCertificateStatus,
logStatusNotification, notifyCustomerInformation, notifyReport,
securityEventNotification, signCertificate, transactionEvent
- Update CommandResponse type union with 4 OCPP 2.0.1 response types
- Add 4 commandResponseToResponseStatus cases for non-empty responses
- Fix METER_VALUES handler: add OCPP 2.0.1 passthrough branch (version-detected)
- Fire-and-forget commands handled automatically by isEmpty bailout
* fix(ocpp2): add missing certificate commands to buildRequestPayload
Add SIGN_CERTIFICATE, GET_15118_EV_CERTIFICATE, GET_CERTIFICATE_STATUS
to the passthrough case group — these previously fell to the default
branch which threw OCPPError(NOT_SUPPORTED)
Add 45 tests across 6 groups covering:
- ProcedureName enum: 8 new OCPP 2.0.1 entries
- BroadcastChannelProcedureName enum: 8 new OCPP 2.0.1 entries
- ProcedureNameToBroadCastChannelProcedureNameMapping: 8 new entries
- BroadcastChannelRequestPayload: OCPP 2.0.1 optional fields
- commandResponseToResponseStatus: 4 new command response cases
- commandHandlers Map: 8 new entries registered
* style: fix perfectionist ordering in broadcast channel handler and tests
* [autofix.ci] apply automated fixes
* test(broadcast-channel): add buildRequestPayload and behavioral handler tests
Add Group 7 (buildRequestPayload certificate passthrough) and Group 8
(commandHandlers behavioral) tests addressing audit findings:
- 3 tests verify GET_15118_EV_CERTIFICATE, GET_CERTIFICATE_STATUS, and
SIGN_CERTIFICATE payloads pass through unchanged
- 8 tests verify each OCPP 2.0.1 handler invokes requestHandler with the
correct RequestCommand enum value
Total: 56 tests in file, 1816 across suite.
* [autofix.ci] apply automated fixes
* refactor(test): remove redundant test groups from broadcast channel tests
Remove Group 4 (BroadcastChannelRequestPayload tautological - type system
already enforces at compile time) and Group 6 (commandHandlers existence -
fully subsumed by Group 8 behavioral tests that verify both existence and
correct RequestCommand routing).
- Add explicit commandResponseToResponseStatus cases for 4 fire-and-forget
commands (LogStatusNotification, NotifyCustomerInformation, NotifyReport,
SecurityEventNotification) using isEmpty pattern matching existing
MeterValues/StatusNotification behavior
- Tighten BroadcastChannelRequestPayload types: idToken uses
OCPP20IdTokenType, rename transactionData to transactionInfo with
OCPP20TransactionType per OCPP 2.0.1 spec
- Add OCPP20AuthorizationStatusEnumType to barrel export in types/index.ts,
switch deep imports to barrel imports in source and test files
- Add 8 tests for fire-and-forget commandResponseToResponseStatus coverage
- Fix cspell warnings in test mock data strings
* test: improve OCPP 2.0.1 broadcast channel coverage with dispatch and pipeline tests
Add commandHandler dispatch pipeline tests (Group 6) and requestHandler
full pipeline tests (Group 7) to exercise handler closure bodies through
the actual dispatch path. Convert Group 6 from direct Map.get() to
commandHandler() method dispatch for better V8 coverage tracking.
59 tests across 7 groups (was 53 tests across 6 groups).
* refactor(broadcast-channel): extract handler closures to named private methods
Extract 17 async handler closures from the Map constructor into named
private methods with .bind(this) references. This improves V8 coverage
tracking accuracy for arrow function closures inside Map constructor
arrays, where tsx/esbuild source map misalignment causes inconsistent
coverage attribution.
No behavioral changes — all handlers execute the same logic.
* [autofix.ci] apply automated fixes
* test(broadcast-channel): add mapping completeness validation for UI service command pipeline
* [autofix.ci] apply automated fixes
* refactor(types): remove unused OCPP 2.0 fields from BroadcastChannelRequestPayload
Jérôme Benoit [Thu, 12 Mar 2026 23:04:47 +0000 (00:04 +0100)]
test(ocpp): add schema registration coverage tests for OCPP 1.6 and 2.0
Verify every command enum value has its request and response schemas
registered in ServiceUtils, and that all referenced schema files exist
on disk. Prevents regressions where a command is implemented but its
schema registration is forgotten.
Jérôme Benoit [Thu, 12 Mar 2026 22:56:04 +0000 (23:56 +0100)]
fix(ocpp2): add missing outgoing schema entries for certificate commands
Register Get15118EVCertificate, GetCertificateStatus, and SignCertificate
in OCPP20ServiceUtils.outgoingRequestSchemaNames to ensure JSON schema
validation for these certificate management commands.
Jérôme Benoit [Thu, 12 Mar 2026 22:42:20 +0000 (23:42 +0100)]
refactor(ocpp): remove dead parseJsonSchemaFile overrides and standardize validation
- Delete unused parseJsonSchemaFile overrides from OCPP16/20ServiceUtils
(createPayloadValidatorMap already passes version via options)
- Remove orphaned JSONSchemaType and JsonType imports
- Standardize null-validator return to false in OCPPRequestService
(consistent with OCPPIncomingRequestService and OCPPResponseService)
- Change validateRequestPayload and validateIncomingRequestResponsePayload
visibility from private to protected (consistent with other base classes)
Jérôme Benoit [Thu, 12 Mar 2026 22:31:30 +0000 (23:31 +0100)]
refactor(ocpp): harmonize JSON schema payload validation across OCPP stacks
- Absorb missing-validator null guard into base class methods, eliminating
4 identical private validatePayload wrappers and their bind() calls
- Remove dead code (unreachable isValid branches in ResponseService wrappers)
- Make parseJsonSchemaFile throw on failure instead of silently returning {},
preventing validators that accept everything as a security bypass
- Add dual-path schema resolution for production (esbuild) and test (tsx)
- Align OCPP 1.6 schema map construction with OCPP 2.0 registry pattern,
replacing ~200 lines of verbose inline entries with declarative registries
- Collapse 4 identical payload options factory methods into 1 per version
* feat(ocpp2): implement UpdateFirmware and FirmwareStatusNotification
Add UpdateFirmware (CSMS→CS) incoming request handler with simulated
firmware update lifecycle state machine (Downloading → Downloaded →
SignatureVerified → Installing → Installed) and FirmwareStatusNotification
(CS→CSMS) outgoing command.
- Handle UPDATE_FIRMWARE incoming request, return Accepted status
- Simulate firmware update lifecycle via chained setTimeout calls
- Send FirmwareStatusNotification at each state transition
- Check firmware.signature presence for SignatureVerified state
- Add testable interfaces for both handler and request service
- Add 8 tests (5 for UpdateFirmware, 3 for FirmwareStatusNotification)
* feat(ocpp2): implement GetLog and LogStatusNotification
- Add GetLog incoming request handler with simulated upload lifecycle
(Uploading → Uploaded via chained setTimeout)
- Add LogStatusNotification outgoing command in RequestService
- Register handleResponseLogStatusNotification in ResponseService
- Update testable interfaces with new handler and request method
- Add 4 GetLog tests (DiagnosticsLog, SecurityLog, requestId, retries)
- Add 3 LogStatusNotification tests (Uploading, requestId, empty response)
- All quality gates pass: lint, typecheck, build, 1737 tests
* feat(ocpp2): expand TriggerMessage handler with new trigger types
* docs: update README with OCPP 2.0.1 Core certification commands
* style(ocpp2): fix space-before-function-paren in TriggerMessage handler and test
* fix(ocpp2): add missing case branches in buildRequestPayload for new commands
buildRequestPayload throws NOT_SUPPORTED for FirmwareStatusNotification,
LogStatusNotification, MeterValues, NotifyCustomerInformation, and
SecurityEventNotification since they have no case branches. This causes
guaranteed runtime failures when TriggerMessage invokes requestHandler
for these commands.
Add pass-through case branches matching the existing pattern used by
other notification commands.
* fix(ocpp2): use zero-based seqNo in NotifyCustomerInformation per OCPP 2.0.1 spec
* fix(ocpp2): stop only specific transaction in handleResponseTransactionEvent
handleResponseTransactionEvent was stopping ALL active transactions when
any rejected idTokenInfo.status arrived. Per OCPP 2.0.1 spec (D01/D05),
only the specific transaction referenced by the TransactionEvent request
should be stopped.
Extract the transactionId from the request payload and use
getConnectorIdByTransactionId/getEvseIdByTransactionId to find and stop
only the affected transaction.
* fix(ocpp2): set idle EVSEs Inoperative immediately on CS-level ChangeAvailability per G03.FR.04
- Add delay between Downloaded and SignatureVerified in firmware update lifecycle per J01
- Add missing JSDoc for requestLogStatusNotification in testable interface
- Convert 4 arrow function handlers to regular methods for consistency with pre-existing handlers
- Replace duplicated delay() functions with shared sleep() utility
- Extract handleEvseChangeAvailability and handleCsLevelInoperative to
reduce cognitive complexity of handleRequestChangeAvailability
- Extract hasAnyActiveTransaction to eliminate nested loops
- Fix negated conditions and nested template literals
* refactor(ocpp2): deduplicate validator configs via shared schema name maps
- Extract incomingRequestSchemaNames and outgoingRequestSchemaNames as
single source of truth for command-to-schema mappings
- Generate request/response configs from shared maps, eliminating 96
lines of structural duplication flagged by SonarCloud
- Fix remaining negated conditions in ternary expressions
* fix(test): deduplicate MeterValues call, add multi-EVSE isolation test
* fix(ocpp2): eliminate double status notification, document messagesInQueue
* test(ocpp2): align test files with TEST_STYLE_GUIDE conventions
* fix: comply with E14.FR.06 and harmonize statusInfo
Added 26 null guards (if + assert.fail) after getConnectorStatus() and
nullable field accesses to satisfy both TypeScript strict null checks
and ESLint.
* test: migrate all remaining test files from @std/expect to node:assert/strict
Migrate 82 remaining test files (OCPP 2.0, auth, charging-station,
UI server, utils, worker, performance, exception, types) from
@std/expect to node:assert/strict.
Remove @std/expect JSR dependency from package.json to fix CI 404
errors on npm.jsr.io.
All 1694 tests pass, lint clean, TSC clean.
* chore: update lockfile after removing @std/expect dependency
* docs: update test style guide and config to reflect node:assert/strict migration
* test(ocpp16): eliminate as-unknown-as casts and add missing AAA comments
Create typed helpers in OCPP16TestUtils (setMockRequestHandler,
dispatchResponse, createMeterValuesTemplate, createCommandsSupport)
to encapsulate type casts in one place instead of 26 inline casts
across 8 test files.
Add Arrange/Act/Assert comments to 5 tests in
OCPP16ServiceUtils.test.ts that have 3+ logical setup steps.
All 1694 tests pass, lint clean, TSC clean.
* fix(test): use real enum value instead of as-any cast in AuthHelpers.test.ts
Use AuthorizationStatus.NO_CREDIT (unhandled by getStatusMessage
switch) to test the default branch, removing the as-any cast and
eslint-disable comment that caused CI autofix failure.
Jérôme Benoit [Mon, 9 Mar 2026 18:49:48 +0000 (19:49 +0100)]
fix: migrate JSR dependency from legacy npm:@jsr/ to native jsr: protocol
Replace the legacy npm compatibility layer approach with pnpm's native
jsr: protocol support (available since pnpm 10.9.0) to fix 404 errors
when fetching @jsr/std__assert tarballs from npm.jsr.io.
- package.json: use jsr:@std/expect specifier instead of npm:@jsr/std__expect
- package.json, ui/web/package.json: bump engines.pnpm to >=10.9.0
- .npmrc: remove @jsr:registry=https://npm.jsr.io (no longer needed)
- pnpm-lock.yaml: regenerated with native JSR resolution
Jérôme Benoit [Fri, 6 Mar 2026 14:48:07 +0000 (15:48 +0100)]
fix(performance-storage): make MikroORM integration work (#1701)
* fix(performance-storage): make MikroORM integration work
Fix MikroORM performance storage integration by addressing:
- Fork EntityManager per operation (prevents identity map accumulation)
- Pass entity class to em.upsert() (MikroORM v6 API)
- Add schema generation in open() (table creation)
- Fix entity: add tableName, JSON type for statisticsData
- Add connection validation before operations
- Use direct entity class import instead of fragile glob paths
- Ensure SQLite directory exists before ORM init
- Fix type-only import to value import (verbatimModuleSyntax)
- Swap setPerformanceStatistics/checkDBConnection call order to match
MongoDBStorage pattern (in-memory stats updated first so UI stays
current even when DB is down)
- Close ORM connection on schema updateSchema() failure to prevent
resource leak when init succeeds but schema generation fails
* test(performance-storage): add unit tests for MikroOrmStorage
Add 18 tests covering constructor, close, storePerformanceStatistics,
and error handling. Uses mock ORM to avoid sqlite3 native binding
dependency in CI (--ignore-scripts). Explicit decorator types on
PerformanceRecord for tsx/esbuild compatibility.
* refactor(tests): harmonize MikroOrmStorage tests with project conventions
Use TestableMikroOrmStorage subclass with Reflect.get/set (matches
UIHttpServer pattern). Replace toBeGreaterThan with exact toBe counts.
Use .mock.calls.length consistently. Remove constructor tests that
tested implementation details.
* refactor(performance-storage): migrate from @mikro-orm/sqlite to @mikro-orm/better-sqlite
The sqlite3 native bindings used by @mikro-orm/sqlite are broken on
Node v24 (no prebuilt binaries for ABI v137, node-gyp@8.4.1 cannot
compile with Python 3.13). Replace with better-sqlite3 which provides
an identical MikroORM API surface while using a more portable native
binding.
* test(performance-storage): add integration tests for MikroOrmStorage
Add 6 integration tests that exercise real SQLite database operations
(open, persist, upsert, JSON serialization, close/reopen, multi-record).
Tests detect better-sqlite3 availability at module load and skip
gracefully via { skip: SKIP_SQLITE } when the native binding is not
built (e.g. CI with --ignore-scripts).
* fix(performance-storage): use caret version for @mikro-orm/better-sqlite and fix test JSDoc order
Use ^6.6.8 (caret) consistently across all @mikro-orm/* packages to
prevent version skew when updating dependencies. MikroORM requires all
packages be on the same version.
Also move @file JSDoc block before all imports in the test file to
match project conventions.
* refactor(performance-storage): extract ensureDBDirectory into Storage base class and audit fixes
Move duplicated directory creation logic from JsonFileStorage and
MikroOrmStorage into a shared protected method in the abstract Storage
base class. Place the call inside the existing switch case instead of
a separate if block.
Also use ^6.6.8 (caret) consistently for @mikro-orm/better-sqlite and
fix test JSDoc ordering to match project conventions.
* refactor(performance-storage): factorize serialization into base class and fix MongoDBStorage
- Extract serializePerformanceStatistics() into Storage base class (DRY)
- Update MikroOrmStorage to use shared serialization method
- Fix MongoDBStorage: remove unnecessary optional client, use shared
serialization for CircularBuffer, remove eslint-disable comments,
rename connected to opened for lifecycle clarity
- Add 20 unit tests for MongoDBStorage mirroring MikroOrmStorage pattern
- Remove 2 eslint-disable comments in Storage.handleDBStorageError by
using nullish coalescing and proper string typing
- Simplify handleDBStorageError params default spread
- Refactor JsonFileStorage.checkPerformanceRecordsFile to return fd,
eliminating non-null assertion and eslint-disable
- Remove eslint-disable in StorageFactory by casting enum to string
- Fix StorageFactory.getStorage return type: Storage (not | undefined)
- Update None.ts copyright year to 2025 for consistency
* refactor(tests): extract buildTestStatistics into shared StorageTestHelpers
* fix(lint): remove unnecessary optional chain after StorageFactory return type fix
Jérôme Benoit [Thu, 5 Mar 2026 20:55:26 +0000 (21:55 +0100)]
fix(ocpp): remove invalid additionalProperties/additionalItems from OCPP 1.6 and 2.0 JSON schemas
Remove `"additionalProperties": false` from enum/string type definitions
where it is semantically invalid (only applies to objects), and
`"additionalItems": false` where `items` is a single schema (not a tuple),
fixing AJV 8 strict mode errors at runtime.
- F1: increment stats.hits for expired cache entries in get()
- F2: use captured 'now' timestamp in set() LRU update
- F3: two-phase expiration in runCleanup() (transition then delete)
- F4: guard cleanupIntervalSeconds with > 0 (NaN protection)
- F5: forward localAuthListManager to RemoteAuthStrategy
- F6: apply absolute 24h lifetime cap in expired-transition branch
- F7: guard local auth list query with config.localAuthListEnabled
- F8: mask identifier in debug logs (first 8 chars only)
- F9: remove dead isCacheable() method and its tests
* refactor(test): replace inline setTimeout with shared sleep helper
* [autofix.ci] apply automated fixes
* fix(ocpp): replace redundant Promise.resolve returns in async methods
* fix(auth): make AuthCache interface synchronous and remove all Promise wrappers
BREAKING CHANGE: AuthCache interface methods (get, set, remove, clear,
getStats) are now synchronous. OCPPAuthService.clearCache() and
invalidateCache() return void instead of Promise<void>.
- Remove async/Promise wrappers from AuthCache interface and InMemoryAuthCache
- Make OCPPAuthService clearCache/invalidateCache return void
- Update all strategies (Local/Remote) to use sync cache operations
- Remove await from all sync cache calls in source and test files
- Fix mock factories to use sync signatures with /* empty */ bodies
- Widen TTL timing margins in InMemoryAuthCache tests to reduce flakiness
- Fix JSDoc annotations in TestLifecycleHelpers and InMemoryAuthCache
* refactor(auth): eliminate all Promise.resolve() from auth module
Replace Promise.resolve() wrappers with proper sync/async signatures:
- Update AuthStrategy interface: getStats() returns sync Record, initialize() returns sync void
- Update OCPPAuthService interface: getStats() returns sync AuthStats
- Convert strategy getStats()/initialize()/cleanup() implementations to sync
- Convert adapter sync methods (convertToUnifiedIdentifier, convertFromUnifiedIdentifier,
getConfigurationSchema, validateConfiguration) from async to sync
- Update OCPPAuthServiceImpl to match sync interface signatures
- Update OCPPAuthIntegrationTest to match sync interface
- Align all test mocks with exact interface signatures (sync mocks for sync
interfaces, async mocks for async interfaces)
- Remove all eslint-disable require-await comments from test files
* fix(auth): resolve all lint errors for CI compliance
- Reorder union types to satisfy perfectionist/sort-union-types
- Remove @returns JSDoc from void functions (jsdoc/require-returns-check)
- Make OCPP16/20 adapter sync methods non-async (require-await)
- Fix all mock signatures to match interface contracts exactly
- Replace async mock lambdas with new Promise<T> pattern
- Fix no-confusing-void-expression in test assertions
- Sort named imports alphabetically (perfectionist/sort-named-imports)
- Add missing await for floating promise in test (no-floating-promises)
* [autofix.ci] apply automated fixes
* fix(auth): remove eslint-disable added by us, use expect().not.toThrow() pattern
Fix validators, convert static classes to modules,
improve cache configurability, fix test configs,
replace sleep with mock timers, fix Promise leak,
move integration test helper to tests/helpers.
* fix(auth): resolve all 35 JSDoc lint warnings for clean lint gate
* fix(auth): address cross-validated audit findings (C1-C3, M1-M6, minor fixes)
- C1: fix timer leak in performRemoteAuthorization (clearTimeout on success/catch)
- C2: document LocalAuthListManager stub with TODO, mark §3.5.3 guard inactive
- C3: expand factory gate to check all three auth feature flags
- M1: change RemoteAuthStrategy.canHandle to use remoteAuthorization config flag
- M2: add AuthenticationMethod.NONE enum for all-strategies-fail fallback
- M4: add NO_AUTHORIZATION to OCPP20AuthAdapter validTypes
- M3: wire hasExplicitTtl into CacheEntry for CSMS-provided TTL preservation
- M6: filter NoAuthorization/Central identifiers from cache (C02.FR.03, C03.FR.02)
- m3: fix boundRateLimitsMap to evict in loop until within threshold
- m4: stop counting expired entries as cache hits
- m7: clamp TTL to [0, maxAbsoluteLifetime] range
- m8: enforce maxEntries >= 1 in constructor
* refactor(auth): use sleep() utility instead of raw Promise setTimeout
Jérôme Benoit [Tue, 3 Mar 2026 19:51:03 +0000 (20:51 +0100)]
test: add AutomaticTransactionGenerator tests
Add tests for the ATG singleton covering instance lifecycle (create,
delete, same-instance), start/stop state machine with guards, connector
stop behavior, and handleStartTransactionResponse counter updates for
accepted and rejected transactions.
Jérôme Benoit [Tue, 3 Mar 2026 19:50:48 +0000 (20:50 +0100)]
test: add Configuration utility tests
Add tests for the static Configuration class covering section retrieval
with defaults (log, worker, uiServer, performanceStorage), supervision
URL distribution, worker pool detection, and error handling for unknown
configuration sections.
Jérôme Benoit [Tue, 3 Mar 2026 19:50:34 +0000 (20:50 +0100)]
test: add IdTagsCache tests
Add tests for the RFID tag cache singleton covering lazy file loading,
ROUND_ROBIN/RANDOM/CONNECTOR_AFFINITY distribution algorithms,
cache population, and cleanup of cache entries and addressable indexes.
Jérôme Benoit [Tue, 3 Mar 2026 19:50:20 +0000 (20:50 +0100)]
test: add SharedLRUCache tests
Add tests for the LRU cache singleton covering template and configuration
CRUD operations, cacheability validation for configurations with empty
fields, and cache clear behavior.
Jérôme Benoit [Tue, 3 Mar 2026 19:49:46 +0000 (20:49 +0100)]
test(ocpp): add OCPPServiceUtils connector status management tests
Add tests for sendAndSetConnectorStatus and restoreConnectorStatus
functions covering StatusNotification sending, connector status updates,
event emission, and reservation-based status restoration.
Jérôme Benoit [Tue, 3 Mar 2026 18:38:07 +0000 (19:38 +0100)]
test(ocpp): add OCPPServiceUtils pure function tests
Test getMessageTypeString, ajvErrorsToErrorType,
convertDateToISOString, isConnectorIdValid — 19 tests
covering the shared base layer with zero mocking.
Jérôme Benoit [Tue, 3 Mar 2026 18:09:09 +0000 (19:09 +0100)]
fix: quote test glob so /bin/sh delegates to Node
The shell /bin/sh does not support recursive ** globs.
Only 18/65 test files were running. Quoting the
pattern lets Node resolve it, running all 65 files.
* feat(ocpp2): implement TriggerMessage/UnlockConnector handlers and Reset hardening
- Implement TriggerMessage handler (F06): supports BootNotification,
Heartbeat, and StatusNotification triggers with EVSE targeting
- Implement UnlockConnector handler (F05): full spec compliance with
Unlocked, UnlockFailed, OngoingAuthorizedTransaction, UnknownConnector
response statuses
- Add AllowReset variable check and firmware update blocking to Reset handler
- Add 4 missing schema validations for certificate commands
- Add TriggerMessage/UnlockConnector schema validator configs
- Document RFC 6960 DER encoding deviation in computeCertificateHash
* refactor(ocpp2): eliminate unsafe type casts in handlers and VariableManager
- Add private toHandler() helper in OCPP20IncomingRequestService that concentrates
the single 'as unknown as IncomingRequestHandler' cast with documentation comment
- Replace 13 per-binding casts in constructor with this.toHandler() calls
- Remove 15 'as unknown as StandardParametersKey' casts from OCPP20VariableManager —
string is already a member of ConfigurationKeyType, no cast needed
- Remove now-unused import of StandardParametersKey from OCPP20VariableManager
* feat(ocpp2): expose TriggerMessage and UnlockConnector handlers in testable interface
* fix(ocpp2): add AJV strict:false and schema validation unit tests (T21)
- Set strict:false in all three AJV constructors (IncomingRequest, Request,
Response) to allow OCPP 2.0 schemas that use additionalItems without
array items (a draft-07 pattern AJV 8 strict mode rejects at compile time)
- Replace integration-style schema tests (blocked by tsx path resolution)
with direct AJV schema unit tests: load schemas from src/assets directly,
compile with AJV, verify invalid payloads are rejected — 15 tests pass
* fix(ocpp2): correct registry key separator in isComponentValid (T5-bugfix)
The `#validComponentNames` set was built using split('/') but registry keys
use '::' as separator (e.g. 'AlignedDataCtrlr::Available'). This caused the
set to contain full keys like 'AlignedDataCtrlr::Available' instead of just
component names like 'AlignedDataCtrlr', making isComponentValid return false
for all components and causing UnknownComponent responses for all Set/GetVariables.
Also update the EVSE test to assert UnknownVariable (not UnknownComponent) since
EVSE is a valid component in the registry but AuthorizeRemoteStart is not one of
its variables.
* fix(ocpp2): resolve tsc type errors in UUIDv4 cast, override modifier, and mock cast (F1)
* fix(ocpp2): add try/catch to TriggerMessage and UnlockConnector handlers, add integration test
- Add try/catch blocks to handleRequestTriggerMessage and
handleRequestUnlockConnector following the handleRequestReset
golden pattern with structured error responses
- Add 4th integration test: SetVariables on unknown component
returns rejected, GetVariables confirms unknown component
* fix(ocpp2): address PR review findings — remove dead code, consolidate types, fix test mock
- TriggerMessage: reject BootNotification trigger when last boot was
already Accepted per F06.FR.17 (returns Rejected + NotEnabled)
- UnlockConnector: check transaction on the specific target connector
instead of all EVSE connectors per F05.FR.02
- Add 3 new tests covering both spec requirements
- Fix withTimeout timer leak: clear setTimeout when promise resolves first
- readMessageLimits: replace empty catch with logger.debug diagnostic
- handleResponseTransactionEvent: add TODO noting log-only is intentional,
future work should act on idTokenInfo.status and chargingPriority
* style: fix jsdoc warnings in OCPP 2.0 handlers and tests
Add missing @returns tags and @param descriptions to satisfy
jsdoc/require-returns and jsdoc/require-param-description ESLint rules.
Replace empty JSDoc blocks with minimal valid documentation to satisfy
jsdoc/require-jsdoc rule. Achieves 0 lint warnings matching main branch
baseline.
* fix(types): reduce tsc errors to zero and fix all lint warnings
Eliminate all TypeScript compiler errors across src/ and test files by
fixing type mismatches, adding missing type annotations, and correcting
union type handling. Fix remaining ESLint issues including no-base-to-string
in ChargingProfile id extraction and jsdoc/tag-lines formatting.
* fix(ocpp2): fix AllowReset dead code, evseId===0 routing, and EVSE-scoped connector lookup
- AllowReset check now resolves via OCPP20VariableManager (runtime value) instead of static registry defaultValue
- Reset handler evseId===0 now routes to full station reset instead of EVSE-specific path
- TriggerMessage StatusNotification uses EVSE-scoped connector lookup instead of global getConnectorStatus
* ci: add typecheck step (tsc --noEmit --skipLibCheck) to CI pipeline
esbuild does not surface type errors at build time, so this catches
regressions before build+test. Runs on ubuntu/node-22 alongside lint.
* fix(ocpp2): remove DiagnosticsStatusNotification from MessageTriggerEnumType
This value is OCPP 1.6 only and not part of the OCPP 2.0.1 spec
(absent from TriggerMessageRequest.json schema).
* docs(readme): align OCPP 2.0.x section with spec and actual code
- Fix section letters to match OCPP 2.0.1 spec (A→B, B→C, C→G, etc.)
- Reorder sections to match spec block order (B,C,D,E,F,G,L,M,P)
- Add missing implemented commands: TriggerMessage, UnlockConnector,
Get15118EVCertificate, GetCertificateStatus
- Move GetVariables/SetVariables from Monitoring to B. Provisioning
- Replace stale 'variables not implemented' note with actual support listing
CALLRESULT payloads were not validated against JSON schemas for
CertificateSigned, DeleteCertificate, GetInstalledCertificateIds,
GetVariables, InstallCertificate, Reset, and SetVariables.
All schema files already existed; only the validator map registration
was missing. Aligns OCPP 2.0 with OCPP 1.6 which validates all
incoming request responses (17/17).
Remove ~135 paraphrase/over-comments from OCPP 2.0 source files that
described what the next line obviously does. Keeps spec references
(C11.FR.04, F06.FR.17, OCPP 2.0.1 §2.10), TODO annotations, RFC 6960
deviation notes, eslint-disable directives, and terse comments matching
the existing OCPP 1.6 style. Test @file/@description headers preserved
per test style guide.
* [autofix.ci] apply automated fixes
* fix(ocpp2): correct spec references and harmonize format
- Fix wrong FR code: F03.FR.09 (triggerReason) → F03.FR.04 (meter
values in TransactionEvent Ended)
- Harmonize FR comment format to 'X00.FR.00: description' style
- Harmonize section references to § symbol (was mixed Section/§)
- Harmonize RFC references to 'RFC 6960 §4.1.1' (was missing §)
* fix(ocpp): remove redundant strict:false from AJV instances
keywords: ['javaType'] already declares the custom keyword, making
strict:false unnecessary. Removing it enables AJV strict mode (default
since v7), which will flag any future non-standard schema keywords
instead of silently ignoring them.
* fix(types): make MeterValuesRequest/Response version-agnostic union types
Remove versioned OCPP16MeterValue import and casts from ChargingStation.ts,
following the established pattern of using union types outside the OCPP stack.
* fix(types): remove versioned type imports from Helpers.ts
Add ChargingSchedule union type, replace satisfies with version-agnostic
BootNotificationRequest, and rename getOCPP16ChargingSchedule to
getSingleChargingSchedule with union return type.
Jérôme Benoit [Mon, 2 Mar 2026 14:36:12 +0000 (15:36 +0100)]
refactor(test): audit-driven test quality improvements
- Add edge case tests for BaseError, OCPPError, ElectricUtils, AsyncLock, StatisticUtils
- Replace real timers with withMockTimers in UIServerSecurity rate limiter tests
- Add 'Date' to MockableTimerAPI type for Date.now() mocking support
- Factor duplicated OCPP 2.0 beforeEach into createOCPP20RequestTestContext factory
- Remove verbose 29-line JSDoc block in Utils.test.ts
repositories / e-mobility-charging-stations-simulator.git / log
