- Replace 71 improper assert.ok(comparison) with assert.strictEqual/notStrictEqual
in 10 test files per TEST_STYLE_GUIDE (assert.ok for boolean/existence only)
- Rename lastUpdated → lastUpdatedDate in auth interfaces and strategies
to follow Date suffix naming convention
- Extract hardcoded 'ws://localhost' to OCPP20Constants.DEFAULT_CONNECTION_URL
- Replace setTimeout(resolve, 50) with proper httpServer.close() await
in UIMCPServer integration test
Jérôme Benoit [Tue, 24 Mar 2026 11:47:53 +0000 (12:47 +0100)]
fix(webui): remove deprecated baseUrl for TypeScript 6 compatibility
TS6 deprecated baseUrl (TS5101). Since paths entries already use './'
prefix, they work standalone without baseUrl. Vite resolve.alias handles
runtime resolution independently.
Jérôme Benoit [Tue, 24 Mar 2026 11:07:03 +0000 (12:07 +0100)]
refactor(ocpp-server): harmonize shutdown tests with project conventions
Move fixture near other fixtures, replace _patch_main tuple return with
contextmanager, parametrize SIGINT/SIGTERM, remove dead code helpers,
merge two test classes into one.
Jérôme Benoit [Tue, 24 Mar 2026 10:44:28 +0000 (11:44 +0100)]
feat(ocpp-server): add graceful shutdown with signal handling
Handle SIGINT/SIGTERM for clean WebSocket close (code 1001) to all
connected charge points. Includes shutdown drain timeout, double-signal
force quit, and cross-platform Windows fallback via call_soon_threadsafe.
Verify that every broadcast channel OCPP command has a corresponding
MCP tool schema and OCPP schema mapping entry. Ensures schema coverage
stays in sync with supported commands as a single source of truth guard.
Jérôme Benoit [Tue, 24 Mar 2026 00:43:04 +0000 (01:43 +0100)]
refactor(broadcast-channel): extract response status registries from switch/case
Replace 11 repetitive switch/case blocks in commandResponseToResponseStatus
with two static registries:
- emptyResponseCommands: Set of commands where empty response = success
- acceptedStatusCommands: Map of commands to status check predicates
Custom cases (AUTHORIZE, START/STOP_TRANSACTION, HEARTBEAT,
TRANSACTION_EVENT) remain in switch for version-specific logic.
Adding a new command now requires 1 line in the registry instead of
a 5-line case block.
Replace 20 identical BroadcastChannel handler methods (handleAuthorize,
handleDataTransfer, handleHeartbeat, handleStatusNotification, etc.)
with a single passthrough(RequestCommand) factory method that creates
a CommandHandler forwarding the request payload to requestHandler.
Retain only handlers with custom logic: handleBootNotification (merges
bootNotificationRequest), handleMeterValues (version-specific meter
value building), handleStopTransaction (adds meterStop).
Jérôme Benoit [Tue, 24 Mar 2026 00:16:06 +0000 (01:16 +0100)]
refactor(ocpp): extract buildEmptyMeterValue helper for empty MeterValue construction
Replace 4 inline { sampledValue: [], timestamp: new Date() } constructions
with buildEmptyMeterValue() helper in OCPPServiceUtils and OCPP16ServiceUtils.
* docs: restructure MCP section for agent config, update uiServer type in config table
* feat(ui-server): log deprecation warning when HTTP transport is used
* fix(ui-server): harmonize log levels and message patterns with existing transports
* test(ui-server): align MCP tests with style guide
- Use createLoggerMocks() for log assertions instead of trivial checks
- Add server.stop() to factory fallback tests to prevent resource leaks
- Replace fragile globalThis.clearTimeout override with t.mock.method
* docs: restore PDU acronym definition in WebSocket Protocol section
* fix(ui-server): use UI protocol version for MCP server version
* fix(ui-server): derive log file paths from Configuration instead of hardcoding
* perf(ui-server): tail-read log files instead of loading entire file into memory
* refactor(ui-server): convert log resources to tools with tail parameter
Follow MCP best practices: resources are for static snapshots,
tools are for parameterized on-demand data.
- Replace log://combined and log://error resources with
readCombinedLog and readErrorLog tools
- Add tail parameter (default 200, max 5000) following the
filesystem server head/tail pattern
- Add readOnlyHint annotation per MCP tool spec
- Return totalLines metadata in response for context
- Keep station and template resources (small, static data)
* feat(ui-server): expose OCPP JSON schemas as MCP resource templates
Add schema://ocpp/{version} listing and schema://ocpp/{version}/{command}
resource templates that serve the existing JSON schema files from
src/assets/json-schemas/ocpp/ on demand.
LLM agents can discover available OCPP commands per version and read
the full JSON schema for any command without bloating tools/list.
Schemas are read from disk on demand — no memory duplication with
the AJV validators already loaded by OCPP services.
- Add ocppSchemaMapping linking ProcedureName to JSON Schema files
- 16 OCPP tools now have ocpp16Payload/ocpp20Payload fields with
version affinity in descriptions
- Intercept tools/list to inject full JSON Schemas from disk
into inputSchema.properties (no Zod duplication, DRY)
- Add payload flattening: extract versioned payload, spread flat
- Add mutual exclusivity: reject if both payloads provided
- Add pre-flight version check: clear error on version mismatch
- Runtime guard: graceful fallback if SDK internal API changes
* refactor(ui-server): use OCPPVersion enum instead of string literals
* refactor(ui-server): improve MCP code elegance and project rule compliance
- Replace as-unknown-as cast with Reflect.get() for SDK handler access
- Replace generic Error with BaseError in stop/readRequestBody
- Extract createToolErrorResponse/createToolResponse static helpers (DRY)
- Extract closeTransportSafely for duplicate transport cleanup
- Extract registerLogReadTool factory for duplicate log tools (DRY)
- Remove unnecessary String() conversions in resource handlers
* fix(ui-server): fix body size double-counting and schema resource path
- readRequestBody: pass chunk.length (not accumulated total) to
createBodySizeLimiter — matches UIHttpServer pattern
- getSchemaBaseDir: use correct relative path instead of broken
resolve().includes('assets') condition (always true)
* refactor(ui-server): consolidate version fallback guards and clarify README version docs
* fix(ui-server): harden MCP schema resources against path traversal and fix transport leak
- Add path traversal guard in schema resource handlers to validate resolved
paths stay within the OCPP schema base directory
- Close MCP transport on 405 Method Not Allowed responses to prevent leak
- Fix log file path to use direct path when rotation is disabled
- Fix misleading Heartbeat tool description that referenced unsupported
ocpp payload fields
* fix(ui-server): address remaining review findings and lint warnings
- Reorder stop() to delete-before-reject preventing re-entrant issues
- Use ephemeral port in integration test instead of fixed port 18999
- Document synchronous authenticate() assumption and SDK pattern deviation
- Add 'modelcontextprotocol' to cspell wordlist
- Convert JSDoc to inline comment to fix jsdoc lint warnings
- Use exact pathname match (url.pathname !== '/mcp') instead of
startsWith to prevent unintended paths from reaching the MCP handler
- Pin @modelcontextprotocol/sdk to ~1.27.1 (patch-only) since the
OCPP schema injection relies on SDK internals pinned to 1.27.x
- Add startup log confirming successful OCPP JSON schema injection
* test(ui-server): add comprehensive UIMCPServer unit tests
Cover private method logic missing from initial test suite:
- invokeProcedure: service null, dual payload, version mismatch,
direct response, service error, 30s timeout (mock timers)
- checkVersionCompatibility: OCPP 1.6/2.0/2.0.1 matching, cross-version
errors, hashIds filtering, all-stations fallback
- readRequestBody: valid JSON, payload too large, invalid JSON, stream error
- loadOcppSchemas: disk loading, cache entry validation
Refactor for elegance and guide compliance:
- Centralize Reflect.get wrappers in TestableUIMCPServer class
- Extract assertToolError() helper to eliminate repeated triplet
- Move createMockChargingStationDataWithVersion() to UIServerTestUtils
- Replace magic number with DEFAULT_MAX_PAYLOAD_SIZE import
* fix(ui-server): per-request McpServer factory, async iterator body reader, transport leak
- Create a new McpServer per HTTP request via createMcpServer() factory
to fix concurrency bug: McpServer.connect() overwrites a single
internal _transport field, causing cross-talk under concurrent requests.
OCPP schema cache and UI service are pre-loaded at startup; tool
registration is ~12µs per request (negligible).
- Replace event-listener readRequestBody with for-await-of async
iterator pattern. Single settlement guaranteed by language semantics,
eliminating the double-reject bug on payload-too-large.
- Close transport on mcpServer.connect() failure to prevent resource leak.
- Clean up both transport and McpServer on response close via unified
cleanup callback.
* fix: align StatusNotification field name with OCPP 2.0.1 schema, fix asset paths
- Use 'connectorStatus' (OCPP 2.0.1 schema field name) instead of
'status' (non-standard) in OCPP20RequestService.buildRequestPayload
and both call sites in OCPP20IncomingRequestService
- Fix esbuild-relative asset paths for OCPP JSON schemas and MCP
resource handlers — import.meta.url resolves to dist/start.js,
not the original source tree depth
* refactor(ocpp): align payload builders to object-param API, fix StatusNotification field names
- Refactor buildStatusNotificationRequest from positional params to
object-based StatusNotificationRequest input. Builder accepts both
'status' (internal/OCPP 1.6) and 'connectorStatus' (OCPP 2.0.1)
with consistent fallback order (connectorStatus ?? status).
- Refactor buildTransactionEvent from 3 overloads to single
object-based OCPP20TransactionEventRequest input, removing
positional param complexity and non-null assertions.
- Refactor sendAndSetConnectorStatus from positional params to
object-based StatusNotificationRequest input. Callers pass
version-correct field names: 'status' in OCPP 1.6 code,
'connectorStatus' in OCPP 2.0 code, either in common code.
- Extract getSchemaBaseDir() as protected method on UIMCPServer
for test overridability, replacing fragile symlink hack.
- Migrate all call sites (28 sendAndSetConnectorStatus, 60+
buildTransactionEvent) and their corresponding tests.
* build: externalize @modelcontextprotocol/sdk and zod from esbuild bundle
Add @modelcontextprotocol/* and zod to esbuild external list for
consistency with all other production dependencies (ajv, ws, winston,
etc.) which are already externalized. Reduces bundle size and avoids
bundling the SDK's transitive dependency tree.
- Add localeCompare to schema file sort in MCPResourceHandlers to
ensure locale-aware alphabetical ordering (SonarCloud bug)
- Extract sendErrorResponse helper from handleMcpRequest to reduce
cognitive complexity from 16 to below threshold (SonarCloud smell)
* chore: update .serena/project.yml with new default config fields
* refactor(ocpp): buildMeterValue resolves connectorId/evseId from transactionId
- Refactor buildMeterValue signature from (station, connectorId,
transactionId, interval) to (station, transactionId, interval).
connectorId and evseId are resolved internally from the unique
transactionId via getConnectorIdByTransactionId/getEvseIdByTransactionId.
- Refactor getSampledValueTemplate to accept optional evseId. When
provided, EVSE-level MeterValues templates take priority; falls back
to merging connector-level templates from all EVSE connectors.
- Add MeterValues field to EvseStatus and EvseTemplate types to support
EVSE-level meter value template definitions.
- Refactor handleMeterValues in BroadcastChannel from if/else to
switch/case on OCPP version with explicit default error.
- Simplify OCPP20IncomingRequestService fallback MeterValues (no
transaction = static empty meter value, skip buildMeterValue).
- Add buildMeterValue unit tests covering OCPP 1.6/2.0 resolution,
unknown transactionId throw, EVSE-level template priority, and
connector template merge fallback.
- Add TEST_TRANSACTION_ID_STRING constant for OCPP 2.0 tests, fix
BroadcastChannel test to use string transactionId for OCPP 2.0.1.
- Fix commandResponseToResponseStatus for Authorize: use switch/case
on OCPP version. OCPP 1.6 checks idTagInfo.status, OCPP 2.0 checks
idTokenInfo.status. Previously only checked idTagInfo (1.6 field),
causing MCP to report 'failure' for successful OCPP 2.0 authorizations.
- Make AuthorizeResponse and AuthorizeRequest cross-version union types
(OCPP16 | OCPP20) consistent with AuthorizationStatus pattern.
- Make isIdTagRemoteAuthorized version-aware: sends idTag for OCPP 1.6,
idToken for OCPP 2.0, and checks the version-correct response field.
- Use version-specific casts (OCPP16AuthorizeResponse,
OCPP20AuthorizeResponse) in version-switched code paths instead of
agnostic union type.
* refactor(ocpp): harmonize version switch/case in auth functions
- Refactor isIdTagAuthorizedUnified and isIdTagAuthorized from if/else
on OCPP version to switch/case with explicit VERSION_16, VERSION_20/201
cases and separate default fallback.
- Remove unnecessary optional chaining on stationInfo inside
version-switched cases where stationInfo is guaranteed non-null.
- Separate VERSION_16 from default in all auth switch/case blocks
for spec-compliant version handling.
* fix(ocpp): buildMeterValue from transactionId, log date locale fix, MeterValues EVSE templates
- Refactor buildMeterValue to resolve connectorId/evseId from
transactionId internally. Returns empty MeterValue when transactionId
is undefined (MCP pass-through with provided meterValue).
- Fix log file date resolution: use local date instead of UTC to match
Winston DailyRotateFile naming convention.
- Add optional date parameter to readCombinedLog/readErrorLog MCP tools
for accessing rotated log files by date (YYYY-MM-DD).
- Add MeterValues field to EvseStatus/EvseTemplate types for EVSE-level
meter value template definitions. getSampledValueTemplate checks
EVSE-level templates first, falls back to merging connector templates.
- Refactor handleMeterValues to switch/case on OCPP version with
explicit default error.
- Make AuthorizeRequest/AuthorizeResponse cross-version union types.
Fix commandResponseToResponseStatus and isIdTagRemoteAuthorized with
version-aware switch/case for OCPP 1.6 (idTagInfo) vs 2.0 (idTokenInfo).
- Add integration tests for readCombinedLog tool (default date, explicit
date, missing file error). Add buildMeterValue unit tests.
Jérôme Benoit [Sun, 22 Mar 2026 18:26:00 +0000 (19:26 +0100)]
fix(ocpp2): implement StopTxOnInvalidId and MaxEnergyOnInvalidId per E05 (#1745)
* fix(ocpp2): implement StopTxOnInvalidId and MaxEnergyOnInvalidId per E05
Implement the full deauthorization decision tree per OCPP 2.0.1 spec:
- StopTxOnInvalidId=false: transaction continues, no termination
- StopTxOnInvalidId=true + MaxEnergyOnInvalidId>0: defer termination
until energy limit reached (checked in periodic meter values callback)
- StopTxOnInvalidId=true + MaxEnergyOnInvalidId=0: immediate suspension
and termination
Also includes:
- Deduplicate transactionSetInterval/transactionTxUpdatedSetInterval
into single transactionMeterValuesSetInterval field
- Add transactionDeauthorized/transactionDeauthorizedEnergyWh to
ConnectorStatus for deauth state tracking (cleared in resetConnectorStatus)
- Extract readVariableValue/readVariableAsBoolean/readVariableAsInteger
helpers using convertToInt and convertToBoolean utilities
- Fix buildEvsesStatus test that was missing evse-to-connector wiring
* refactor(ocpp2): address PR review comments
- Add logger.warn in readVariableAsInteger catch for diagnostic
- Replace unsafe 'as string' cast with .toString() in periodic callback
- Add tests for StopTxOnInvalidId=false and deauth state tracking
* chore: update webui.png
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* test: add resetConnectorStatus unit tests to Helpers.test.ts
Verify all 18 transaction fields are properly cleaned, TX_PROFILE
charging profiles matching the transaction are removed, and
non-transaction fields are preserved.
Jérôme Benoit [Sun, 22 Mar 2026 15:36:32 +0000 (16:36 +0100)]
fix(ocpp2): align MeterValues implementation with OCPP 2.0.1 spec (#1744)
* fix(ocpp2): use AlignedDataInterval for standalone MeterValues
Add getAlignedDataInterval() helper to OCPP20ServiceUtils that reads
AlignedDataCtrlr.Interval from the variable registry (default 900s).
Replace getTxUpdatedInterval() with getAlignedDataInterval() in the
broadcast channel handleMeterValues OCPP 2.0 branch. Standalone
MeterValuesRequest is non-transaction data per OCPP 2.0.1 spec and
should use the aligned data interval, not the tx-updated interval.
* fix(ocpp2): include meter value in TransactionEvent Started
Add buildTransactionBeginMeterValues() to OCPP20ServiceUtils following
the buildFinalMeterValues() pattern. Builds an OCPP20MeterValue with
Transaction.Begin context and Energy.Active.Import.Register measurand.
Wire it into both TransactionEvent(Started) call sites:
- OCPPServiceUtils.startTransactionOnConnector (ATG/broadcast channel)
- OCPP20IncomingRequestService RequestStartTransaction event listener
This aligns OCPP 2.0 with the OCPP 1.6 beginEndMeterValues behavior
per OCPP 2.0.1 spec SampledDataTxStartedMeasurands requirement.
* test(ocpp2): add tests for buildTransactionBeginMeterValues
Test Transaction.Begin context, energy register value, default to 0
when undefined, and empty array when energy is negative.
* refactor(ocpp2): address PR review comments
- Extract buildEnergyMeterValues private helper to eliminate DRY
violation between buildTransactionBeginMeterValues and
buildFinalMeterValues
- Add AlignedDataInterval to OCPP20RequiredVariableName enum replacing
raw string literal in getAlignedDataInterval
- Clarify zero-energy test name to document that 0 Wh is a valid
Transaction.Begin reading
- Add meterValue assertions to RequestStartTransaction test verifying
Transaction.Begin context and Energy.Active.Import.Register measurand
* refactor(ocpp2): extract readVariableAsIntervalMs to eliminate DRY
getAlignedDataInterval and getTxUpdatedInterval were structurally
identical. Extract the shared variable-reading logic into a private
readVariableAsIntervalMs helper that accepts component name, variable
name, and default seconds. Both public methods become one-liner
delegates.
* refactor(ocpp2): extract terminateTransaction and resolveActiveTransaction
requestDeauthorizeTransaction and requestStopTransaction shared
identical transaction termination logic (build final meter values,
send TransactionEvent Ended, stop periodic, reset connector status).
Extract resolveActiveTransaction for the shared precondition check
and transactionId string resolution, and terminateTransaction for
the shared Ended event + cleanup workflow. Both public methods now
focus only on their unique behavior.
* fix(test): use enum constants instead of string literals in RequestStartTransaction test
Replace 'Transaction.Begin' and 'Energy.Active.Import.Register' string
literals with OCPP20ReadingContextEnumType.TRANSACTION_BEGIN and
OCPP20MeasurandEnumType.ENERGY_ACTIVE_IMPORT_REGISTER to match
codebase conventions.
* refactor(test): replace string literals with enum constants in OCPP 2.0 tests
Replace hardcoded string literals with their corresponding OCPP 2.0.1
enum values across test files for type safety and consistency:
requestDeauthorizeTransaction mocks returned { status: 'Accepted' }
but OCPP20TransactionEventResponse has no status field. Replace with
properly typed empty response objects since the return value is not
asserted in these tests.
* refactor(ocpp2): align method names with OCPP 2.0.1 spec terminology
The spec uses Started/Updated/Ended for TransactionEvent types, not
Begin/Final.
* refactor(test): replace 'Operative' string literal with enum constants
Use OCPP20OperationalStatusEnumType.Operative in OCPP 2.0 test files
and the cross-version AvailabilityType.Operative in MessageChannelUtils
test to match ConnectorStatus.availability typed field.
Jérôme Benoit [Sun, 22 Mar 2026 11:40:27 +0000 (12:40 +0100)]
fix(ocpp2): build meter values payload in broadcast channel for OCPP 2.0.x
The OCPP 2.0 branch in handleMeterValues was passing the raw broadcast
channel payload through to requestHandler without constructing the
required evseId and meterValue fields. Build the payload using
buildMeterValue and resolve evseId from connectorId, matching the
pattern used by the OCPP 1.6 branch.
Jérôme Benoit [Sat, 21 Mar 2026 20:29:59 +0000 (21:29 +0100)]
refactor(ocpp2): use enum values instead of string literals in variable registry
Replace all string literals that have corresponding TypeScript enums:
- OCPP20OperationalStatusEnumType for AvailabilityState defaultValue/enumeration
- OCPP20ChargingRateUnitEnumType for ChargingScheduleAllowedChargingRateUnit
defaultValue, enumeration, and description
Self-transitions are not allowed per OCPP 2.0.1 spec. The boot
sequence warning needs a different fix (skip StatusNotification
when connector status unchanged).
Jérôme Benoit [Sat, 21 Mar 2026 20:15:55 +0000 (21:15 +0100)]
fix(ocpp2): add AvailabilityState defaults and allow self-transitions
- Add defaultValue using OCPP20OperationalStatusEnumType.Operative
enum for ChargingStation AvailabilityState (was missing, causing
'Missing required configuration key mapping' error at auth time)
- Replace string literals with OCPP20OperationalStatusEnumType enum
values in AvailabilityState enumeration arrays
- Allow Available→Available self-transitions in OCPP20Constants for
both ChargingStation and Connector status tables (required by
boot sequence StatusNotification per spec Part 2 §4.1 step 5)
Jérôme Benoit [Sat, 21 Mar 2026 19:26:19 +0000 (20:26 +0100)]
fix(lifecycle): clear auth service on template reload and station reset
Auth service instance was persisting across template reloads and
station resets, causing stale adapters if OCPP version changed.
- Add OCPPAuthServiceFactory.clearInstance() before initialize()
in template file change handler
- Add OCPPAuthServiceFactory.clearInstance() before initialize()
in reset() method
Jérôme Benoit [Sat, 21 Mar 2026 19:11:34 +0000 (20:11 +0100)]
test(auth): fix OCPP spec references and remove duplicated tests
Replace incorrect G03/G04 (Change Availability) prefixes with correct
OCPP 2.0.1 Authorization section codes (C10/C11/C12/C13/C15).
Remove spec prefixes from internal tests with no direct spec mapping.
- C10.FR.01: cache all statuses (was G03.FR.01.T4)
- C10.FR.07: eviction mechanism (was G03.FR.01.T5)
- C10.FR.08: TTL/expiry behavior (was G03.FR.01.T6/T7)
- C11: cache invalidation (was G03.FR.01.004)
- C12: cache miss behavior (was G03.FR.01.002)
- C13.FR.01: local auth list priority (was G03.FR.01.T8)
- C15: offline authorization (was G03.FR.02)
- Remove 5 duplicated cache unit tests from integration suite
- Update TEST_STYLE_GUIDE.md examples
Jérôme Benoit [Sat, 21 Mar 2026 18:41:46 +0000 (19:41 +0100)]
test(auth): strengthen assertion quality and edge case coverage
- G03.FR.01 cache tests now verify status and TTL, not just cache key
- Add stats increment verification after success and failure auth
- Add cache error resilience test (cache.set throws)
- Add idTag boundary tests for exactly 19, 20, 21 characters
- Rename misleading 'concurrent operations' test to 'sequential batch'
Jérôme Benoit [Sat, 21 Mar 2026 18:29:50 +0000 (19:29 +0100)]
refactor(auth): remove ocppVersion from UnifiedIdentifier
Version info is now sourced from adapter.ocppVersion since each
station has a single adapter. Eliminates redundant version stamping
on every identifier.
- Remove ocppVersion field from UnifiedIdentifier interface
- CertificateAuthStrategy uses this.adapter.ocppVersion
- Adapters no longer stamp version on created identifiers
- Fix CertificateAuthStrategy OCPP 1.6 test to use 1.6 adapter
instead of relying on missing certificateHashData
Jérôme Benoit [Sat, 21 Mar 2026 18:01:48 +0000 (19:01 +0100)]
refactor(auth): replace adapter Map with single adapter per station
Each charging station has exactly one OCPP version, making the
Map<OCPPVersion, OCPPAuthAdapter> unnecessary indirection. Simplify
to a single adapter field across the auth module.
- AuthComponentFactory: createAdapter() returns single OCPPAuthAdapter
- RemoteAuthStrategy: setAdapter()/clearAdapter() replace map ops
- CertificateAuthStrategy: readonly adapter field, no map
- OCPPAuthServiceImpl: single adapter, initializeAdapter() singular
- Tests updated to match new single-adapter API
Jérôme Benoit [Sat, 21 Mar 2026 17:39:09 +0000 (18:39 +0100)]
fix(auth): address audit findings in OCPP auth abstraction layer
- Read AuthCtrlr.LocalAuthorizeOffline variable instead of hardcoding true
- Delegate testConnectivity() to actual adapter availability checks
- Remove duplicate mapOCPP20AuthStatus(), use canonical mapOCPP20AuthorizationStatus
- Map strategies by name instead of fragile priority numbers
- Make connectorId truly optional in OCPP20AuthAdapter.authorizeRemote()
- Use ES2022 Error cause chain in AuthenticationError
Jérôme Benoit [Sat, 21 Mar 2026 17:03:40 +0000 (18:03 +0100)]
fix(webui): use table-layout fixed so table shrinks with container when action panel opens
Replace min-width: 1280px + table-layout: auto with table-layout: fixed.
Auto layout ignores width: 100% and expands based on content, causing
the table to overflow behind the action panel. Fixed layout respects
the container width and distributes columns equally. Add overflow:
hidden on charging-stations-container as belt-and-suspenders clip.
Jérôme Benoit [Sat, 21 Mar 2026 16:56:43 +0000 (17:56 +0100)]
fix(webui): remove white-space nowrap on buttons to prevent table overflow
The nowrap prevented button text from wrapping in narrow table columns,
causing the table to overflow its container when the action panel was
open. Buttons in the toolbar still fit without wrapping due to flex
sizing.
Jérôme Benoit [Sat, 21 Mar 2026 16:23:56 +0000 (17:23 +0100)]
fix(webui): prevent action panel flex grow and allow table container to shrink
Use ID selector on #action-container for higher specificity (1-1-0)
over Container.vue scoped .container (0-2-0), add flex: none to prevent
growing. Add min-width: 0 and remove width: 100% on charging stations
container to allow flex shrink below table content width.
Jérôme Benoit [Sat, 21 Mar 2026 15:46:55 +0000 (16:46 +0100)]
refactor(webui): css quality overhaul with scoped styles, class selectors, design tokens
- add scoped to all 12 Vue component style blocks
- move body/app global styles to index.html
- replace all 33 ID CSS selectors with class selectors
- add :deep() for parent-child table style propagation
- add spacing scale and typography tokens to all themes
- replace magic number percentages with spacing variables
- add :focus-visible styles for buttons and select
- replace hardcoded form widths with max-width constraints
- use gap for flex toolbar spacing
- remove dead CSS
Replace emptyResponseHandler with proper logging handlers for
Get15118EVCertificate, GetCertificateStatus, and SignCertificate
responses. Add handler registration coverage tests for both OCPP 1.6
and 2.0: every RequestCommand must have a response handler, every
IncomingRequestCommand must have an incoming request handler.
OCPP20AuthAdapter.authorizeRemote() was incorrectly sending a
TransactionEvent(Started) as a proxy for authorization, causing a
duplicate Started event when ATG subsequently called
startTransactionOnConnector(). Implement the proper OCPP 2.0.1
Authorize request/response flow, harmonizing the auth+start sequence
with OCPP 1.6: Authorize first, then TransactionEvent(Started).
Jérôme Benoit [Fri, 20 Mar 2026 19:10:38 +0000 (20:10 +0100)]
fix(ocpp2.0): guard BroadcastChannel MeterValues for both VERSION_20 and VERSION_201
The early return in handleMeterValues only checked VERSION_201, missing
VERSION_20. A station configured with ocppVersion '2.0' would fall
through to the OCPP 1.6 path and call convertToInt on a UUID string.
Jérôme Benoit [Fri, 20 Mar 2026 19:05:22 +0000 (20:05 +0100)]
fix(ocpp2.0): pass real transactionId to buildMeterValue for energy accumulation
buildMeterValue was called with transactionId=0 for OCPP 2.0 stations,
but transaction IDs are UUID strings in 2.0.1. The energy lookup
compared 'uuid-string' === 0, always returning 0 Wh. Pass the actual
connectorStatus.transactionId and widen the parameter type to
number | string | undefined.
Jérôme Benoit [Fri, 20 Mar 2026 19:00:23 +0000 (20:00 +0100)]
refactor(webui): restore native table layout to fix column overlap on action panel open
Replace display:flex overrides on <table>/<tr>/<td> with native HTML table
layout. Add overflow-x:auto wrapper with min-width floor so columns scroll
horizontally instead of compressing and overlapping when the action panel
reduces available width.
Jérôme Benoit [Fri, 20 Mar 2026 18:49:23 +0000 (19:49 +0100)]
fix(auth): log actual station OCPP version in RemoteAuthStrategy
Deduplicate adapter validation in initialize() to avoid logging the
same adapter twice for VERSION_20/VERSION_201 aliases. Add ocppVersion
to AuthConfiguration so strategies log the station's configured version
instead of internal map keys.
Jérôme Benoit [Fri, 20 Mar 2026 18:23:38 +0000 (19:23 +0100)]
fix(ocpp2.0): align VARIABLE_REGISTRY spec conformance and log severity
Distinguish required vs optional variables per OCPP 2.0.1 spec
(dm_components_vars.csv). Missing required variables log as error,
missing optional ones as warning. Tag 58 spec-required entries with
required: true and 6 non-spec entries with vendorSpecific: true.
Jérôme Benoit [Fri, 20 Mar 2026 17:07:17 +0000 (18:07 +0100)]
refactor: build version-agnostic OCPP transaction primitives in service layer (#1741)
* refactor: add StopTransactionResult type and OCPP 2.0 reason mapping
* refactor: extract OCPP 1.6 stopTransactionOnConnector to OCPP16ServiceUtils
* refactor: add unified stopTransactionOnConnector and stopRunningTransactions to OCPPServiceUtils
Add two version-dispatching functions to OCPPServiceUtils:
- stopTransactionOnConnector: dispatches to OCPP16ServiceUtils or
OCPP20ServiceUtils via dynamic import, returns StopTransactionResult
- stopRunningTransactions: sequential for OCPP 1.6, parallel (Promise.all)
for OCPP 2.0, includes transactionPending check for OCPP 2.0
Both use dynamic imports to avoid circular dependencies. stopRunningTransactions
is exposed as OCPPServiceUtils.stopRunningTransactions class member.
stopTransactionOnConnector is exported as standalone function only (class member
omitted due to OCPP16ServiceUtils override type conflict).
Includes 6 tests covering both OCPP versions and error cases.
* refactor: simplify ChargingStation and ATG to use OCPPServiceUtils unified methods
- ChargingStation.stopRunningTransactions: delegate to standalone function from OCPPServiceUtils
- Remove ChargingStation.stopRunningTransactionsOCPP20 private method (logic now in standalone function)
- Remove OCPP20ReasonEnumType import from ChargingStation (no longer needed)
- AutomaticTransactionGenerator.stopTransaction: call stopTransactionOnConnector standalone function
- Update ATG return type to Promise<StopTransactionResult | undefined>
- Use result.accepted instead of stopResponse.idTagInfo?.status === AuthorizationStatus.ACCEPTED
- Remove TODO comment from ATG.stopTransaction
* refactor: remove stopTransactionOnConnector from ChargingStation public API
* refactor: remove stopTransactionOnConnector from ChargingStation public API
- Remove ChargingStation.stopTransactionOnConnector public method
- Remove unused StopTransactionRequest, StopTransactionResponse, buildTransactionEndMeterValue, OCPP16ServiceUtils imports from ChargingStation
- Update OCPP16IncomingRequestService.handleRequestUnlockConnector to call OCPP16ServiceUtils.stopTransactionOnConnector directly
- Update test mocks in RemoteStopUnlock tests to target OCPP16ServiceUtils
- Fix OCPPServiceUtils-StopTransaction test: use args-based pattern for command detection, add proper JSDoc, fix type issues
* refactor(ocpp2.0): deduplicate stop pattern via stopAllTransactions
- Add OCPP20ServiceUtils.stopAllTransactions() — single factored function for parallel
EVSE iteration + requestStopTransaction, supports optional evseId for single-EVSE scope
- terminateAllTransactions delegates to stopAllTransactions(station, ResetCommand, reason)
- terminateEvseTransactions delegates to stopAllTransactions(station, ResetCommand, reason, evseId)
- stopRunningTransactions OCPP 2.0 path delegates to stopAllTransactions(station, trigger, stopped)
- Eliminates 3x duplicated iteration+parallel-stop pattern
* refactor: add startTransactionOnConnector and flushQueuedTransactionMessages abstractions
- Add startTransactionOnConnector to OCPPServiceUtils (version dispatch via dynamic imports)
OCPP 1.6: sends START_TRANSACTION via new OCPP16ServiceUtils.startTransactionOnConnector
OCPP 2.0: sends TransactionEvent(Started) via OCPP20ServiceUtils.sendTransactionEvent
Returns StartTransactionResult { accepted: boolean }
- Add flushQueuedTransactionMessages to OCPPServiceUtils (OCPP 1.6: no-op, OCPP 2.0: flushes queue)
- Migrate ATG startTransaction to use startTransactionOnConnector (fixes OCPP 2.0 ATG start)
- Migrate ATG handleStartTransactionResponse to handleStartTransactionResult (uses unified type)
- Remove ATG dependency on AuthorizationStatus, RequestCommand, StartTransactionRequest/Response
- Remove ChargingStation.flushQueuedTransactionEvents private method
- Remove version check in ChargingStation boot handler (line 2304)
- Add StartTransactionResult type to types barrel
* refactor: extract periodic meter values to OCPP service layer
- Add OCPP16ServiceUtils.startPeriodicMeterValues/stopPeriodicMeterValues
- Add OCPP20ServiceUtils.startPeriodicMeterValues/stopPeriodicMeterValues
- Add OCPPServiceUtils.startPeriodicMeterValues/stopPeriodicMeterValues (version dispatch)
- Remove startMeterValues, stopMeterValues, startTxUpdatedInterval, stopTxUpdatedInterval,
restartMeterValues from ChargingStation.ts
- Migrate all callers to use versioned ServiceUtils methods
- Fix test referencing removed startTxUpdatedInterval method
- ChargingStation.ts: -130 lines of version-specific meter values logic removed
* fix: update tests for renamed APIs and removed ChargingStation methods
- AutomaticTransactionGenerator.test.ts: handleStartTransactionResponse -> handleStartTransactionResult, use StartTransactionResult { accepted } instead of StartTransactionResponse
- ChargingStation-Transactions.test.ts: test already uses OCPP16ServiceUtils.stopPeriodicMeterValues
- OCPP20ServiceUtils-TransactionEvent.test.ts: startTxUpdatedInterval -> startPeriodicMeterValues
- StationHelpers.ts: remove stopMeterValues, startMeterValues, startTxUpdatedInterval, stopTxUpdatedInterval, restartMeterValues from mock (no longer on ChargingStation)
- OCPP16ServiceUtils.stopPeriodicMeterValues: add missing delete after clearInterval
* fix: correct startPeriodicMeterValues test to verify no-transaction guard instead of version guard
* fix: guard undefined evseId and avoid throw in shutdown paths
- stopTransactionOnConnector: guard getEvseIdByConnectorId returning undefined, return { accepted: false } with warn log
- stopRunningTransactions: replace throw with warn log in default branch (shutdown path must not crash)
* fix: deduplicate test coverage and address review findings
- Remove ChargingStation-StopRunningTransactions.test.ts (duplicated coverage with OCPPServiceUtils-StopTransaction.test.ts)
- Move error handling test to OCPPServiceUtils-StopTransaction.test.ts
- Guard undefined evseId in stopTransactionOnConnector (review finding)
- Replace throw with warn in stopRunningTransactions default branch (review finding)
* fix: generate transactionId for OCPP 2.0 start and align offline stop acceptance
- startTransactionOnConnector OCPP 2.0: generate UUID transactionId and reset seqNo when
connector has no transactionId (ATG path)
- stopTransactionOnConnector OCPP 2.0: treat missing idTokenInfo as accepted (offline queued
events return undefined idTokenInfo, consistent with startTransactionOnConnector)
* fix: map Other reason correctly and use static generateUUID import
- mapStopReasonToOCPP20: add explicit Other -> Other/AbnormalCondition mapping
instead of falling through to Local/StopAuthorized
- startTransactionOnConnector: use statically imported generateUUID instead of
unnecessary dynamic import (utils/index.js already imported at top of file)
* test: add coverage for startTransactionOnConnector, flushQueuedTransactionMessages, and mapStopReasonToOCPP20
Jérôme Benoit [Thu, 19 Mar 2026 15:27:49 +0000 (16:27 +0100)]
refactor(webui): harmonize barrel usage in types and composables
Add OCPP16AvailabilityType, OCPP16ChargePointStatus, and
OCPP16RegistrationStatus to the types barrel. Redirect all direct
module imports in tests to use barrels (types/, composables/).
Jérôme Benoit [Thu, 19 Mar 2026 15:18:42 +0000 (16:18 +0100)]
fix: merge duplicate type imports from same barrel module
Consolidate split import type statements from types/index.js into
single imports in OCPP16TestUtils.ts and OCPP20IncomingRequestService-
MasterPass.test.ts.
Jérôme Benoit [Thu, 19 Mar 2026 15:11:03 +0000 (16:11 +0100)]
refactor: harmonize barrel usage across all test files
Redirect all direct module imports (utils/Logger, utils/Constants,
worker/WorkerTypes, types/*, charging-station/ChargingStation) to
their respective barrel index.js in test files. Unit tests of the
module itself retain direct imports per convention.
Jérôme Benoit [Thu, 19 Mar 2026 14:53:24 +0000 (15:53 +0100)]
fix(ocpp): keep StopTransactionRequest as 1.6 wire type, narrow reason via indexed access
Revert the Omit-based widening of StopTransactionRequest — it's a 1.6
wire protocol message and should not accept OCPP 2.0 reason values.
Use StopTransactionRequest['reason'] indexed access type for narrowing
in ChargingStation, avoiding any version-specific OCPP16* import.
Jérôme Benoit [Thu, 19 Mar 2026 14:42:59 +0000 (15:42 +0100)]
fix(ocpp): remove type re-export from services barrel
Move OCPP20TransactionEventEnumType and OCPP20TriggerReasonEnumType
imports in ChargingStation.ts from the services barrel (ocpp/index.ts)
to the types barrel (types/index.ts) where they belong.
Jérôme Benoit [Thu, 19 Mar 2026 14:24:42 +0000 (15:24 +0100)]
refactor(ocpp): consolidate cross-stack types and harmonize barrel imports
Consolidate OCPP types with common semantics across 1.6 and 2.0 stacks
(AuthorizationStatus, StopTransactionReason, MessageTrigger, DataTransfer,
TriggerMessageStatus, UnlockStatus, AvailabilityStatus, HeartbeatRequest/
Response, StatusNotificationResponse, FirmwareStatusNotificationResponse).
Harmonize all imports across src/ and tests/ to use the barrel
(types/index.ts) instead of direct version-specific type paths, matching
the pattern already established by the OCPP 1.6 handlers.
Jérôme Benoit [Thu, 19 Mar 2026 11:17:44 +0000 (12:17 +0100)]
fix(ocpp2): audit TransactionEvent — state ownership, deauthorization, meter values
- Fix periodic TransactionEvent(Updated) to include meter values via buildMeterValue
- Replace non-UUID temp transactionId with generateUUID in OCPP20AuthAdapter
- Refactor state ownership: response handler is sole authority for transactionStarted,
StatusNotification(Occupied), and TxUpdatedInterval start
- Add transactionPending flag to prevent duplicate RequestStartTransaction race conditions
- Add requestDeauthorizeTransaction per E05.FR.09/FR.10/E06.FR.04: sends
Updated(Deauthorized, SuspendedEVSE) then Ended(Deauthorized, DeAuthorized)
- Fix rejection check to cover all non-Accepted idTokenInfo statuses
- Extract buildFinalMeterValues helper to eliminate DRY violation
- Skip Occupied/TxUpdatedInterval setup when idToken is rejected in same response
- Remove cleanup from Ended response handler (owned by caller)
- Add tests for getTxUpdatedInterval, requestDeauthorizeTransaction, Updated-failure path
Jérôme Benoit [Thu, 19 Mar 2026 00:08:33 +0000 (01:08 +0100)]
fix(ocpp2): handle transaction lifecycle in TransactionEvent response
Adapt the OCPP 1.6 transaction lifecycle pattern to OCPP 2.0: manage
connector state (transactionStarted, transactionId, StatusNotification,
meter intervals) in handleResponseTransactionEvent for both Started
and Ended events, matching handleResponseStartTransaction and
handleResponseStopTransaction in OCPP 1.6.
Jérôme Benoit [Wed, 18 Mar 2026 23:32:29 +0000 (00:32 +0100)]
feat(ui): add Catppuccin Latte light theme
Map Catppuccin Latte palette to semantic tokens following the official
style guide: Base for background, Mantle/Crust for secondary panes,
Surface 0/1 for hover/active, Blue for buttons/links, Lavender for
accent, Base for text-on-button (On Accent per guide).
Jérôme Benoit [Wed, 18 Mar 2026 23:23:29 +0000 (00:23 +0100)]
feat(ui): add configurable theme support
Add theme field to ConfigurationData. Theme CSS files are loaded
dynamically from assets/themes/ at startup. Falls back to
tokyo-night-storm when not configured or theme not found.
Move theme.css to assets/themes/tokyo-night-storm.css.
Jérôme Benoit [Wed, 18 Mar 2026 23:14:13 +0000 (00:14 +0100)]
feat(ui): apply Tokyo Night Storm theme with semantic CSS tokens
Add theme.css with two-layer token system: primitive tokens from
the official Tokyo Night Storm palette, semantic tokens mapping UI
roles to primitives. All components use semantic tokens exclusively.
Replace all hardcoded colors across 13 Vue components. Theme native
HTML elements (button, input, select, a, headings) globally. Toggle
button pressed state uses palette-semantic active bg + accent border
+ inset shadow for clear visual distinction.
Remove dead code: simulatorButtonClass computed and associated CSS
classes that duplicated global button styles.
Jérôme Benoit [Wed, 18 Mar 2026 22:21:10 +0000 (23:21 +0100)]
fix: use truncateId consistently for all user identifiers in logs
Replace 16 bare idTag/identifier.value references and 4 manual
substring(0,8) truncations with truncateId() across OCPP 1.6
ResponseService, IncomingRequestService, auth adapters, strategies,
and helpers.
User identifiers (RFID tags, auth tokens) are now consistently
truncated in all log output to prevent sensitive data exposure.
Jérôme Benoit [Wed, 18 Mar 2026 20:33:51 +0000 (21:33 +0100)]
fix: prevent tests from polluting production log files
Set NODE_ENV=test via cross-env in all three test scripts (test,
test:debug, test:coverage). Logger checks NODE_ENV and sets silent
mode, preventing file writes to logs/combined.log and logs/error.log
during test runs.
Jérôme Benoit [Wed, 18 Mar 2026 19:53:19 +0000 (20:53 +0100)]
fix(ocpp): replace this.constructor.name with moduleName in base class logs
Minification mangles class names, causing logs like 'ln.responseHandler'
instead of 'OCPP20ResponseService.responseHandler' in production builds.
Add abstract moduleName property to OCPPResponseService and
OCPPIncomingRequestService base classes, implemented by all four
subclasses using their file-level moduleName constant.
Jérôme Benoit [Wed, 18 Mar 2026 19:04:12 +0000 (20:04 +0100)]
refactor(test): remove duplicate certificate passthrough tests from broadcast channel
These 3 tests duplicated coverage already provided by
OCPP20RequestService-ISO15118.test.ts which tests the same code path
through the full requestHandler pipeline.
Add JSDoc descriptions to buildTransactionEvent implementation to
satisfy jsdoc/require-param-description lint rule.
Jérôme Benoit [Wed, 18 Mar 2026 18:32:25 +0000 (19:32 +0100)]
refactor(ocpp2): extract buildTransactionEvent as standalone function, remove dead context code
Extract buildTransactionEvent from OCPP20ServiceUtils static method to
exported standalone function, consistent with buildStatusNotificationRequest
and buildMeterValue.
Remove unused context overload from buildTransactionEvent and
sendTransactionEvent — all production callers pass triggerReason directly.
Remove dead code: OCPP20TransactionContext interface (not in OCPP 2.0.1
specs), selectTriggerReason method, TransactionContextFixtures, and
associated tests.
Jérôme Benoit [Wed, 18 Mar 2026 16:59:56 +0000 (17:59 +0100)]
refactor(ocpp): add rawPayload bypass, resolve minimal params in buildRequestPayload, fix test types
Add rawPayload option to RequestParams for offline queue replay to
explicitly bypass buildRequestPayload instead of heuristic detection.
Make buildRequestPayload resolve missing TransactionEvent fields from
station context (connectorId from evse, transactionId generation,
triggerReason defaults) so the broadcast channel passthrough works.
Remove pre-built payload guard from OCPP 1.6 STATUS_NOTIFICATION.
Replace Record<string, unknown> downgrades in tests with proper OCPP
types (Partial<OCPP20TransactionEventRequest>, RequestParams).
Jérôme Benoit [Wed, 18 Mar 2026 16:13:49 +0000 (17:13 +0100)]
refactor(ocpp): make buildRequestPayload the authoritative builder for all commands
buildRequestPayload now calls the centralized builders for
TRANSACTION_EVENT (via buildTransactionEvent) and STATUS_NOTIFICATION
(via buildStatusNotificationRequest) in both OCPP versions, matching
the existing pattern for START_TRANSACTION/STOP_TRANSACTION in 1.6.
Callers pass minimal params (eventType, connectorId, status, etc.)
and buildRequestPayload constructs the complete spec-compliant payload.
sendTransactionEvent's offline path builds directly for queueing since
the queue stores pre-built payloads sent as-is on reconnect.
Jérôme Benoit [Wed, 18 Mar 2026 15:03:31 +0000 (16:03 +0100)]
refactor(ocpp): use buildStatusNotificationRequest helper in TriggerMessage handlers
Replace inline StatusNotification payload construction in both OCPP 1.6
and 2.0 TriggerMessage handlers with the centralized
buildStatusNotificationRequest helper. Export the helper from
OCPPServiceUtils to make it available.
This eliminates 5 inline duplications of the same payload structure
that risked diverging from the single source of truth.
Jérôme Benoit [Wed, 18 Mar 2026 14:49:05 +0000 (15:49 +0100)]
refactor(ocpp): harmonize buildRequestPayload switch structure across versions
Group passthrough cases into fall-through blocks in both OCPP 1.6 and
2.0 buildRequestPayload, giving both files a symmetric structure:
grouped passthroughs, heartbeat empty object, enrichment cases, default
error.
Jérôme Benoit [Wed, 18 Mar 2026 14:35:41 +0000 (15:35 +0100)]
fix(ocpp2): revert UI transaction handlers to simple passthrough
Remove handleUIStartTransaction and handleUIStopTransaction which
duplicated connector state management with incomplete initialization
(missing energy register, groupIdToken, StatusNotification, error
rollback) and bypassed authorization checks.
Restore handleTransactionEvent as a simple requestHandler passthrough,
consistent with all other broadcast channel command handlers.
Call OCPP20ServiceUtils.getTxUpdatedInterval() directly from
OCPP20IncomingRequestService instead of through a trivial private
wrapper that was left over from the centralization in PR #1734.
Jérôme Benoit [Wed, 18 Mar 2026 14:16:54 +0000 (15:16 +0100)]
refactor(ocpp2): consolidate dual-path request architecture into single path
Remove 8 unused dedicated request methods (requestFirmwareStatusNotification,
requestGet15118EVCertificate, requestGetCertificateStatus, etc.) that bypassed
buildRequestPayload via direct sendMessage calls. All production callers
already used requestHandler exclusively, making these methods dead code.
Move SignCertificate CSR generation logic into buildRequestPayload, making
it the authoritative payload construction layer — symmetric with OCPP 1.6.
This also adds isRequestCommandSupported check and AJV schema validation
to the SignCertificate flow that the dedicated method bypassed.
Refactor 6 test files to test through requestHandler (production path)
instead of the removed dedicated methods.
Jérôme Benoit [Wed, 18 Mar 2026 13:44:59 +0000 (14:44 +0100)]
refactor(ocpp2): centralize payload construction and eliminate duplication
Remove redundant timestamp injection from buildRequestPayload() for
StatusNotification and TransactionEvent — centralized builders already
provide timestamps and AJV schema validation catches any omission.
Extract buildStationInfoReportData() helper to deduplicate station info
report data construction between FullInventory and SummaryInventory in
buildReportData().
Normalize TriggerMessage Heartbeat to use OCPP20Constants.OCPP_RESPONSE_EMPTY
for consistency with buildRequestPayload().
- Update ConnectorStatus.transactionId to support both number (OCPP 1.6)
and string/UUID (OCPP 2.0.x)
Wave 1 complete.
* feat(ui): add UIClient transaction methods with OCPP version support
- Add transactionEvent() method for OCPP 2.0.x TransactionEvent requests
- Add isOCPP20x() static helper for version detection
- Add startTransactionForVersion() helper that routes to appropriate
method based on OCPP version (1.6 vs 2.0.x)
- Add stopTransactionForVersion() helper for version-aware stop
- Add comprehensive unit tests (16 tests passing)
Wave 2 complete.
* feat(ui): add version-aware StartTransaction form with OCPP 2.0.x support
- Modify StartTransaction.vue to detect OCPP version from station info
- Show connector ID for OCPP 1.6, EVSE ID input for OCPP 2.0.x
- Hide Authorize checkbox for OCPP 2.0.x stations (v-if)
- Use startTransactionForVersion() helper for version-aware API calls
- Add loading state while fetching station info
- Show appropriate form fields based on OCPP version
- All 16 tests passing
Wave 3 complete.
* fix(webui): use enums instead of string literals for OCPP 2.0.x types
- Replace 'ISO14443' string with OCPP20IdTokenEnumType.ISO14443
- Fix test mocks to use Protocol.UI and ResponseStatus.SUCCESS enums
- Export OCPP20IdTokenEnumType from types index
* style(webui): fix import ordering in UIClient.ts
* [autofix.ci] apply automated fixes
* chore: remove tsbuildinfo and add to gitignore
* fix(webui): address PR review comments
- Add ResponseStatus import and use enum instead of string
- Use UIClient.isOCPP20x() helper instead of manual comparison
- Remove redundant showAuthorize computed, use !isOCPP20x directly
- Separate error handling for authorize vs startTransaction
- Add validation for transactionId type in stopTransactionForVersion
* [autofix.ci] apply automated fixes
* chore: move tsbuildinfo gitignore to ui/web subdirectory
- Remove *.tsbuildinfo from root .gitignore
- Add *.tsbuildinfo to ui/web/.gitignore with proper comment
* ci(webui): add TypeScript type checking to CI
- Add vue-tsc dev dependency to ui/web
- Add typecheck script to package.json
- Add typecheck step to build-dashboard job in CI
* fix(webui): fix vue-tsc typecheck and improve Vue.js best practices
- Break recursive JsonObject/JsonType chain causing TS2589 in vue-tsc
- Fix CSConnector to use stopTransactionForVersion with ocppVersion prop
- Replace getCurrentInstance() anti-pattern with useToast()/useRouter()
- Make isOCPP20x a computed instead of manually-synced ref
- Deduplicate handleStartTransaction (remove ~30 lines of duplication)
- Add null guards for watch() on potentially undefined global refs
* [autofix.ci] apply automated fixes
* refactor(webui): align namespace with simulator and improve API design
- Merge startTransactionForVersion/stopTransactionForVersion into
startTransaction/stopTransaction with optional ocppVersion param
- Make transactionEvent private (implementation detail, not public API)
- Revert UITransactionEventPayload to OCPP20TransactionEventRequest
to match backend naming convention
- Pass ocppVersion via route param instead of re-fetching all stations
- Remove convertToBoolean no-op and loading state
- Flip negated v-if condition for SonarCloud compliance
- Factor test setup, remove duplicate coverage, add missing test case
- Net result: -90 lines, cleaner API surface
* [autofix.ci] apply automated fixes
* refactor(webui): move tests from __tests__ to tests/unit for consistency
Align test file location with existing project convention (tests/unit/)
instead of Jest-style __tests__ directory.
* feat(webui): integrate OCPP 2.0 EVSE 3-tier model across web UI
- Add OCPP20EVSEType matching spec EVSEType {id, connectorId?}
- Replace flat evseId with proper evse object in TransactionEventRequest
- CSData: preserve EVSE→Connector mapping instead of flattening
- CSConnector: display 'evseId/connectorId' for OCPP 2.0 stations
- Route: pass evseId and ocppVersion as query params (not sentinels)
- StartTransaction: read EVSE context from query, display EVSE/Connector
- UIClient.startTransaction: accept evseId, build spec-compliant evse object
- Tests: exhaustive decision tree coverage (18 tests, all branches)
* [autofix.ci] apply automated fixes
* refactor(webui): improve API elegance and fix cross-version concerns
- Refactor startTransaction/stopTransaction to use named options object
instead of positional params for better readability and grouping
- Fix ToggleButton ID collision: include evseId for multi-EVSE uniqueness
- Normalize idTag validation as cross-version concern (empty→undefined)
- Rename getConnectorStatuses→getConnectorEntries to match semantics
- Extract toggleButtonId as computed to avoid string duplication
* feat: entry-based serialization for EVSE/Connector/ATG data
Introduce ConnectorEntry, EvseEntry, and ATGStatusEntry types at the
UI serialization boundary to preserve Map keys (evseId, connectorId)
that were previously lost during Map-to-Array conversion.
Backend:
- Add buildConnectorEntries/buildEvseEntries using .entries()
- Keep buildConnectorsStatus/buildEvsesStatus unchanged for config persistence
- Remove EvseStatusWorkerType and OutputFormat enum
- ATG statuses serialized with connectorId at the UI boundary only
- ConnectorStatus and EvseStatus types remain pure (no identity fields)
Frontend:
- CSData uses explicit IDs from Entry types (no more index-based mapping)
- ATG status lookup by connectorId instead of array index
- Filter connector 0 in both OCPP 1.6 and 2.0 paths
- Both connectors and evses optional in ChargingStationData
* [autofix.ci] apply automated fixes
* fix(webui): use data presence instead of protocol version for EVSE display
EVSE/Connector display depends on whether the station has EVSEs (data),
not on the OCPP version (protocol). A station could use EVSEs regardless
of OCPP version.
* refactor: extract buildATGStatusEntries for consistent Entry builder pattern
Align ATG status serialization with ConnectorEntry/EvseEntry pattern:
dedicated builder function instead of inline transformation.
* refactor: harmonize Entry naming pattern across codebase
Rename ATGStatusEntry/buildATGStatusEntries to ATGEntry/buildATGEntries
to match ConnectorEntry/EvseEntry naming convention.
* refactor: define ATGConfiguration type and harmonize across workspaces
Extract inline ATG type into named ATGConfiguration interface, matching
the ATG*/Connector*/Evse* Entry pattern in both backend and frontend.
* test: add missing Entry builder tests and non-sequential ID coverage
- Add buildATGEntries tests (entries with IDs, non-sequential, no ATG, no status)
- Add non-sequential connector ID test for buildConnectorEntries (keys 0,3,7)
- Add non-sequential evseId/connectorId test for buildEvseEntries (3/2,5)
- These tests verify the core invariant of the Entry pattern: Map keys are
preserved regardless of their sequence
* refactor: organize tests by concern and replace throw with graceful failure
- Group backend tests: config persistence builders then UI Entry builders
- Replace throw Error in stopTransaction with ResponsePayload FAILURE
to avoid unhandled rejections in UI components
* docs: harmonize quality gate ordering (typecheck before lint) across codebase
Align CI workflows, READMEs, and copilot-instructions to consistently
run typecheck before lint in all three sub-projects.
* refactor(ocpp2): centralize TransactionEvent payload building
- requestStopTransaction delegates to sendTransactionEvent instead of
building the OCPP payload inline, eliminating duplication
- All TransactionEvent paths now converge through sendTransactionEvent
→ buildTransactionEvent as the single payload construction point
- handleTransactionEvent (UI) dispatches Started/Ended to proper flows
with connector state initialization and lifecycle management
- Remove unused imports (secondsToMilliseconds, Constants)
repositories / e-mobility-charging-stations-simulator.git / log
