aardizio [Fri, 19 Feb 2021 08:54:23 +0000 (09:54 +0100)]
Take change from jerome
aardizio [Fri, 19 Feb 2021 08:50:56 +0000 (09:50 +0100)]
Merge branch 'master' of https://github.com/pioardi/node-pool
Jérôme Benoit [Fri, 19 Feb 2021 08:50:49 +0000 (09:50 +0100)]
Merge pull request #193 from pioardi/deps
Update dependencies
aardizio [Fri, 19 Feb 2021 08:50:47 +0000 (09:50 +0100)]
Add publish step into one job
Jérôme Benoit [Thu, 18 Feb 2021 21:47:58 +0000 (22:47 +0100)]
Update dependencies
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Alessandro Pio Ardizio [Thu, 18 Feb 2021 20:40:39 +0000 (21:40 +0100)]
Update package.json
Jérôme Benoit [Thu, 18 Feb 2021 20:10:54 +0000 (21:10 +0100)]
CI: always lint after build. (#192)
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Alessandro Pio Ardizio [Thu, 18 Feb 2021 19:37:48 +0000 (20:37 +0100)]
Update package.json
Jérôme Benoit [Thu, 18 Feb 2021 18:16:29 +0000 (19:16 +0100)]
Merge pull request #189 from pioardi/ut
Use a configuration file for mocha ut
Jérôme Benoit [Thu, 18 Feb 2021 16:21:36 +0000 (17:21 +0100)]
Use a configuration file for mocha ut
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Alessandro Pio Ardizio [Thu, 18 Feb 2021 16:03:47 +0000 (17:03 +0100)]
Fix EPIPE when run unit tests (#187)
* Try to remove the --exit
* Revert "Fix EPIPE on shutdown"
This reverts commit
4dc274761ce688172117009d1b306077d321f461.
* Graceful shutdown during unit tests
* Readd exit since that was not the solution
* Capital letters on comments
* Destroy all pools in after (#188)
Co-authored-by: Shinigami <chrissi92@hotmail.de>
aardizio [Thu, 18 Feb 2021 13:21:23 +0000 (14:21 +0100)]
Fix EPIPE on shutdown
Jérôme Benoit [Thu, 18 Feb 2021 12:56:11 +0000 (13:56 +0100)]
Merge pull request #186 from pioardi/documentation
Jérôme Benoit [Thu, 18 Feb 2021 11:44:36 +0000 (12:44 +0100)]
README.md: Small refinements
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Jérôme Benoit [Thu, 18 Feb 2021 11:37:14 +0000 (12:37 +0100)]
Make the documentation less worker-threads centric. (#183)
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Thu, 18 Feb 2021 10:00:39 +0000 (11:00 +0100)]
Fix sonar code smells (#184)
* Fix sonar code smells
* Add coverage thresholds
* Coverage thresholds
* Update src/pools/abstract-pool.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
* Update src/pools/abstract-pool.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
* Update src/worker/abstract-worker.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
* Update src/worker/abstract-worker.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Jérôme Benoit [Wed, 17 Feb 2021 20:57:30 +0000 (21:57 +0100)]
Factor out worker tasks number in/de-crement. (#182)
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Alessandro Pio Ardizio [Wed, 17 Feb 2021 19:13:21 +0000 (20:13 +0100)]
Issue 160 ci unit test (#181)
* Fix issue 160
* Keep comments
* Keep comments
Shinigami [Wed, 17 Feb 2021 11:19:28 +0000 (12:19 +0100)]
Update CHANGELOG.md (#178)
Alessandro Pio Ardizio [Wed, 17 Feb 2021 10:43:27 +0000 (11:43 +0100)]
Update CHANGELOG.md
Alessandro Pio Ardizio [Wed, 17 Feb 2021 09:54:49 +0000 (10:54 +0100)]
Tests enhancement (#172)
* Increase coverage and remove deprecated methods
* Add utility test function instead of use setTimeout to wait workers scale down
* Decrease a little bit the required nyc percentages
* Add a TestUtils class.
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* More sleep usage.
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Run npm format.
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Remove deprecated methods and update changelog, increase require coverage
* Check coverage change
Co-authored-by: Jérôme Benoit <jerome.benoit@sap.com>
Shinigami [Wed, 17 Feb 2021 07:58:12 +0000 (08:58 +0100)]
Improve jsdoc comments (#175)
* Improve jsdoc comments
* Update eslint-plugin-jsdoc
Shinigami [Tue, 16 Feb 2021 17:45:14 +0000 (18:45 +0100)]
Fix JSDoc (#171)
Alessandro Pio Ardizio [Tue, 16 Feb 2021 16:39:47 +0000 (17:39 +0100)]
Merge pull request #153 from pioardi/add-worker-test
Add tests for workers
Shinigami [Tue, 16 Feb 2021 16:19:52 +0000 (17:19 +0100)]
Merge branch 'master' into add-worker-test
Alessandro Pio Ardizio [Tue, 16 Feb 2021 16:19:36 +0000 (17:19 +0100)]
Document new kill behavior on the readme (#170)
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92 [Tue, 16 Feb 2021 15:08:46 +0000 (16:08 +0100)]
Merge branch 'master' into add-worker-test
Alessandro Pio Ardizio [Tue, 16 Feb 2021 15:01:33 +0000 (16:01 +0100)]
Merge pull request #161 from pioardi/issue-70
Better handling for maxInactiveTime on dynamic pools
Shinigami [Tue, 16 Feb 2021 14:57:09 +0000 (15:57 +0100)]
Improvements for #161 (#169)
aardizio [Tue, 16 Feb 2021 13:57:53 +0000 (14:57 +0100)]
Add test cases and fixed some sonar code smells
aardizio [Tue, 16 Feb 2021 13:05:48 +0000 (14:05 +0100)]
Change killBehaviorEnumeration to killBehaviorTypes
aardizio [Tue, 16 Feb 2021 11:37:08 +0000 (12:37 +0100)]
Increased test timeouts, we need to look into that as soon as we can
aardizio [Tue, 16 Feb 2021 11:23:11 +0000 (12:23 +0100)]
Linting
aardizio [Tue, 16 Feb 2021 11:17:25 +0000 (12:17 +0100)]
TODO for shinigami
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:22:55 +0000 (11:22 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:22:31 +0000 (11:22 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:22:21 +0000 (11:22 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:22:07 +0000 (11:22 +0100)]
Update src/worker/abstract-worker.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:21:18 +0000 (11:21 +0100)]
Update src/utility-types.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:20:28 +0000 (11:20 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:20:11 +0000 (11:20 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:19:54 +0000 (11:19 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:19:41 +0000 (11:19 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:19:10 +0000 (11:19 +0100)]
Update src/worker/worker-options.ts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 10:14:40 +0000 (11:14 +0100)]
Merge branch 'master' into issue-70
aardizio [Tue, 16 Feb 2021 10:12:17 +0000 (11:12 +0100)]
Enhance changelog documentation
aardizio [Tue, 16 Feb 2021 10:07:12 +0000 (11:07 +0100)]
Implementation for killBehavior based on the last feedbacks
Jérôme Benoit [Tue, 16 Feb 2021 09:55:54 +0000 (10:55 +0100)]
Update dependencies (#168)
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Alessandro Pio Ardizio [Tue, 16 Feb 2021 07:58:57 +0000 (08:58 +0100)]
Merge pull request #164 from pioardi/benchmark
Fix benchmarks run: use synchronous call.
Jérôme Benoit [Mon, 15 Feb 2021 22:26:06 +0000 (23:26 +0100)]
Fix benchmarks run: use synchronous call.
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Alessandro Pio Ardizio [Mon, 15 Feb 2021 21:21:07 +0000 (22:21 +0100)]
Merge branch 'master' into issue-70
Alessandro Pio Ardizio [Mon, 15 Feb 2021 21:15:16 +0000 (22:15 +0100)]
Merge pull request #163 from pioardi/ci
CI: Bump GitHub actions version to v2
Jérôme Benoit [Mon, 15 Feb 2021 21:07:53 +0000 (22:07 +0100)]
CI: Bump GitHub actions version to v2
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Jérôme Benoit [Mon, 15 Feb 2021 19:25:05 +0000 (20:25 +0100)]
README.md: formatting fixes. (#162)
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
aardizio [Mon, 15 Feb 2021 18:51:15 +0000 (19:51 +0100)]
Fix typing error
aardizio [Mon, 15 Feb 2021 18:40:09 +0000 (19:40 +0100)]
Add a blank line
aardizio [Mon, 15 Feb 2021 18:37:12 +0000 (19:37 +0100)]
Implement PR reviews
Alessandro Pio Ardizio [Mon, 15 Feb 2021 16:30:30 +0000 (17:30 +0100)]
Merge branch 'master' into issue-70
aardizio [Mon, 15 Feb 2021 16:29:36 +0000 (17:29 +0100)]
Cluster pool is now working
aardizio [Mon, 15 Feb 2021 16:13:04 +0000 (17:13 +0100)]
Thread implementation working and tested with TDD expeting a failure and then adding code and expect success
aardizio [Mon, 15 Feb 2021 16:05:11 +0000 (17:05 +0100)]
Changelog add bug fixes
aardizio [Mon, 15 Feb 2021 16:00:30 +0000 (17:00 +0100)]
Better handling for maxInactiveTime on dynamic pools
Jérôme Benoit [Mon, 15 Feb 2021 15:55:38 +0000 (16:55 +0100)]
Build minified for production (#155)
* Build minified for production
And use dev build in CI
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Rename scripts:
nothing -> default dev build
:prod -> production build
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Trigger build analysis output on demand via an env variable
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Always register source map support.
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Revert to one build output for coverage on sonar cloud.
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Revert "Revert to one build output for coverage on sonar cloud."
This reverts commit
f3d990ba9878e4e6f097844cacba9e8e4b4c9121.
* Try with sourcemap: false
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Build with sourcemap: true
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Go back to previous sourcemap setting.
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Change sonar sources
Co-authored-by: Alessandro Pio Ardizio <alessandroardizio94@gmail.com>
Alessandro Pio Ardizio [Mon, 15 Feb 2021 14:46:27 +0000 (15:46 +0100)]
Merge pull request #159 from pioardi/logo-and-readme
Logo and readme
aardizio [Mon, 15 Feb 2021 14:02:42 +0000 (15:02 +0100)]
Adjust feature order
aardizio [Mon, 15 Feb 2021 14:01:00 +0000 (15:01 +0100)]
Merge branch 'logo-and-readme' of https://github.com/pioardi/node-pool into logo-and-readme
aardizio [Mon, 15 Feb 2021 14:00:52 +0000 (15:00 +0100)]
Add check mark at each feature
Alessandro Pio Ardizio [Mon, 15 Feb 2021 13:59:36 +0000 (14:59 +0100)]
Update README.md
aardizio [Mon, 15 Feb 2021 13:58:55 +0000 (14:58 +0100)]
Adjust logo
Alessandro Pio Ardizio [Mon, 15 Feb 2021 13:55:24 +0000 (14:55 +0100)]
Update README.md
Alessandro Pio Ardizio [Mon, 15 Feb 2021 13:36:52 +0000 (14:36 +0100)]
Update README.md
Alessandro Pio Ardizio [Mon, 15 Feb 2021 11:54:05 +0000 (12:54 +0100)]
Update README.md
Alessandro Pio Ardizio [Mon, 15 Feb 2021 11:44:36 +0000 (12:44 +0100)]
Update README.md
aardizio [Mon, 15 Feb 2021 11:16:04 +0000 (12:16 +0100)]
Fix coverage link
aardizio [Mon, 15 Feb 2021 11:09:31 +0000 (12:09 +0100)]
Fix
aardizio [Mon, 15 Feb 2021 11:08:08 +0000 (12:08 +0100)]
Improve readme, added logo
Alessandro Pio Ardizio [Mon, 15 Feb 2021 09:11:27 +0000 (10:11 +0100)]
Merge pull request #157 from pioardi/dependabot/npm_and_yarn/types/node-14.14.28
Bump @types/node from 14.14.27 to 14.14.28
Alessandro Pio Ardizio [Mon, 15 Feb 2021 09:07:08 +0000 (10:07 +0100)]
Merge branch 'master' into dependabot/npm_and_yarn/types/node-14.14.28
Alessandro Pio Ardizio [Mon, 15 Feb 2021 09:06:54 +0000 (10:06 +0100)]
Merge pull request #158 from pioardi/dependabot/npm_and_yarn/eslint-plugin-jsdoc-32.0.0
Bump eslint-plugin-jsdoc from 31.6.1 to 32.0.0
Alessandro Pio Ardizio [Mon, 15 Feb 2021 08:58:32 +0000 (09:58 +0100)]
Update package.json
dependabot-preview[bot] [Mon, 15 Feb 2021 07:10:32 +0000 (07:10 +0000)]
Bump eslint-plugin-jsdoc from 31.6.1 to 32.0.0
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 31.6.1 to 32.0.0.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v31.6.1...v32.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview[bot] [Mon, 15 Feb 2021 07:09:45 +0000 (07:09 +0000)]
Bump @types/node from 14.14.27 to 14.14.28
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.27 to 14.14.28.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Shinigami [Sun, 14 Feb 2021 19:03:59 +0000 (20:03 +0100)]
Merge branch 'master' into add-worker-test
Shinigami [Sun, 14 Feb 2021 19:02:52 +0000 (20:02 +0100)]
Improve chooseWorker function in dynamic pools (#152)
Shinigami [Sun, 14 Feb 2021 17:18:51 +0000 (18:18 +0100)]
Merge branch 'master' into add-worker-test
Shinigami [Sun, 14 Feb 2021 17:18:34 +0000 (18:18 +0100)]
De-duplicate code for workers (#154)
Shinigami92 [Sun, 14 Feb 2021 14:02:42 +0000 (15:02 +0100)]
Add test for workers
Shinigami92 [Sun, 14 Feb 2021 13:39:37 +0000 (14:39 +0100)]
Rename folder
Jérôme Benoit [Sun, 14 Feb 2021 13:12:15 +0000 (14:12 +0100)]
Benchmark: Ensure choice algos does not init with off-by-one (#151)
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Jérôme Benoit [Sun, 14 Feb 2021 08:14:24 +0000 (09:14 +0100)]
Build system: add bundling analysis to dev build (#150)
Shinigami [Sun, 14 Feb 2021 07:12:25 +0000 (08:12 +0100)]
Revert choose worker implementation (#148)
Shinigami [Sat, 13 Feb 2021 23:05:23 +0000 (00:05 +0100)]
Clean worker from pool after it was destroyed (#146)
Co-authored-by: Jérôme Benoit <jerome.benoit@sap.com>
Shinigami [Sat, 13 Feb 2021 18:28:44 +0000 (19:28 +0100)]
Improve property namings (#145)
Shinigami [Sat, 13 Feb 2021 15:49:49 +0000 (16:49 +0100)]
Add eslint-plugin-spellcheck (#139)
Jérôme Benoit [Sat, 13 Feb 2021 15:31:01 +0000 (16:31 +0100)]
Cleanups (#144)
+ Run lint first at npm publication CI
+ Import from cluster the minimum in test
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Alessandro Pio Ardizio [Sat, 13 Feb 2021 14:58:16 +0000 (15:58 +0100)]
Coverage ci (#132)
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Jérôme Benoit [Sat, 13 Feb 2021 13:16:47 +0000 (14:16 +0100)]
Use rollup-plugin-typescript2 for TS transpilation (#143)
Shinigami [Sat, 13 Feb 2021 13:06:26 +0000 (14:06 +0100)]
Add eslint-plugin-jsdoc (#142)
Shinigami [Sat, 13 Feb 2021 10:42:48 +0000 (11:42 +0100)]
Improve JSDoc comments (#130)
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Jérôme Benoit [Sat, 13 Feb 2021 10:40:47 +0000 (11:40 +0100)]
Simplify worker choosing (#138)