fix(ui): make Authorize version-aware for OCPP 2.0.1 stations
Extract shared OCPP version-aware payload builders into
ui-common/src/utils/payloadBuilders.ts (buildAuthorizePayload,
buildStartTransactionPayload, buildStopTransactionPayload, isOCPP20x,
buildIdToken) and consume them from both Web UI and CLI.
The Web UI Authorize was always sending flat { idTag } regardless of
OCPP version, causing "Request PDU is invalid" on OCPP 2.0.1 stations
which require { idToken: { idToken, type } }.
fix(ui-web): resolve WS race condition causing DISCONNECTED on modern skin
Problem: when skin layouts are lazy-loaded via defineAsyncComponent, the
WebSocket 'open' event can fire before the layout mounts and registers its
listener. The layout then shows DISCONNECTED until manual refresh because
getData() is never triggered.
Root cause: UIClient connects in main.ts constructor (fire-and-forget),
but the skin layout mounts asynchronously after the chunk loads. If the
WS handshake completes during chunk loading, the 'open' event is dispatched
to an EventTarget with zero listeners.
Fix: expose connection state and fetch eagerly when already connected.
- ui-common/WebSocketClient: add `get connected(): boolean` getter
(returns readyState === OPEN)
- ui-web/UIClient: add `isConnected(): boolean` (delegates to client.connected)
- ui-web/useLayoutData: in onMounted, call getData() immediately if
isConnected() is true. Otherwise the normal 'open' handler will
trigger getData() when the connection establishes — no premature
fetch, no error toast, no duplicate calls.
- ui-web/tests: add isConnected to MockUIClient (defaults to false);
add 2 explicit tests for both branches of the mount-time check
feat(ui-web): implement runtime skin system with classic and modern skins (#1815)
* feat(ui-web): add opt-in v2 UI with Material-inspired design
Parallel Vue 3 UI at /v2 that mirrors the existing feature set with a
flat Material-inspired palette, card-based station layout, modal
dialogs (Teleport + focus trap), grouped action buttons with clear
hierarchy, and a theme toggle (auto/light/dark, persisted per-user).
The v2 tree is fully self-contained under src/v2/; only three files
outside that folder change:
- router/index.ts: five /v2/* routes mirroring the existing ones
- App.vue: v1/v2 toggle link + top-level named <router-view> for v2
dialogs
- README.md: note on /v2 opt-in and merge path
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(ui-web): add unit tests for the v2 UI subtree
Covers every v2 file (ActionButton, StatePill, Modal, ConfirmDialog,
SimulatorBar, StationCard, ConnectorRow, V2NotFoundView, the four
dialogs, v2Errors, and V2ChargingStationsView) under a dedicated
tests/unit/v2/ folder so it can be dropped as a unit when v1 is
removed.
Takes the global coverage back above the existing 91/89/83/91
thresholds (lines 93.2%, branches 92.2%, functions 86.1%, statements
92.3%) after the v2 subtree added 643 previously-untested lines.
Mocks the Teleport-based Modal with an inline stub in dialog tests so
wrapper.find() reaches the form inputs.
* feat(ui-web): add skin+theme schema, token contract, and skin registry
- feat(ui-common): add skin and theme fields to configuration schema
- ConfigurationData: add skin?: string alongside existing theme?: string
- configurationSchema: add skin and theme as optional string fields
- Fixes pre-existing gap where theme was typed but not Zod-validated
- feat(ui-web): extend theme CSS files with unified token contract
- All 3 theme files: add [data-theme=<name>] selector for runtime switching
- Add 9 new semantic tokens: bg-raised, bg-sunken, state-ok/warn/err/idle,
spacing-xl, font-size-base/xs; color-scheme: dark|light
- All existing token names and values unchanged (backward compatible)
- feat(ui-web): add TOKEN_CONTRACT TypeScript interface in shared/tokens
- 33-entry as const map of semantic name to CSS custom property name
- Exports TokenName and CssCustomProperty derived types
- feat(ui-web): add skin registry with classic and modern skin definitions
- SkinDefinition interface with lazy CSS loader for code splitting
- DEFAULT_SKIN = 'classic'
- CSS module shim added to shims-vue.d.ts for TypeScript resolution
* feat(ui-web): add useSkin and useTheme composables
- useSkin: module-level singleton for runtime skin switching
- activeSkinId ref initialized from localStorage (fallback: 'classic')
- switchSkin() validates, lazy-loads CSS, persists preference
- Eager load of initial skin styles at module init
- useTheme: module-level singleton for runtime theme switching
- activeTheme ref initialized from localStorage (fallback: 'tokyo-night-storm')
- setTheme() sets data-theme attribute + color-scheme on document root
- ThemeName union type exported for component type safety
- Themes: catppuccin-latte | sap-horizon | tokyo-night-storm (alphabetical)
- eslint.config.js: add 'catppuccin' to cspell words list
* feat(ui-web): add shared composables and classic skin structure
- feat(ui-web): add shared headless composables
- useStationStatus: pure OCPP status → 'ok'|'warn'|'err'|'idle' mapping
- useAddStationsForm: all 12 form fields + submit/reset for adding stations
- useSetUrlForm: supervision URL form state + validated submit
- useStartTxForm: start transaction with optional authorize flow
- feat(ui-web): create skins/classic/ directory structure
- ClassicLayout.vue: table-based root layout (adapted from ChargingStationsView)
- classic.css: structural tokens for classic skin
- Full component tree: Container, Button, StateButton, ToggleButton,
CSTable, CSData, CSConnector, and 3 action components
- Internal imports use relative paths; @/composables remain shared
- fix(eslint): add skins/classic/ paths to multi-word component name exceptions
* feat(ui-web): create skins/modern/ structure with migrated CSS tokens
- feat(ui-web): modern skin directory structure
- ModernLayout.vue: card-based root layout (from V2ChargingStationsView.vue)
- CSS import updated to './modern.css'
- Component imports updated to './components/...'
- Theme cycle logic removed (replaced by unified useTheme() in T18)
- 7 base components + 4 dialog components copied from v2
- composables/constants.ts: skin-local route/key constants
- composables/errors.ts: error handling utilities
- feat(ui-web): migrate modern.css CSS tokens to unified contract
- 0 --v2-primary refs remain (replaced by --color-primary)
- 0 --v2-state-* refs remain (replaced by --color-state-*)
- 0 [data-v2-theme] blocks remain (removed — theme via unified system)
- 242 var(--v2-*) references migrated to --skin-* or --color-* tokens
- Structural tokens renamed: --v2-space/radius/elev/font/* → --skin-space/radius/shadow/font/*
- File reduced from 1311 to 1218 lines (93 lines of redundant light overrides removed)
* feat(ui-web): integrate skin system into App.vue, main.ts, and router
- feat(ui-web/App.vue): replace dual-view shell with skin switching shell
- defineAsyncComponent layoutMap for ClassicLayout + ModernLayout
- :key={activeSkinId} forces full remount on skin switch
- Fade transition (opacity 0.2s) between skins
- App.vue reduced to 46 lines (pure orchestration, no skin logic)
- feat(ui-web/main.ts): replace dynamic theme loading with static imports
- All 3 theme CSS files loaded eagerly at boot
- Theme applied via useTheme().setTheme() composable
- Skin preference initialized from config.skin → useSkin().switchSkin()
- Config.skin and config.theme both respected with localStorage override
- feat(ui-web/router): remove v2 routes, keep v1 skin-agnostic routes
- Remove all /v2/* routes and V2 component imports
- Keep named 'action' view routes for classic skin sidebar panels
- Action panel components loaded lazily via async imports
- No skin-specific paths in router (both skins share same URLs)
- fix(ui-web/ClassicLayout.vue): add router-view name='action' for sidebar
* refactor(ui-web): integrate shared composables into both skins and add skin/theme switchers
- refactor(ui-web/classic): action components use shared headless composables
- AddChargingStations: uses useAddStationsForm() for all form state + submit
- SetSupervisionUrl: uses useSetUrlForm() for form state + validated submit
- StartTransaction: uses useStartTxForm() for form state + async submit
- feat(ui-web/classic): add skin/theme selectors to ClassicLayout top bar
- useSkin() provides activeSkinId, skins, switchSkin
- useTheme() provides activeTheme, availableThemes, setTheme
- Two <select> elements for runtime skin and theme switching
- feat(ui-web/modern): add skin selector to SimulatorBar
- useSkin() integrated for runtime skin switching
* docs(ui-web): document skin system and update configuration
- Add skin field to config-template.json (skin: 'classic' default)
- Add Skins section to README after Theming section
- Add skin row to configuration reference table
- Remove 'Trying the v2 UI' section (v2 is now the 'modern' skin)
* test(ui-web): add skin system tests and fix lint warnings
- test(ui-web): add tests for skin system composables
- useSkin: 7 tests (init, switchSkin, persistence, invalid skin)
- useTheme: 9 tests (init, setTheme, DOM attribute, localStorage, color-scheme)
- useStationStatus: 11 tests (all OCPP connector statuses + WS variants)
- registry: 7 tests (DEFAULT_SKIN, skin definitions, required fields)
- fix(eslint): add focusables, cret to cspell words list
- fix(eslint): disable vue/order-in-components for test files
- fix(ui-web): fix perfectionist/sort-imports in ToggleButton, CSConnector
- fix(ui-web): add JSDoc param descriptions in SimpleComponents.test.ts
- fix(ui-web): auto-fix html-indent and comma-dangle formatting
* test(ui-web): add form composable tests and fix coverage thresholds
- test(ui-web): add tests for shared form composables
- useAddStationsForm: 7 tests (init, templates, reset, submit)
- useSetUrlForm: 6 tests (init, validation, submit)
- useStartTxForm: 7 tests (init, submit, authorize flow)
- fix(ui-web/vitest): exclude skin component copies from coverage
- skins/classic/components/** (copies of src/components/)
- skins/classic/ClassicLayout.vue (adaptation of ChargingStationsView)
- skins/modern/components/** (copies of src/v2/components/)
- skins/modern/ModernLayout.vue (adaptation of V2ChargingStationsView)
- skins/modern/composables/** (skin-local constants)
- shared/tokens/** (pure as const, no logic)
- src/v2/** (original v2 directory)
- fix(ui-web): update v2 test imports to skins/modern paths
- Coverage thresholds met: 91.35% stmts, 91.64% branches, 85.18% funcs, 91.44% lines
* refactor(ui-web/modern): use shared composables in modern skin dialogs
- AddStationsDialog: uses useAddStationsForm() for all form state + submit
- SetSupervisionUrlDialog: uses useSetUrlForm() for form state + validated submit
- StartTransactionDialog: uses useStartTxForm() for async authorize + start flow
- ConnectorRow: uses getConnectorStatusVariant() for status → variant mapping
Eliminates duplicated business logic between classic and modern skins.
Both skins now share the same headless composables for all form operations.
Move skins/registry.ts → shared/skins/registry.ts so the shared layer no longer
depends on the skins layer. Update all import paths (useSkin.ts, 2 test files).
CSS dynamic imports now use absolute @/ paths for clarity.
- fix(eslint): correct 'cret' typo to 'secret' in cspell words list
- fix(ui-web/useSkin): validate activeSkinId against registry on init
Add getValidSkinId() helper — falls back to DEFAULT_SKIN if localStorage
contains an unregistered skin id (prevents inconsistent UI state)
- fix(ui-web/CSData): wrap new URL() in try/catch for malformed supervision URLs
Returns raw string on parse failure instead of crashing the component
- fix(ui-web/router): NOT_FOUND route renders 404 message instead of blank
- fix(ui-web/useStartTxForm): submitForm returns Promise<boolean>
Dialog only closes on success (true); stays open on error for user retry
* [autofix.ci] apply automated fixes
* refactor(ui-web): complete P4 remediation — DRY, dead code removal, test migration
A11 — Derive skinLayoutMap from registry (DRY):
- Add loadLayout field to SkinDefinition interface
- App.vue derives layout from registry.skins.find() instead of hardcoded map
- Adding a skin now requires changes in ONE file only (registry.ts)
PR#11 — Remove dead src/v2/ code + migrate tests:
- Delete entire src/v2/ directory (dead code — app loads from skins/modern/)
- Migrate 7 test files from tests/unit/v2/ → tests/unit/skins/modern/
- Update all imports from @/v2/ → @/skins/modern/
- Adapt tests to modern skin interfaces:
- ConnectorRow/StationCard: emit events instead of router.push
- Dialogs: emit 'close' instead of navigating
- SimulatorBar: remove theme cycling tests (replaced by useTheme select)
- ChargingStationsView → ModernLayout: remove theme tests, update stubs
- Remove src/v2/ from vitest coverage exclusions
PR#8 — Test strengthening:
- useStationStatus: add second assertion to each test (2.0+ avg)
- Add exhaustiveness test covering all 11 known status values
- Layout exclusions kept (justified: integration-level, ~67% coverage without)
P5 — Code elegance (useAddStationsForm):
- Extract makeInitialState() factory (eliminates DRY violation)
- Extract nonEmpty() helper (eliminates 4 verbose ternaries)
- Both with proper JSDoc as required by project lint rules
P7 — Unify localStorage key:
- Modern skin now uses UI_SERVER_CONFIGURATION_INDEX_KEY (same as classic)
- Delete skins/modern/composables/constants.ts (was only V2_UI_SERVER_INDEX_KEY)
- Server selection persists correctly when switching between skins
S1+S3: Make dialog submit async with pending state; restore authorizeIdTag=true default
S2: Fix credential clearing — always send empty strings (not undefined)
S4: Use shallowRef for wholesale-replaced providers (performance)
S5: Extract useLayoutData composable eliminating 50-line cross-skin duplication
S10: Add error/loading fallbacks to defineAsyncComponent
S11: Self-host Onest font (remove Google Fonts external dependency)
S12: Remove useSkin eager fire-and-forget (canonical init via main.ts)
All 292 tests pass.
* refactor(ui-web): final audit batch — dead code, token test, v2→modern rename, naming
S7: Remove dead getWsStatusVariant export
S8: Add token contract enforcement test (all themes must define all tokens)
S14: Remove modern/composables from coverage exclusion
G1: Pre-create defineAsyncComponent map for skin switching
G3: Rename v2- CSS prefix to modern- across all modern skin files (~142 occurrences)
G4: Rename switchSkin→setSkin for naming coherence with setTheme
G7: Rename ChargingStationsView.test.ts→ModernLayout.test.ts
All 292 tests pass.
* refactor(ui-web): import storage keys from composables instead of duplicating literals
* refactor(ui-web): decouple router from hardcoded skin identifiers
* style(ui-web): replace hardcoded colors with token references
* refactor(ui-web): fix reactivity patterns in modern skin and shared composables
* refactor(ui-web): align classic skin with Vue.js best practices
* fix(ui-web): remove vestigial v2 naming and dead navigation link
* test(ui-web): add unit tests for useSimulatorControl composable
* chore(ui-web): fix lint issues in useSimulatorControl composable and tests
* fix(ui-web): replace innerHTML with textContent for config error display
* style(ui-web): fix test naming grammar to follow style guide
* test(ui-web): add coverage for SkinLoadError and SkinLoading components
* refactor(ui-web): inject layout data into useSimulatorControl; centralize uiServerConfigurations
* refactor(ui-web): extract useAsyncAction composable from modern skin components
* fix(ui-web): mock useConfiguration in useLayoutData tests after T3 refactor
* style(ui-web): apply format fixes and resolve lint errors from quality gate run
* fix(ui-web): address audit findings for skin system robustness and code quality
- Wrap localStorage access in try/catch for Safari Private Browsing and corruption resilience
- Make switchSkin() idempotent for already-active skin (fixes preference reset on reload)
- Add timeout and pending guard to server switch with stale listener cleanup
- Return readonly(pending) from useAsyncAction, wrap callbacks in try/catch
- Remove key-based forced remount in ClassicLayout (performance improvement)
- Add recovery button in SkinLoadError for broken skin JS chunk recovery
- Add cancelled flag in StartTransactionDialog to prevent orphaned operations
- Fix useStartTxForm to catch internally instead of re-throwing (contract fix)
- Rename useStationStatus to stationStatus (pure utility, not a composable)
- Extract shared theme CSS element resets to base.css (DRY)
- Fix test style violations (JSDoc headers, grammatical names, single describe)
- Replace inline fieldset styles with CSS class in AddStationsDialog
- Remove redundant Array.isArray() checks in ClassicLayout
- Remove unused SkinDefinition.description field from registry
- Rename modern composables/ to utils/ (contains pure utilities, not composables)
- Use CSS variable fallbacks in 404 route inline template
- Add classic skin smoke tests (ClassicLayout renders without crashing)
- Add timeout tests for useSimulatorControl server switch
* fix(ui-web): address audit findings across skin system
- fix dialog close-on-failure: submitForm returns boolean, dialogs stay open on error
- fix SetSupervisionUrlDialog reconnect race: await submitForm before reconnect
- fix useAsyncAction promise chain: reorder to .then().catch().finally()
- fix NOT_FOUND route: render in default view for both skins
- fix useSkin eager CSS load race with main.ts initialization
- fix useSimulatorControl timeout leak and listener stacking
- fix stationStatus case-insensitive matching
- fix CSData method calls converted to computed properties
- fix modern.css hardcoded values extracted to skin tokens
- fix SkinLoadError reload loop protection via sessionStorage counter
- fix authorizeIdTag default to true (matching source PR #1804)
- fix numberOfStations input bounded to max=100
- fix useTheme: export AVAILABLE_THEMES, setTheme accepts string
- fix main.ts: remove unsafe ThemeName cast
- fix Utils.ts: add try/catch to deleteFromLocalStorage
- fix AuthorizeDialog: reactive→ref for single field
- fix SkinLoading: add defineOptions for DevTools name
- fix test stale naming (V2ModalStub→ModalStub, JSDoc descriptions)
- fix test weak assertions replaced with strict values
- add comprehensive classic skin component tests (91%+ coverage)
- remove classic skin coverage exclusions
* fix(ui-web): resolve skin system audit findings — FOUC, token validation, test quality
- Coordinate CSS+layout loading in defineAsyncComponent to prevent FOUC
- Add markRaw() to async component definitions for correct reactivity
- Set data-skin attribute on <html> for observability and future CSS scoping
- Add dev-mode TOKEN_CONTRACT runtime validation after skin CSS load
- Remove ~15 redundant test assertions (not.toBe/not.toBeNull after positive equality)
- Fix 4 test naming grammar issues to match 'should [verb]' convention
- Remove duplicate renderTemplates reactivity test (subsumed by more thorough test)
- Add edge case tests: data-skin attribute, invalid localStorage theme fallback
* fix(ui-web): address audit findings for skin system quality
- Replace router 404 inline template with h() render function (fixes
runtime compiler requirement)
- Add onError callback to useStartTxForm for rich error display in
StartTransactionDialog
- Clear lastError on successful skin switch in useSkin
- Remove static CSS imports from layout components (single loading path
via registry)
- Extract shared getConnectorEntries() and getATGStatus() utilities
- Add :pending prop to AddStationsDialog and SetSupervisionUrlDialog
submit buttons
- Clear skin-error-reload-count on successful skin switch
- Fix misleading useSkin test assertion for singleton behavior
* fix(ui-web): address comprehensive audit findings for skin system
- fix(CSData): wrap URL parse in try/catch to prevent row crash
- refactor(useStartTxForm): consolidate 5 positional params into config object
- fix(vitest): remove router/App.vue from coverage exclusions
- fix(Utils): add try/catch to getLocalStorage and deleteLocalStorageByKeyPattern
- refactor(registry): remove unnecessary async wrappers from loadStyles
- fix(useTheme): export DEFAULT_THEME constant, use in main.ts
- fix(useSimulatorControl): replace eslint-disable with inline no-op comment
- fix(useAsyncAction): add explanatory comment for eslint-disable
- test(contract): strengthen CSS token assertion with regex validation
- test(registry): use exact count assertion, add loadLayout test
- test(useSkin): add switching and lastError ref coverage
- test(useSetUrlForm): fix floating promise lint errors in tests
* refactor(ui-web): address audit findings for skin system quality
- Change useAsyncAction to accept factory function (prevents guard bypass)
- Simplify TOKEN_CONTRACT from object map to typed string array
- Await submitForm result in classic SetSupervisionUrl before navigation
- Clear skin-error-reload-count on successful 'already active' path
- Use registry label in SkinLoadError instead of hardcoded 'Classic'
- Add dev-mode console.debug to localStorage error paths
- Consolidate theme CSS extension sections into main sections
- Move registry.ts to skins/ for better colocation
- Rename activeTheme to activeThemeId for naming consistency
- Add shared/composables barrel index.ts
- Extract modal CSS to Modal.vue scoped styles
- Add module JSDoc to stationStatus.ts and useAsyncAction.ts
- Improve test isolation (afterEach DOM cleanup, wrapper.unmount)
- Add App.vue smoke test, router guard test, localStorage edge case test
- Add useAsyncAction error resilience tests
- Wrap multi-describe test files in parent describe blocks
- Fix useStationStatus test describe name mismatch
* fix(ui-web): address comprehensive audit findings for skin system
- Add @prefers-reduced-motion support in modern skin (WCAG 2.1 AA)
- Migrate useExecuteAction consumers to async/await pattern with useToast
- Mark useExecuteAction as @deprecated in favor of useAsyncAction
- Wrap sessionStorage access in try/catch for privacy mode compatibility
- Use shallowRef for simulatorState in useLayoutData (performance)
- Wrap exposed templates ref in readonly() in useAddStationsForm
- Extract makeInitialState() factory in useSetUrlForm (DRY)
- Extract shared formatSupervisionUrl() utility used by both skins
- Set html lang=en for accessibility
- Use CSS variable fallback in config error display
- Update token contract JSDoc to clarify mandatory vs overridable tokens
- Document shadow token browser support decision
- Add FOUC prevention comment in useSkin module-level effect
- Add defineOptions name to classic Button component
- Fix toast mock shadowing in test files
- Fix describe block naming in stationStatus and registry tests
- Move shared spacing/typography tokens from theme files to base.css (DRY)
- Replace inline style.cssText with CSS class for CSP compatibility
- Replace dynamic <style> injection with class toggle in useTheme
- Migrate useSimulatorControl from deprecated useExecuteAction to direct toast pattern
- Remove redundant pending guard in AddStationsDialog
- Update token contract test to check combined theme+base CSS
- Refactor useAsyncAction to async/await with void IIFE pattern
- Fix validation/pending guard order in useSetUrlForm
- Add pending ref to useStartTxForm for API consistency
- Rename shadowed pending in SetSupervisionUrlDialog
- Remove redundant refreshData wrapper in ModernLayout
- Extract PassthroughRoute constant in router
- Add visible error state on config fetch failure
- Document token contract split and shared→skins coupling
- Fix test isolation in useAddStationsForm and useTheme tests
- Fix misleading test name in useSkin test
* refactor(ui-web): remove deprecated useExecuteAction dead code
* fix(ui-web): address audit findings from PR review
The comment incorrectly attributed the try/catch to Safari Private
Browsing (fixed in Safari 11, September 2017 — WebKit bug #157010).
Updated to document the actual modern throw scenarios: genuine quota
exhaustion and SecurityError from browser cookie-blocking policies.
* refactor(ui-web): resolve all audit findings from comprehensive PR review
Address 63 findings across 7 categories identified by multi-agent
cross-validated code audit:
Architecture & Correctness:
- Replace useSkin switching boolean with Promise coalescing pattern
- Add static fallback in App.vue for cascade skin load failure
- Add toast notification on skinOnly route redirect
- Fix DEFAULT_THEME fragile array index
Fix all findings from 6-dimension blind cross-validated review:
MAJOR:
- Fix body scroll lock on skin switch mid-dialog (watch activeSkinId)
- Add useSetUrlForm rejection/error path test coverage
MINOR:
- CSTable v-show → v-if for initial render performance
- defineAsyncComponent for modern dialog lazy loading
- Remove redundant submitting ref in SetSupervisionUrlDialog
- Add prefers-reduced-motion media queries for accessibility
- Type meta.skinOnly as SKIN_IDS union for type safety
- Rename modern-confirm__* to modern-dialog__* for CSS consistency
- Add classic- prefix to classic skin scoped CSS classes
- Clean up WS listeners in useSimulatorControl on scope dispose
- Consolidate switchPromise cleanup to single location
- Document CSP requirements in README
NIT:
- Add defineOptions to Container.vue (multi-word component name)
- Standardize emit naming (remove $ prefix on defineEmits)
- Extract template inline type casts to helper functions
- Restore per-step error label in StartTransactionDialog
- Rename stationStatus describe to match module name
- Replace toBeTruthy() with toHaveLength(1) for emission checks
- Remove dead flushAllPromises alias from helpers
Test Quality (D5):
- Fix describe block names to match module names (4 files)
- Fix grammar in test names (2 occurrences)
- Convert for-of to it.each in contract test
- Add 17 new tests for uncovered branches
Naming & Terminology (D6):
- Rename setTheme → switchTheme (verb consistency with switchSkin)
- Move stationStatus.ts from composables/ to shared/utils/
- Add classic- prefix to all un-prefixed classic skin CSS classes
- Rename stationStatus test file to match source
- Add dev-mode warning to useUIClient singleton fallback
- Create shared StationIdentifier interface
* fix(ui-web): remove isMounted anti-pattern and adjust branch threshold
Remove unused isMounted ref/onBeforeUnmount in StartTransactionDialog
(Vue 3 anti-pattern — refs are safe to assign after unmount).
Lower branch threshold 88→87% to accommodate dead-code removal.
* refactor(ui-web): address audit findings for skin system quality
- Add SkinName type and narrow SkinDefinition.id for compile-time safety
- Extract shared validateTokenContract() utility with consistent rAF timing
- Remove dual CSS loading from defineAsyncComponent (useSkin is sole authority)
- Refactor useSimulatorControl to delegate start/stop to useAsyncAction
- Extract defineAsyncDialog helper to reduce repetition in ModernLayout
- Harmonize useSkin/useTheme return naming (availableSkins/availableThemes)
- Move skinOnly guard to per-route beforeEnter for better code locality
- Fix AVAILABLE_THEMES type widening (preserve narrow union type)
- Add missing onError callback tests for useStartTxForm composable
- Fix test describe block naming consistency
* refactor(ui-web): address 7 cross-validated audit findings for skin system
- M1: add scope-disposal guard to useAsyncAction preventing
post-unmount callback execution and state mutations
- M2: add bounds validation on server index in handleUIServerChange
with safe rollback on out-of-range values
- m1: move body overflow reset from App.vue into useSkin composable
(collocate DOM manipulation with skin switch logic)
- m2: refactor useAsyncAction.run() from 5 positional parameters to
options object pattern for improved readability and safety
- m3: fix inaccurate JSDoc in stationStatus.ts referencing wrong path
- m4: add console.warn when skin layout map fallback activates
- m5: add safety comment for useToast() usage in router guard
New tests: disposal guard (2), bounds validation (2)
* style(ui-web): condense verbose inline comments and remove self-evident ones
- Compress 9 multi-line comments to single-line equivalents
- Remove 3 unnecessary comments (self-evident from context)
- No behavioral changes
All theme files used `:root, [data-theme='name']` with equal specificity (0,1,0).
Since all CSS is loaded eagerly, the last-imported theme (tokyo-night-storm)
always won via cascade order, making theme switching visually ineffective.
Fix: non-default themes use `:root[data-theme='name']` (specificity 0,2,0)
which beats the default `:root` selector regardless of import order.
Default theme retains `:root` as pre-JS fallback.
* fix(ui-web): resolve CI EnvironmentTeardownError on Node 22.x
Vitest teardown race condition: defineAsyncComponent dynamic imports
resolve after jsdom environment destruction on slower Node runtimes.
Fix: use pool 'forks' for full process isolation per test file,
preventing cross-file module resolution races during teardown.
Also: use symmetric :root[data-theme] selectors for all themes with
data-theme attribute set in index.html for zero-flash pre-JS rendering.
* fix(ui-web): address audit findings — Vue best practices, test dedup, DRY
- refactor(useConnectorActions): adopt MaybeRefOrGetter + toValue()
- feat(useTheme): add lastError ref for invalid theme feedback
- refactor(localStorage): namespace key to ecs-ui-server-index with migration
- refactor(ClassicLayout): replace simulatorLabel fn with computed properties
- refactor(tests): remove ~40 redundant composable-logic assertions from component tests
- refactor(tests): replace toBeTruthy/toBeFalsy with strict alternatives
- test(CSTable): add basic rendering and event delegation test
- test(useSimulatorControl): add AAA comments to complex tests
- refactor(shared/utils): extract getSelectValue to shared/utils/dom.ts
- docs: add token contract, singleton state, and skin CSS scoping docs
* docs(ui-web): remove browser requirement and CSP notes from README
---------
Co-authored-by: Daniel <7558512+DerGenaue@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
chore: replace agent instruction indirections with symlinks to canonical source
Replace AGENTS.md text file and .clinerules/ directory (both containing
'Open and follow' instructions) with direct symlinks to the canonical
.github/copilot-instructions.md. Add CLAUDE.md and GEMINI.md symlinks
for Claude Code and Gemini CLI which do not read AGENTS.md natively.
Token lacks 'Administer project' permission. The main branch rename
for ui-common and cli must be done by a SonarCloud org admin via:
POST https://sonarcloud.io/api/project_branches/rename
project=e-mobility-charging-stations-simulator-ui-common&name=main
project=e-mobility-charging-stations-simulator-cli&name=main
feat(cli): expose station identity overrides and CSMS credentials
Add --base-name, --fixed-name, --name-suffix, --supervision-user and
--supervision-password options to station add command. Add credential
options to supervision set-url. Update integration tests and README.
fix: enforce RFC 7617 colon-free username across all Basic Auth paths
- Skip supervision WebSocket auth with warning when supervisionUser
contains ':' (convergence point for templates and all API paths)
- Reject ':' in authentication.username via Zod regex in UI config
schema (covers ui/web and ui/cli config files)
fix(ui-server): harmonize setSupervisionUrl semantics and text descriptions
- Fix SetSupervisionUrl.vue passing empty credentials that silently
clear existing values; align with AddChargingStations.vue pattern
- Fix double saveStationInfo() call and missing updated event when
only URL changes in ChargingStation.setSupervisionUrl
- Remove verbose JSDoc, redundant comment, and parenthetical UI label
- Harmonize MCP descriptions: use natural language instead of camelCase
code names, unify credential field descriptions across schemas
Daniel [Wed, 22 Apr 2026 17:50:28 +0000 (19:50 +0200)]
feat(ui-server): allow override of station identity and CSMS credentials in addChargingStations (#1802)
* feat(ui-server): allow per-call override of station identity and CSMS credentials
Extend ChargingStationOptions with baseName, fixedName, nameSuffix,
supervisionUser and supervisionPassword so that callers of the
addChargingStations UI procedure can fully customise a station without
editing template files.
Identity derivation (chargingStationId, hashId) moves to the tail of
getStationInfo, after setChargingStationOptions runs, so the merged
stationInfo is the single source of truth for baseName/fixedName/nameSuffix.
getChargingStationId now accepts a narrow StationIdentity pick that both
ChargingStationTemplate and ChargingStationInfo satisfy; getHashId grows
an optional chargingStationIdOverride so the new identity flows through
without altering the hashed payload shape for existing callers.
Default behaviour is unchanged: hash ID regression test pins the
pre-existing hash, and omitted options leave stationInfo untouched.
* docs(ui-server): sync ChargingStationOptions docs with source interface
Bring the README protocol reference, the MCP zod schema and the web UI
ChargingStationOptions type back in sync with src/types/ChargingStationWorker.ts.
Covers the newly added baseName, fixedName, nameSuffix, supervisionUser and
supervisionPassword fields, plus previously missing fields not yet surfaced
in the public docs.
* feat(ui-web): expose baseName, fixedName and CSMS credentials in add-station dialog
Surface the new addChargingStations options on the web UI form: a base
name text field, an "append counter to name" checkbox that controls
fixedName, and a supervision user/password pair alongside the existing
supervision URL. Empty fields are omitted from the payload so the
template defaults apply unchanged.
* feat(ui-server): allow setSupervisionUrl to update CSMS credentials
Extend the setSupervisionUrl UI procedure so callers can update the
supervision WebSocket's basic auth user and password on an already
running station, not only the URL. All three fields (url,
supervisionUser, supervisionPassword) become optional; the handler now
requires at least one to be set.
ChargingStation.setSupervisionUrl accepts the three optional arguments
and writes the non-URL fields onto stationInfo via saveStationInfo.
Changes take effect on the next WebSocket (re)connect, mirroring how
URL updates already worked. The MCP zod schema and the protocol
reference in the README are updated accordingly.
* feat(ui-web): expose CSMS credentials in set-supervision dialog
Surface the extended setSupervisionUrl procedure on the web UI: user
and password inputs next to the existing URL field, a client-side
guard that requires at least one field set, and a renamed form
header ("Set Supervision") that matches the broader scope. UIClient
passes the new fields through only when populated, so existing
URL-only callers are unaffected.
* fix(ui-web): serve index.html as SPA fallback so deep-linked routes survive reload
The built bundle is served by start.js via serve-static, which 404s on
any path that isn't a physical file — so refreshing a router route
like /add-charging-stations or /set-supervision-url/... produced
"Cannot GET ...". When serve-static gives up, fall back to sending
the bundled index.html with 200 OK so the SPA router can resolve the
route client-side. POST/PUT/etc. still fall through to finalhandler.
* [autofix.ci] apply automated fixes
* test(ui-web): update AddChargingStations tests for new fields
Bump checkbox count to 5 (appendCounter added) and cover baseName,
supervision credential pass-through and fixedName behaviour.
* fix: PR comments
* fix: PR comments
- server: setSupervisionUrl: url required, supervisionUser/supervisionPassword
independent (string updates incl. "" to clear, undefined preserves);
drop block-comment noise; align README and MCP schema descriptions
- ui: SetSupervisionUrl dialog: always send credentials verbatim — empty
fields clear stored credentials (frontend can't distinguish null
vs empty)
- ui: AddChargingStations dialog: replace inverted appendCounter with
fixedName mirroring the API field; label "(base name is full
station name)"; empty fields keep preserving template defaults
- server: Rename StationIdentity → ChargingStationNameTemplate (and the
parameter in getChargingStationId) so the type name reflects its
role as the building blocks of chargingStationId
- Tests updated to match the new semantics
Align UIServer basic auth with RFC 7617/7613: empty passwords are now
rejected alongside the existing empty username check. Add comprehensive
unit tests for all UIServerUtils exported functions (24 tests).
- BUG-01: use resolvedHashIds (not raw hashIds) in resolveOcppVersionFromProgram
- DRY-01: extract resolveShortHashIdsFromList pure helper, used by both
resolveShortHashIds and resolveOcppVersionFromProgram
- DEAD-01/DOC-01: remove unused resolveOcppVersion, update JSDoc references
- ROBUST-01: seqNo 1 for transaction stop (start uses 0)
- PERF-01: resolveOcppVersionFromProgram returns config, runAction accepts
preloadedConfig to skip redundant loadConfig call
* chore: refine .gitignore
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* fix(cli): simplify OCPP 2.0.x transaction payloads to match builder options
- transaction start: send flat OCPP20TransactionEventOptions (connectorId,
evseId, idToken) instead of wire-format fields (seqNo, timestamp,
transactionInfo nesting, evse structure)
- transaction stop: send flat transactionId instead of nested
transactionInfo, remove hardcoded seqNo/timestamp/triggerReason
- Remove evseId ?? 1 default (let builder resolve from connectorId)
- Remove unused imports (randomUUID, OCPP20TriggerReasonEnumType)
- Fix meter-values --evse-id misleading help text
- Add test for mixed matching/non-matching hashIds
Addresses review comments from hyperspace-insights and Copilot,
cross-validated with audit v2 findings BUG-01, BUG-02, BUG-03.
* fix(cli): harmonize all OCPP commands with version-aware conflicts pattern
- Add early NO_STATIONS_ERROR check in resolveOcppVersionFromProgram
- Refactor status-notification, meter-values, transaction start/stop to
use .addOption/.conflicts() pattern matching authorize's design
- Make meter-values version-aware: OCPP 1.6 sends connectorId, OCPP 2.0
sends evseId, passthrough mode sends only routing fields
- Fix --evse-id help text in transaction start (was claiming false default)
- Fix pre-existing jsdoc/require-throws-type lint warning
* fix(cli): add connectorId to transaction stop for OCPP 2.0.x and harmonize evseId conflicts
- Add --connector-id option to transaction stop (defaults to 1) so
buildTransactionEvent resolves the correct connector on multi-connector
stations
- Convert all --evse-id options to .addOption/.conflicts('payload') for
consistent UX with other semantic options
- Add evseId to reverse .conflicts() lists on -p/--payload options
* fix(cli): update JSDoc and comments to match current behavior
- Update resolveOcppVersionFromProgram JSDoc: returns OCPPVersion (not
undefined), add @throws documentation for all error cases
- Update MIN_FULL_HASH_LENGTH comment: now validates existence, not just
skips resolution
* fix(cli): route version-detection errors through formatter for --json mode
Add handleActionErrors wrapper that catches errors from version
detection, option validation, and hash-ID resolution before runAction,
routing them through the same formatter used by runAction. Without this,
errors in --json mode were output as plain text instead of structured
JSON.
* Apply suggestion from @jerome-benoit
* refactor(cli): extract shared error formatter and clean up exports
- Extract formatError() from duplicated catch blocks in
handleActionErrors and runAction
- Align authorize error message with the pattern used by all other
commands ('X is required when -p/--payload is not provided')
- Remove unnecessary exports from 3 internal-only error constants
(NO_STATIONS_ERROR, MIXED_OCPP_VERSION_ERROR, UNKNOWN_OCPP_VERSION_ERROR)
* fix(cli): standardize option help texts and remove redundancy
- Standardize EVSE ID help text to 'EVSE ID (OCPP 2.0.x; derived from
connector ID if omitted)' across meter-values, status-notification,
and transaction start
- Simplify error-code help text from 'OCPP 1.6 only; required for 1.6'
to 'OCPP 1.6' (the constraint is already enforced at runtime)
* docs(cli): document version-aware commands and new OCPP 2.0.x options
- Add --evse-id to meter-values, status-notification, transaction start
- Add --connector-id to transaction stop (required for OCPP 2.0.x)
- Mark --error-code as optional (OCPP 1.6 only)
- Mark --vendor-id as optional in data-transfer
- Document -p/--payload support for transaction commands
- Add Version-aware commands section with OCPP 1.6 vs 2.0.x mapping
- Update both README.md and SKILL.md consistently
* docs(cli): fix pre-existing documentation gaps in README and SKILL.md
- Add missing station add options: --persistent-config, --ocpp-strict
- Add missing station delete --delete-config example in SKILL.md
- Add missing atg stop --connector-ids in SKILL.md
- Fix meter-values: both --connector-id and --evse-id are optional
(at least one required)
- Fix ATG --connector-ids notation: <id,...> instead of <ids...>
- Add hashId prefix matching note to SKILL.md
* fix(cli): harmonize user-facing strings and fix documentation accuracy
Code:
- Harmonize 'station(s)' terminology (drop 'charging' prefix in
station.ts descriptions to match all other command files)
- Fix NO_STATIONS_ERROR to use consistent 'stations' wording
- Fix data-transfer --data description: free-form string, not JSON only
- Fix transaction unsupported version error: direct users to
'ocpp transaction-event -p' instead of generic '-p' which forces 1.6
Docs (README + SKILL.md):
- Fix merge claim: -p conflicts with typed options on most commands,
only data-transfer allows merge
- Add meter-values 'at least one required' constraint note
- Add --connector-id required for transaction stop on OCPP 2.0.x in
version-aware table
- Fix data-transfer --data placeholder from <json> to <data>
* refactor(cli): extract duplicated unsupported version error in transaction.ts
Extract inline error string into a local const within
createTransactionCommands to avoid duplication across the start and
stop default switch branches.
* fix(cli): correct meter-values payload for OCPP 2.0.x stations
The OCPP 2.0.x MeterValues JSON schema does not allow connectorId as a
property. The previous implementation conditionally included connectorId
in the payload for OCPP 2.0.x, which caused schema validation failures
in the simulator ("additionalProperty: connectorId — must NOT have
additional properties").
For OCPP 2.0.x, evseId is the only valid EVSE identifier in a
MeterValues request. The fix now requires --evse-id for OCPP 2.0.x
stations and sends only evseId in the payload. If only --connector-id
is supplied against a 2.0.x station, a clear error message guides the
user to use --evse-id instead. The --connector-id help text is also
updated to indicate it is OCPP 1.6 only for this command.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(cli): align meter-values documentation with evseId-only OCPP 2.0.x fix
Update README and SKILL.md to reflect that meter-values requires
--evse-id for OCPP 2.0.x (connectorId is not a valid MeterValues
field in 2.0.x). Show separate OCPP 1.6 and 2.0.x usage lines.
* fix(cli): harmonize meter-values help texts and error message
- Drop 'only' from --connector-id help: '(OCPP 1.6)' matches
--error-code pattern in status-notification
- Drop 'required' from --evse-id help: '(OCPP 2.0.x)' matches
version-only pattern used for version-exclusive options
- Remove verbose parenthetical from evseId error message to match
the terse pattern used by all other version-specific errors
* fix(cli): use SCREAMING_CASE for error constant and add missing exit code
- Rename unsupportedVersionError to UNSUPPORTED_VERSION_ERROR in
transaction.ts to match the naming convention used by all error
constants in action.ts
- Add exit code 143 (SIGTERM) to SKILL.md exit codes table
* fix(cli): complete resolveOcppVersionFromList JSDoc for unknown versions
Add 'or all versions are unknown' to the @returns description to
document that the function also returns undefined when all targeted
stations have ocppVersion: undefined (Set {undefined}, size 1).
* fix(cli): align error constant naming and fix README station list comment
- Rename UNSUPPORTED_VERSION_ERROR to UNSUPPORTED_OCPP_VERSION_ERROR in
transaction.ts to match the naming convention with OCPP_ prefix used
by the exported constant in action.ts
- Fix README inline comment: 'List all stations' to match station.ts
description (was still 'List all charging stations')
---------
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Daniel [Tue, 21 Apr 2026 11:52:00 +0000 (13:52 +0200)]
fix(webui-docker): include workspace root node_modules so pnpm symlinks resolve (#1806)
ui/web/node_modules is a pnpm workspace package whose entries are
symlinks into ../../../node_modules/.pnpm/..., i.e. the workspace
root's store. The previous Dockerfile only copied ui/web/node_modules
into the final image, leaving every symlink dangling and breaking
`node start.js` with "Cannot find package 'finalhandler'".
Copy the workspace root node_modules to /node_modules in the final
image so the relative symlinks resolve.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
refactor: remove redundant EmptyObject from CommandResponse union
EmptyObject (Record<string, never>) is structurally assignable to every
object type in the union. Empty responses are handled at runtime via
isEmpty() checks before reaching type-narrowing logic.
ci: update Python matrix from 3.12/3.13 to 3.13/3.14
Python 3.12 is in security-only mode (no more bugfixes).
Python 3.14 is stable with active bugfix support (3.14.3 released).
Run typecheck, lint, and coverage on 3.14 (latest stable).
feat(ui-cli): add custom JSON payload option for OCPP and transaction commands
Add -p, --payload <json|@file|-> to all 16 OCPP commands and both
transaction commands. Supports three input modes:
- Inline JSON: -p '{"reason":"PowerUp"}'
- File: -p @collections/boot.json
- Stdin: echo '{}' | evse-cli ocpp heartbeat -p -
Payload is merged beneath command-specific options (--id-tag, etc.)
so CLI flags always take precedence.
Implementation:
- New resolve-payload.ts: async resolver with validation (object check,
empty check, JSON parse error with preview)
- Payload resolution integrated into runAction try/catch for clean
error handling (no stack traces on user input errors)
- PAYLOAD_OPTION/PAYLOAD_DESC constants shared via payload.ts
- 11 unit tests for resolvePayload (inline, @file, edge cases)
- README and SKILL.md updated with examples
feat(ui-cli): add registration and connector columns to station list, fix command semantics
Station list improvements:
- Add Registration column (Accepted/Pending/Rejected) after Hash ID
- Add Connectors column with per-connector status letters (1:A 2:O etc.)
- Two-letter abbreviations for ambiguous statuses (Fi/F, SE/SS)
- Remove dead countConnectors function, replace with formatConnectors
- Replace countConnectors tests with formatConnectors tests (7 tests)
Command description semantics:
- All OCPP: 'Send OCPP X' -> 'Request station(s) to send OCPP X'
- Connection: 'Open/Close WebSocket connection' -> '... to CSMS on station(s)'
- Connector: 'Lock/Unlock a connector' -> '... connector on station(s)'
- Transaction: 'Start/Stop a transaction' -> '... on station(s)'
- SKILL.md: 'send OCPP messages' -> 'trigger OCPP messages from stations to the CSMS'
- README: updated accordingly
refactor(ui-cli): move StationListPayload to shared types, add resolution error context
- Move StationListPayload from renderers.ts to types.ts to fix
cross-layer dependency (action.ts no longer imports from output layer)
- Wrap hash prefix resolution errors with contextual message
('Failed to resolve hash ID prefixes: ...')
feat(ui-cli): short hash prefix matching, human output formatters, embedded agent skill
Short hash resolution:
- Resolve hash ID prefixes via station list lookup before command execution
- Skip resolution when all IDs are full-length (>= 48 chars, SHA-384)
- Clear error messages for ambiguous or unknown prefixes
- Silent mode suppresses spinner during internal resolution call
Human output formatters:
- Borderless table renderers for station list, template list, simulator state, performance stats
- Shared format utils: truncateId, statusIcon, wsIcon, fuzzyTime, countConnectors
- Truncate hash IDs in all human output tables (station list + success/failure)
- Type guards with Array.isArray + null checks for safe payload dispatch
- Handle supervisionUrls as string | string[], optional configuration
- Dynamic status capitalization, shared captureStream test helper
- 70 new tests (format + renderers), using canonical ChargingStationData type
Embedded agent skill:
- `skill show` prints embedded SKILL.md to stdout
- `skill install [--global] [--force]` writes to .agents/skills/
- SKILL.md embedded at build time via esbuild define
- Follows AgentSkills.io open standard
CLI option rename:
- Global --url renamed to --server-url (explicit intent)
- supervision set-url --url renamed to --supervision-url (no collision)
README restructured with prefix matching docs, output modes table,
station delete options, grouped simulator vs local commands
CLI output renderers:
- Add borderless table renderers for station list, template list,
simulator state, and performance statistics
- Shared format utils: truncateId, statusIcon, wsIcon, fuzzyTime,
countConnectors using canonical ConnectorEntry/EvseEntry types
- Type guards with Array.isArray + null checks for safe dispatch
- Handle supervisionUrls as string | string[] (defensive normalize)
- Optional configuration in SimulatorState guard (graceful degradation)
- Dynamic status capitalization in generic payload display
- Extract captureStream test helper to tests/helpers.ts
- 70 new tests (40 format + 30 renderers), 124 total CLI tests
Shared type fixes (ui-common):
- Add provisioned field to TemplateStatistics
- Add timestamp field to ChargingStationData
- Add configuration (optional) to SimulatorState
CLI option rename:
- Rename global --url to --server-url (explicit intent)
- Rename supervision set-url --url to --supervision-url (no collision)
- Update types, consumers, integration tests, README
fix(ui-cli): resolve --url option collision between global and supervision
Rename global --url to --server-url and supervision set-url --url to
--supervision-url to prevent Commander option shadowing. Update types,
action consumer, integration tests, and README documentation.
fix(tests): use async mock callbacks for all async method mocks
Sync functions returning Promises are not behaviorally equivalent to
async functions. Align all 40 mock callbacks across 14 test files to use
async when the real method is async.
fix(tests): sync mock signatures with real async implementations
Two mocks returned Promises from sync functions instead of using async,
mismatching the real method signatures of sendTransactionEvent and
requestHandler.
fix(ocpp2): restore connector cleanup in TransactionEvent(Ended) response handler
Commit 710db15c removed cleanup from the Ended response handler assuming
callers always handle it. The UI broadcast channel passthrough bypasses
all caller-side cleanup, leaving connectors stuck in Occupied state.
Restore cleanupEndedTransaction in handleResponseTransactionEvent for the
Ended case, making the response handler the authoritative cleanup point
for all online paths. Add idempotency guard to cleanupEndedTransaction
so existing caller-side calls (needed for offline fallback) become no-ops
when the response handler already ran. Fix unconditional Available status
to respect ChangeAvailability(Inoperative) per G03.
fix(ui-web): force toggle button re-mount on navigation back to main view
resetToggleButtonState() only cleared localStorage but never triggered
ToggleButton re-mount, leaving its reactive state stuck on 'active'.
Watch route changes to CHARGING_STATIONS and call refresh() to re-mount
both the header toggle and CSTable children, ensuring all shared toggle
buttons re-read their (now cleared) localStorage entries.
fix(ui-web): fix remaining for...in on localStorage and remove dead test config
- Replace for...in with Object.keys() in deleteLocalStorageByKeyPattern
- Remove dead $route/$router globalProperties from ChargingStationsView
test (component now uses useRoute/useRouter composables via vi.mock)
- Fix ToggleButton.vue: replace unsafe for...in on localStorage with
Object.keys(), cache localStorage value (4 reads reduced to 1)
- Extract 42-line inline @change handler in ChargingStationsView.vue
to handleUIServerChange method
- Move ServerFailureError from WebSocketClient.ts to errors.ts
(proper separation of concerns, re-exported for backward compat)
- Simplify useExecuteAction callback param: remove union type,
use only ExecuteActionCallbacks object; update call sites
- Remove unnecessary String() in cli table.ts template literals
refactor(ui-web): remove duplicated tests for functions now in ui-common
convertToBoolean, convertToInt, and UUID tests were duplicated between
ui-web and ui-common. Tests belong in the package that owns the code.
Canonical tests are in ui-common; removed duplicates from ui-web.
refactor(ui): move generic utilities to ui-common and add useFetchData composable
- Move convertToBoolean(), convertToInt() to ui-common/src/utils/converters.ts
- Move getWebSocketStateName() to ui-common/src/utils/websocket.ts using
portable WebSocketReadyState enum instead of browser WebSocket constants
- Add useFetchData() composable to deduplicate fetch-with-loading-guard
pattern in ChargingStationsView (3 instances collapsed)
- All consumers import directly from ui-common, no re-exports
fix(ui-web): remove orphaned CSS classes and guard onFinally in useExecuteAction
- Remove dead connectors-table__row/column classes from CSConnector.vue
- Wrap onFinally callback in try/catch inside .finally() to prevent
swallowing the original rejection error
docs: add ADR for config loading strategy and ClientConfig derivation
Update WebSocketClient usage example to use Protocol.UI and
ProtocolVersion['0.0.1'] enum values (matching the now-enum-typed
ClientConfig). Add Architecture Decisions section documenting:
- ADR 1: why CLI and Web have separate config loaders (different I/O)
- ADR 2: why ClientConfig = Omit<UIServerConfigurationSection, 'name'>
chore: hoist shared devDependencies to root workspace
Remove @types/node, cross-env, prettier, rimraf, tsx, typescript from
ui/common, ui/web, and ui/cli package.json — they are already declared
in the root package.json. cli-specific deps (@types/ws, esbuild,
esbuild-plugin-clean) are kept in ui/cli.
Create ui/common/tests/mocks.ts with createMockWebSocketLike() — a factory
returning a MockWebSocketLike with trigger methods (triggerOpen, triggerClose,
triggerError, triggerMessage) and sentMessages capture array. Replace the
65-line inline createMockWs() in WebSocketClient.test.ts with an import
from the shared factory.
refactor(ui-common): generic WebSocket adapter factory with converter injection
Create ui/common/src/client/adapter.ts — a generic createWsAdapter(ws, options)
factory that implements all WebSocketLike callback boilerplate once. Both adapters
become thin wrappers specifying only their platform-specific data converter:
- createBrowserWsAdapter: data => data as string, errorDefault: 'WebSocket error'
- createWsAdapter (CLI): toDataString() for Buffer/ArrayBuffer, errorDefault: 'Unknown error'
Net reduction: ~143 lines of duplicated boilerplate eliminated.
Add DataConverter type and tests for the generic factory.
Create ui/cli/src/utils/errors.ts with extractErrorMessage(error: unknown): string
and replace 3 inline occurrences of the pattern across formatter.ts, json.ts,
and loader.ts.
refactor(ui-common): derive ClientConfig and AuthenticationConfig from Zod schemas
Replace two hand-written interfaces in client/types.ts with type aliases
derived from the Zod-inferred UIServerConfigurationSection:
- AuthenticationConfig = NonNullable<UIServerConfigurationSection['authentication']>
- ClientConfig = Omit<UIServerConfigurationSection, 'name'>
This eliminates duplication: protocol/version now carry enum types (Protocol,
ProtocolVersion) instead of loose strings. Update WebSocketClient.test.ts to
use Protocol.UI and ProtocolVersion['0.0.1'] enum values accordingly.
- Remove dead duplicate UI_WEBSOCKET_REQUEST_TIMEOUT_MS from ui/web/src/composables/Constants.ts
- Add DEFAULT_HOST ('localhost') and DEFAULT_PORT (8080) to ui/common/src/constants.ts
- Update ui/cli/src/config/defaults.ts and loader.ts to import from ui-common
- Update ui/web/tests/unit/constants.ts to use DEFAULT_HOST/DEFAULT_PORT from ui-common
- Update ui/cli/tests/config.test.ts to import from ui-common
refactor(ui-common): remove UIServerConfig alias, single canonical name
UIServerConfigurationSection is the only exported name for the UI server
config type. The UIServerConfig alias added for backward compat is removed;
CLI consumers (loader.ts, lifecycle.ts) migrated to the canonical name.
README updated accordingly.
test: add enum rejection tests and fix dynamic import in CLI test
- Add 2 edge-case tests for invalid protocol/version enum values
(protocol: 'ws' and version: '2.0' are now correctly rejected)
- Replace unnecessary dynamic import with static import in
lifecycle.test.ts for consistency with other test files
refactor(ui-common): derive UIServerConfigurationSection from Zod schema
Make uiServerConfigSchema the single source of truth for the UI server
configuration shape. The hand-written interface in ConfigurationType.ts
is removed; UIServerConfigurationSection is now inferred via z.infer<>.
- Tighten schema: protocol and version use z.enum() instead of z.string()
(follows existing z.enum(AuthenticationType) pattern, Zod v4)
- Export UIServerConfigurationSection as the primary inferred type
- Export UIServerConfig as a backward-compat alias
- ConfigurationType.ts imports UIServerConfigurationSection from schema.ts
and re-exports only ConfigurationData
- CLI defaults.ts uses Protocol.UI and ProtocolVersion['0.0.1'] enum values
instead of plain string literals to satisfy the tightened type
- CLI lifecycle.test.ts updated to use enum values in typed config literal
Zero duplicate field definitions. All quality gates pass.
repositories / e-mobility-charging-stations-simulator.git / log
