Cleanup (#239)

Untangle pool abstract class from worker strategy selection (#234)

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Create SECURITY.md

Bump typescript from 4.1.5 to 4.2.2 (#235)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.5 to 4.2.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](https://github.com/Microsoft/TypeScript/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Threadjs benchmarks (#230)

* Add threadjs to our benchmarks and re-run

* documentation

* Center support button

* Center support button

* Center support button

Use the current node.js LTS version for publication. (#228)

Bump eslint-plugin-jsdoc from 32.1.1 to 32.2.0 (#229)

Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 32.1.1 to 32.2.0.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v32.1.1...v32.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Alessandro Pio Ardizio <alessandroardizio94@gmail.com>

Coverage increased (#226)

* Coverage increased

* Few changes

Co-authored-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

Bump rollup from 2.39.0 to 2.39.1 (#224)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

Bump eslint-plugin-jsdoc from 32.1.0 to 32.1.1 (#223)

Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 32.1.0 to 32.1.1.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v32.1.0...v32.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Cleanups on bechmarking and strategies code: (#227)

+ Factor out common code
+ Renaming
+ Add benchmarking on strategies
+ Add microtime to improve benchmark time resolution

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Removed max tasks (#225)

* Removed max tasks

* Coverage on abstract pool default

* Remove default option from the abstract pool since the default is already specified in any child class

* Fix missing default opts

* Few small changes

* Remove default from abstract pool constructor JSDoc

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Improve worker selection strategies coverage. (#220)

* Improve worker selection strategies coverage.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Dedupe packages.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Bump @typescript-eslint/eslint-plugin from 4.15.1 to 4.15.2 (#221)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.15.1 to 4.15.2.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.15.2/packages/eslint-plugin)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Bump @typescript-eslint/parser from 4.15.1 to 4.15.2 (#219)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.15.1 to 4.15.2.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.15.2/packages/parser)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Check that a pool have a minimum number of workers (#213)

* Check that a pool have at least one worker,

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Specify return type on checkNumberOfWorkers

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Fix dynamic pool handling and add unit tests.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Add more sanity checks to numberOfWorkers.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Increase branches coverage.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Renable skipped test on cluster worker.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Remove wrong comment.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Try to increase coverage by alternating fixed pool type.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Address review comments.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Sync package-lock.json

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Remove debug log.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Fix tests (#218)

* Fix the unit test for the number of workers.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Cleanups.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Co-authored-by: Shinigami <chrissi92@hotmail.de>

New bench execution and sleep between a test and another

Doc enhancement

Doc enhancement

Doc enhancement

Doc enhancement

Doc enhancement

Enhancement on main readme

Additional details on benchmarks

Improvement on benchmarks

Bump to beta 7 version

Coverage increased (#217)

Benchmarks and performance enhancements (#209)

* Benchmarks and performance enhancements

* Removed general Function type

* Remove unknownn work around

* Clean

* Clean up old benchs, exclude benchmark folder from eslint

* Clean up

* Revert "Clean up"

This reverts commit 31271d7f75392f04490a135a86b07e9480375505.

* Revert "Clean up old benchs, exclude benchmark folder from eslint"

This reverts commit 9467624c5713768cd44a545a48454a836d1af1b4.

* Clean up for real

* Clean up and dts for benchmarks

* Run npm lint

* Clean up benchmark eslint warnings and errors

* Exclude no missing require in some bench files

* Exclude no missing require in some bench files

* Remove sonar code smells

* Don't be overjoyed in readme

* Improve interface definition

* Use published poolifier

* Rename

* Ignore lint for benchmarks/versus-external-pools

* Remove eslint-disable from benchmark files

* Enhancement performance is now applied to both cluster and thread pools

* Improve documentation

* Unregister worker listener is no more needed

* Update README.md

* Improve readme

* Add content to readme

* Update benchmarks/README.md

Co-authored-by: Shinigami92 <chrissi92@hotmail.de>

Ensure we always clean up resources in ut. (#214)

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Extract selection strategies to classes (#176)

Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Co-authored-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

Bump eslint-plugin-jsdoc from 32.0.2 to 32.1.0 (#212)

Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 32.0.2 to 32.1.0.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v32.0.2...v32.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Only analyse code on main workflow (#208)

Publish betas with beta tag (#204)

Configure dependabot (#207)

Document the breaking change merge of pool options types declaration (#205)

Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Alessandro Pio Ardizio <alessandroardizio94@gmail.com>

Update dependencies. (#206)

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Update package.json

Properly name and separate each steps at publication. (#199)

JSONValue can not be used by custom defined interfaces (#201)

Co-authored-by: Shinigami92 <chrissi92@hotmail.de>

Fix usage of prepublishOnly (#202)

Co-authored-by: Jérôme Benoit <jerome.benoit@sap.com>

Fix logo squashing (#203)

Use 34% image size

Merge pull request #200 from pioardi/deps

Update dependencies to latest.

Update dependencies to latest.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Take change from jerome

Merge branch 'master' of https://github.com/pioardi/node-pool

Merge pull request #193 from pioardi/deps

Update dependencies

Add publish step into one job

Update dependencies

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Update package.json

CI: always lint after build. (#192)

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Update package.json

Merge pull request #189 from pioardi/ut

Use a configuration file for mocha ut

Use a configuration file for mocha ut

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Fix EPIPE when run unit tests (#187)

* Try to remove the --exit

* Revert "Fix EPIPE on shutdown"

This reverts commit 4dc274761ce688172117009d1b306077d321f461.

* Graceful shutdown during unit tests

* Readd exit since that was not the solution

* Capital letters on comments

* Destroy all pools in after (#188)

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Fix EPIPE on shutdown

Merge pull request #186 from pioardi/documentation

README.md: Small refinements

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Make the documentation less worker-threads centric. (#183)

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Fix sonar code smells (#184)

* Fix sonar code smells

* Add coverage thresholds

* Coverage thresholds

* Update src/pools/abstract-pool.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>
* Update src/pools/abstract-pool.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>
* Update src/worker/abstract-worker.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>
* Update src/worker/abstract-worker.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>

Factor out worker tasks number in/de-crement. (#182)

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Issue 160 ci unit test (#181)

* Fix issue 160

* Keep comments

* Keep comments

Update CHANGELOG.md (#178)

Update CHANGELOG.md

Tests enhancement (#172)

* Increase coverage and remove deprecated methods

* Add utility test function instead of use setTimeout to wait workers scale down

* Decrease a little bit the required nyc percentages

* Add a TestUtils class.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* More sleep usage.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Run npm format.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
* Remove deprecated methods and update changelog, increase require coverage

* Check coverage change

Co-authored-by: Jérôme Benoit <jerome.benoit@sap.com>

Improve jsdoc comments (#175)

* Improve jsdoc comments

* Update eslint-plugin-jsdoc

Fix JSDoc (#171)

Merge pull request #153 from pioardi/add-worker-test

Add tests for workers

Merge branch 'master' into add-worker-test

Document new kill behavior on the readme (#170)

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Merge branch 'master' into add-worker-test

Merge pull request #161 from pioardi/issue-70

Better handling for maxInactiveTime on dynamic pools

Improvements for #161 (#169)

Add test cases and fixed some sonar code smells

Change killBehaviorEnumeration to killBehaviorTypes

Increased test timeouts, we need to look into that as soon as we can

Linting

TODO for shinigami

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/abstract-worker.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/utility-types.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Update src/worker/worker-options.ts

Co-authored-by: Shinigami <chrissi92@hotmail.de>

Merge branch 'master' into issue-70

Enhance changelog documentation

Implementation for killBehavior based on the last feedbacks

Update dependencies (#168)

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Merge pull request #164 from pioardi/benchmark

Fix benchmarks run: use synchronous call.

Fix benchmarks run: use synchronous call.

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Merge branch 'master' into issue-70

Merge pull request #163 from pioardi/ci

CI: Bump GitHub actions version to v2

CI: Bump GitHub actions version to v2

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

README.md: formatting fixes. (#162)

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

Fix typing error

Add a blank line

Implement PR reviews