From 768c0780fd2fbd9c3f382c27f73ca267a5fe1fe6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Fri, 10 Feb 2023 17:10:55 +0100 Subject: [PATCH] Refactor generateRandomFloat() helper MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- benchmark-utils.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/benchmark-utils.js b/benchmark-utils.js index e39708b..c123243 100644 --- a/benchmark-utils.js +++ b/benchmark-utils.js @@ -39,16 +39,16 @@ function generateRandomInteger (max = Number.MAX_SAFE_INTEGER, min = 0) { * * @param max * @param min - * @param negative * @returns */ -function generateRandomFloat (max = Number.MAX_VALUE, min = 0, negative = true) { - if (max < min || max < 0 || min < 0) { +function generateRandomFloat (max = Number.MAX_VALUE, min = 0) { + if (max < min) { + throw new RangeError('Invalid interval') + } + if (max - min === Infinity) { throw new RangeError('Invalid interval') } - const randomPositiveFloat = crypto.randomBytes(4).readUInt32LE() / 0xffffffff - const sign = negative && randomPositiveFloat < 0.5 ? -1 : 1 - return sign * (randomPositiveFloat * (max - min) + min) + return (crypto.randomBytes(4).readUInt32LE() / 0xffffffff) * (max - min) + min } /** -- 2.34.1