From d476bc1be87bb63cfd8c494ce1ed41204992806f Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@sap.com>
Date: Tue, 25 Jul 2023 16:35:03 +0200
Subject: [PATCH] refactor: add sanity check on recurring charging profile
 duration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---
 src/charging-station/ChargingStationUtils.ts | 24 ++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/src/charging-station/ChargingStationUtils.ts b/src/charging-station/ChargingStationUtils.ts
index 9da406c2..0d349d22 100644
--- a/src/charging-station/ChargingStationUtils.ts
+++ b/src/charging-station/ChargingStationUtils.ts
@@ -9,6 +9,7 @@ import {
   addSeconds,
   addWeeks,
   differenceInDays,
+  differenceInSeconds,
   differenceInWeeks,
   isAfter,
   isBefore,
@@ -810,6 +811,7 @@ const prepareRecurringChargingProfile = (
         start: chargingSchedule.startSchedule!,
         end: addDays(chargingSchedule.startSchedule!, 1),
       };
+      checkRecurringChargingProfileDuration(chargingProfile, recurringInterval, logPrefix);
       if (
         !isWithinInterval(currentDate, recurringInterval) &&
         isBefore(chargingSchedule.startSchedule!, currentDate)
@@ -829,6 +831,7 @@ const prepareRecurringChargingProfile = (
         start: chargingSchedule.startSchedule!,
         end: addWeeks(chargingSchedule.startSchedule!, 1),
       };
+      checkRecurringChargingProfileDuration(chargingProfile, recurringInterval, logPrefix);
       if (
         !isWithinInterval(currentDate, recurringInterval) &&
         isBefore(chargingSchedule.startSchedule!, currentDate)
@@ -857,6 +860,27 @@ const prepareRecurringChargingProfile = (
   }
 };
 
+const checkRecurringChargingProfileDuration = (
+  chargingProfile: ChargingProfile,
+  interval: Interval,
+  logPrefix: string,
+) => {
+  if (
+    chargingProfile.chargingSchedule.duration! > differenceInSeconds(interval.end, interval.start)
+  ) {
+    logger.warn(
+      `${logPrefix} ${moduleName}.getLimitFromChargingProfiles: Recurring ${
+        chargingProfile.chargingProfileKind
+      } charging profile id ${chargingProfile.chargingProfileId} duration ${
+        chargingProfile.chargingSchedule.duration
+      } is greater than the recurrency time interval ${differenceInSeconds(
+        interval.end,
+        interval.start,
+      )} duration`,
+    );
+  }
+};
+
 const getRandomSerialNumberSuffix = (params?: {
   randomBytesLength?: number;
   upperCase?: boolean;
-- 
2.34.1