From f9f00b5f18805c14b1bac3b2e5d2e8b5abc6c66c Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Mon, 10 Apr 2023 11:53:44 +0200 Subject: [PATCH] refactor: align methods signature MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- src/pools/abstract-pool.ts | 4 ++-- .../selection-strategies/abstract-worker-choice-strategy.ts | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/pools/abstract-pool.ts b/src/pools/abstract-pool.ts index fea4847d..a840dc74 100644 --- a/src/pools/abstract-pool.ts +++ b/src/pools/abstract-pool.ts @@ -544,8 +544,8 @@ export abstract class AbstractPool< this.sendToWorker(this.workerNodes[workerNodeKey].worker, task) } - private enqueueTask (workerNodeKey: number, task: Task): void { - this.workerNodes[workerNodeKey].tasksQueue.push(task) + private enqueueTask (workerNodeKey: number, task: Task): number { + return this.workerNodes[workerNodeKey].tasksQueue.push(task) } private dequeueTask (workerNodeKey: number): Task | undefined { diff --git a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts index 31041f3a..1da5dc52 100644 --- a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts +++ b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts @@ -38,13 +38,13 @@ export abstract class AbstractWorkerChoiceStrategy< protected readonly pool: IPoolInternal, protected readonly opts: WorkerChoiceStrategyOptions = { medRunTime: false } ) { - this.checkOptions() + this.checkOptions(this.opts) this.isDynamicPool = this.pool.type === PoolType.DYNAMIC this.choose.bind(this) } - private checkOptions (): void { - if (this.requiredStatistics.avgRunTime && this.opts.medRunTime === true) { + private checkOptions (opts: WorkerChoiceStrategyOptions): void { + if (this.requiredStatistics.avgRunTime && opts.medRunTime === true) { this.requiredStatistics.medRunTime = true } } -- 2.34.1