From 978aad6fbbc3042c2890893ae3ae7ff34af0385e Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Thu, 13 Oct 2022 23:54:51 +0200 Subject: [PATCH] Tests: be more strict on number expectation MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- benchmarks/versus-external-pools/dynamic-piscina.js | 2 +- benchmarks/versus-external-pools/fixed-piscina.js | 2 +- src/worker/abstract-worker.ts | 2 +- tests/worker/abstract-worker.test.js | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/benchmarks/versus-external-pools/dynamic-piscina.js b/benchmarks/versus-external-pools/dynamic-piscina.js index d78dd568..83190d43 100644 --- a/benchmarks/versus-external-pools/dynamic-piscina.js +++ b/benchmarks/versus-external-pools/dynamic-piscina.js @@ -12,7 +12,7 @@ const piscina = new Piscina({ filename: './workers/piscina/function-to-bench-worker.js', minThreads: size, maxThreads: size * 3, - idleTimeout: 1000 * 60 // this is the same as poolifier default + idleTimeout: 60000 // this is the same as poolifier default }) async function run () { diff --git a/benchmarks/versus-external-pools/fixed-piscina.js b/benchmarks/versus-external-pools/fixed-piscina.js index d1f785ed..c89a951d 100644 --- a/benchmarks/versus-external-pools/fixed-piscina.js +++ b/benchmarks/versus-external-pools/fixed-piscina.js @@ -11,7 +11,7 @@ const data = { const piscina = new Piscina({ filename: './workers/piscina/function-to-bench-worker.js', minThreads: size, - idleTimeout: 1000 * 60 // this is the same as poolifier default + idleTimeout: 60000 // this is the same as poolifier default }) async function run () { diff --git a/src/worker/abstract-worker.ts b/src/worker/abstract-worker.ts index 4aad8e62..52143fe3 100644 --- a/src/worker/abstract-worker.ts +++ b/src/worker/abstract-worker.ts @@ -6,7 +6,7 @@ import { EMPTY_FUNCTION } from '../utils' import type { KillBehavior, WorkerOptions } from './worker-options' import { KillBehaviors } from './worker-options' -const DEFAULT_MAX_INACTIVE_TIME = 1000 * 60 +const DEFAULT_MAX_INACTIVE_TIME = 60000 const DEFAULT_KILL_BEHAVIOR: KillBehavior = KillBehaviors.SOFT /** diff --git a/tests/worker/abstract-worker.test.js b/tests/worker/abstract-worker.test.js index 9c8dd097..c75227cc 100644 --- a/tests/worker/abstract-worker.test.js +++ b/tests/worker/abstract-worker.test.js @@ -17,7 +17,7 @@ describe('Abstract worker test suite', () => { it('Verify worker options default values', () => { const worker = new ThreadWorker(() => {}) - expect(worker.opts.maxInactiveTime).toBe(1000 * 60) + expect(worker.opts.maxInactiveTime).toStrictEqual(60000) expect(worker.opts.killBehavior).toBe(KillBehaviors.SOFT) expect(worker.opts.async).toBe(false) }) @@ -28,7 +28,7 @@ describe('Abstract worker test suite', () => { async: true, killBehavior: KillBehaviors.HARD }) - expect(worker.opts.maxInactiveTime).toBe(6000) + expect(worker.opts.maxInactiveTime).toStrictEqual(6000) expect(worker.opts.killBehavior).toBe(KillBehaviors.HARD) expect(worker.opts.async).toBe(true) }) -- 2.34.1