From 0b3122086d4ad8e3cc0c97774a1234681785ffe3 Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@sap.com>
Date: Mon, 7 Nov 2022 15:50:20 +0100
Subject: [PATCH] Small improvements to Utils UTs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---
 test/utils/UtilsTest.ts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/test/utils/UtilsTest.ts b/test/utils/UtilsTest.ts
index 7eb6aeb2..36d06ddb 100644
--- a/test/utils/UtilsTest.ts
+++ b/test/utils/UtilsTest.ts
@@ -53,10 +53,12 @@ describe('Utils test suite', () => {
     expect(Utils.convertToInt(0)).toBe(0);
     const randomInteger = Utils.getRandomInteger();
     expect(Utils.convertToInt(randomInteger)).toEqual(randomInteger);
+    expect(Utils.convertToInt('-1')).toBe(-1);
     expect(Utils.convertToInt('1')).toBe(1);
     expect(Utils.convertToInt('1.1')).toBe(1);
     expect(Utils.convertToInt('1.9')).toBe(1);
     expect(Utils.convertToInt('1.999')).toBe(1);
+    expect(Utils.convertToInt(-1)).toBe(-1);
     expect(Utils.convertToInt(1)).toBe(1);
     expect(Utils.convertToInt(1.1)).toBe(1);
     expect(Utils.convertToInt(1.9)).toBe(1);
@@ -69,10 +71,12 @@ describe('Utils test suite', () => {
     expect(Utils.convertToFloat(0)).toBe(0);
     const randomFloat = Utils.getRandomFloat();
     expect(Utils.convertToFloat(randomFloat)).toEqual(randomFloat);
+    expect(Utils.convertToFloat('-1')).toBe(-1);
     expect(Utils.convertToFloat('1')).toBe(1);
     expect(Utils.convertToFloat('1.1')).toBe(1.1);
     expect(Utils.convertToFloat('1.9')).toBe(1.9);
     expect(Utils.convertToFloat('1.999')).toBe(1.999);
+    expect(Utils.convertToFloat(-1)).toBe(-1);
     expect(Utils.convertToFloat(1)).toBe(1);
     expect(Utils.convertToFloat(1.1)).toBe(1.1);
     expect(Utils.convertToFloat(1.9)).toBe(1.9);
@@ -92,6 +96,8 @@ describe('Utils test suite', () => {
     expect(Utils.convertToBoolean(0)).toBe(false);
     expect(Utils.convertToBoolean(true)).toBe(true);
     expect(Utils.convertToBoolean(false)).toBe(false);
+    expect(Utils.convertToBoolean('')).toBe(false);
+    expect(Utils.convertToBoolean('NoNBoolean')).toBe(false);
   });
 
   it('Verify secureRandom()', () => {
@@ -112,6 +118,11 @@ describe('Utils test suite', () => {
     randomInteger = Utils.getRandomInteger(2, 1);
     expect(randomInteger).toBeGreaterThanOrEqual(1);
     expect(randomInteger).toBeLessThanOrEqual(2);
+    const max = 2.2,
+      min = 1.1;
+    randomInteger = Utils.getRandomInteger(max, min);
+    expect(randomInteger).toBeGreaterThanOrEqual(Math.ceil(min));
+    expect(randomInteger).toBeLessThanOrEqual(Math.floor(max));
   });
 
   it('Verify getRandomFloat()', () => {
-- 
2.34.1