From 9bc18a6d9bba455b461e484e182fae3dc56a5549 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Fri, 14 Oct 2022 08:40:51 +0200 Subject: [PATCH] Default random integer generation to maximun safe value MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- benchmarks/internal/benchmark-utils.js | 2 +- .../weighted-round-robin-worker-choice-strategy.test.js | 8 ++------ tests/test-utils.js | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/benchmarks/internal/benchmark-utils.js b/benchmarks/internal/benchmark-utils.js index a7e4ddec..60cecbe5 100644 --- a/benchmarks/internal/benchmark-utils.js +++ b/benchmarks/internal/benchmark-utils.js @@ -34,7 +34,7 @@ function jsonIntegerSerialization (n) { } } -function generateRandomInteger (max, min = 0) { +function generateRandomInteger (max = Number.MAX_SAFE_INTEGER, min = 0) { max = Math.floor(max) if (min) { min = Math.ceil(min) diff --git a/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js b/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js index 41c7751c..9d87c699 100644 --- a/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js +++ b/tests/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.test.js @@ -25,12 +25,8 @@ describe('Weighted round robin strategy worker choice strategy test suite', () = it('Verify that reset() resets internals', () => { const strategy = new WeightedRoundRobinWorkerChoiceStrategy(pool) - strategy.previousWorkerIndex = TestUtils.generateRandomInteger( - Number.MAX_SAFE_INTEGER - ) - strategy.currentWorkerIndex = TestUtils.generateRandomInteger( - Number.MAX_SAFE_INTEGER - ) + strategy.previousWorkerIndex = TestUtils.generateRandomInteger() + strategy.currentWorkerIndex = TestUtils.generateRandomInteger() const workersTaskRunTimeClearStub = sinon .stub(strategy.workersTaskRunTime, 'clear') .returns() diff --git a/tests/test-utils.js b/tests/test-utils.js index a3affb61..9a49c822 100644 --- a/tests/test-utils.js +++ b/tests/test-utils.js @@ -36,7 +36,7 @@ class TestUtils { }) } - static generateRandomInteger (max, min = 0) { + static generateRandomInteger (max = Number.MAX_SAFE_INTEGER, min = 0) { max = Math.floor(max) if (min) { min = Math.ceil(min) -- 2.34.1