From 7684583561a1bd274b3f3d7d869735256aa77afa Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@sap.com>
Date: Tue, 9 May 2023 01:19:45 +0200
Subject: [PATCH] test: improve median computation test
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---
 src/utils.ts        | 3 ---
 tests/utils.test.js | 7 +++----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/utils.ts b/src/utils.ts
index da1459f9..176d2c4f 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -29,9 +29,6 @@ export const median = (dataSet: number[]): number => {
     return dataSet[0]
   }
   const sortedDataSet = dataSet.slice().sort((a, b) => a - b)
-  if (sortedDataSet.length % 2 === 0) {
-    return sortedDataSet[sortedDataSet.length / 2]
-  }
   return (
     (sortedDataSet[(sortedDataSet.length - 1) >> 1] +
       sortedDataSet[sortedDataSet.length >> 1]) /
diff --git a/tests/utils.test.js b/tests/utils.test.js
index 21a6a7c4..f3278e47 100644
--- a/tests/utils.test.js
+++ b/tests/utils.test.js
@@ -4,10 +4,9 @@ const { isPlainObject, median } = require('../lib/utils')
 describe('Utils test suite', () => {
   it('Verify median computation', () => {
     expect(median([])).toBe(0)
-    const array0 = [0.08]
-    expect(median(array0)).toBe(0.08)
-    const array1 = [0.25, 4.75, 3.05, 6.04, 1.01, 2.02, 5.03]
-    expect(median(array1)).toBe(3.05)
+    expect(median([0.08])).toBe(0.08)
+    expect(median([0.25, 4.75, 3.05, 6.04, 1.01, 2.02, 5.03])).toBe(3.05)
+    expect(median([0.25, 4.75, 3.05, 6.04, 1.01, 2.02])).toBe(2.535)
   })
 
   it('Verify isPlainObject() behavior', () => {
-- 
2.34.1