From 0230d08e0b30520d8dcee837e7ad9a21309987fa Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Mon, 7 Apr 2025 12:48:02 +0200 Subject: [PATCH] fix(qav3): properly handle temperature=0 in smoothed_min() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .../user_data/freqaimodels/QuickAdapterRegressorV3.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py index d353bee..a1a32d1 100644 --- a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py +++ b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py @@ -706,4 +706,11 @@ def smoothed_max(series: pd.Series, temperature=1.0) -> float: def smoothed_min(series: pd.Series, temperature=1.0) -> float: - return -smoothed_max(-series, temperature=temperature) + data_array = series.to_numpy() + if data_array.size == 0: + return np.nan + if temperature < 0: + raise ValueError("temperature must be non-negative.") + if temperature == 0: + return data_array.min() + return -sp.special.logsumexp(-temperature * data_array) / temperature -- 2.43.0