From 03ef74bd10770a057dfa0a25bb73f324ddd0fe20 Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@sap.com>
Date: Wed, 18 Mar 2026 21:33:51 +0100
Subject: [PATCH] fix: prevent tests from polluting production log files

Set NODE_ENV=test via cross-env in all three test scripts (test,
test:debug, test:coverage). Logger checks NODE_ENV and sets silent
mode, preventing file writes to logs/combined.log and logs/error.log
during test runs.
---
 package.json        | 6 +++---
 src/utils/Logger.ts | 5 ++++-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/package.json b/package.json
index 354cce65..68acd375 100644
--- a/package.json
+++ b/package.json
@@ -68,9 +68,9 @@
     "lint": "cross-env TIMING=1 eslint --cache src tests scripts ./*.js ./*.ts",
     "lint:fix": "cross-env TIMING=1 eslint --cache --fix src tests scripts ./*.js ./*.ts",
     "format": "prettier --cache --write .; eslint --cache --fix src tests scripts ./*.js ./*.ts",
-    "test": "node --import tsx --test --test-force-exit 'tests/**/*.test.ts'",
-    "test:debug": "node --import tsx --test --inspect 'tests/**/*.test.ts'",
-    "test:coverage": "mkdir -p coverage && node --import tsx --test --test-force-exit --experimental-test-coverage --test-reporter=lcov --test-reporter-destination=coverage/lcov.info 'tests/**/*.test.ts'",
+    "test": "cross-env NODE_ENV=test node --import tsx --test --test-force-exit 'tests/**/*.test.ts'",
+    "test:debug": "cross-env NODE_ENV=test node --import tsx --test --inspect 'tests/**/*.test.ts'",
+    "test:coverage": "mkdir -p coverage && cross-env NODE_ENV=test node --import tsx --test --test-force-exit --experimental-test-coverage --test-reporter=lcov --test-reporter-destination=coverage/lcov.info 'tests/**/*.test.ts'",
     "clinic:clean": "clinic clean",
     "sea": "pnpm exec rimraf ./dist/evse-simulator ./dist/evse-simulator.blob && node --experimental-sea-config sea-config.json && pnpm dlx ncp $(volta which node || n which lts || nvm which node || command -v node) ./dist/evse-simulator && pnpm dlx postject ./dist/evse-simulator NODE_SEA_BLOB ./dist/evse-simulator.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 && pnpm exec rimraf ./dist/evse-simulator.blob"
   },
diff --git a/src/utils/Logger.ts b/src/utils/Logger.ts
index fd282638..96c94a62 100644
--- a/src/utils/Logger.ts
+++ b/src/utils/Logger.ts
@@ -78,7 +78,10 @@ const getLoggerInstance = (): WinstonLogger => {
   loggerInstance = createLogger({
     format: logFormat,
     level: logConfiguration.level,
-    silent: logConfiguration.enabled === false || logTransports.length === 0,
+    silent:
+      logConfiguration.enabled === false ||
+      logTransports.length === 0 ||
+      process.env.NODE_ENV === 'test',
     transports: logTransports,
   })
   //
-- 
2.53.0