From 0e05c4dc968e27cf71ef2ab266feb57d9d1bade9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Thu, 1 Jun 2023 10:31:31 +0200 Subject: [PATCH] feat: allow to disable tasks timeout check in worker MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- CHANGELOG.md | 4 ++++ README.md | 1 + src/worker/abstract-worker.ts | 5 ++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0bb0c700..94ddcdf9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Added + +- Allow to disable tasks timeout check in worker. + ## [2.5.0] - 2023-05-31 ### Added diff --git a/README.md b/README.md index 532d9e8f..2f5fff41 100644 --- a/README.md +++ b/README.md @@ -217,6 +217,7 @@ This method will call the terminate method on each worker. The last active time of your worker unit will be updated when a task is submitted to a worker or when a worker terminate a task. If `killBehavior` is set to `KillBehaviors.HARD` this value represents also the timeout for the tasks that you submit to the pool, when this timeout expires your tasks is interrupted and the worker is killed if is not part of the minimum size of the pool. If `killBehavior` is set to `KillBehaviors.SOFT` your tasks have no timeout and your workers will not be terminated until your task is completed. + 0: no tasks timeout check. Default: 60000 - `killBehavior` (optional) - Dictates if your async unit (worker/process) will be deleted in case that a task is active on it. diff --git a/src/worker/abstract-worker.ts b/src/worker/abstract-worker.ts index 8a38b4e5..2afd6f34 100644 --- a/src/worker/abstract-worker.ts +++ b/src/worker/abstract-worker.ts @@ -71,7 +71,10 @@ export abstract class AbstractWorker< super(type) this.checkWorkerOptions(this.opts) this.checkTaskFunctions(taskFunctions) - if (!this.isMain) { + if ( + !this.isMain && + (this.opts.maxInactiveTime ?? DEFAULT_MAX_INACTIVE_TIME) > 0 + ) { this.lastTaskTimestamp = performance.now() this.aliveInterval = setInterval( this.checkAlive.bind(this), -- 2.34.1