From 1d0acf2377b07990f18e084e9641d7bfa6d5268f Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Wed, 19 Feb 2025 16:02:26 +0100 Subject: [PATCH] fix(qav3): properly handle sqlite storage MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .../freqaimodels/LightGBMRegressorQuickAdapterV35.py | 5 ++++- .../freqaimodels/XGBoostRegressorQuickAdapterV35.py | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py index ccf5a2b..3f5446e 100644 --- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py @@ -250,7 +250,6 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): storage_backend = self.__optuna_config.get("storage", "file") if storage_backend == "sqlite": storage = f"sqlite:///{storage_dir}/optuna-{dk.pair.split('/')[0]}.sqlite" - logging.info(f"Optuna storage: {storage}") elif storage_backend == "file": storage = optuna.storages.JournalStorage( optuna.storages.journal.JournalFileBackend( @@ -464,8 +463,12 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): try: _ = study.best_params return True + # file backend storage raises KeyError except KeyError: return False + # sqlite backend storage raises ValueError + except ValueError: + return False def log_sum_exp_min_max_pred( diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py index c559cb8..fde58cc 100644 --- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py @@ -464,8 +464,12 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel): try: _ = study.best_params return True + # file backend storage raises KeyError except KeyError: return False + # sqlite backend storage raises ValueError + except ValueError: + return False def log_sum_exp_min_max_pred( -- 2.43.0