From 2a87030e2fa5e42167e2aa13bd8c1cbb3d27ffc1 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Sat, 16 Sep 2023 15:13:03 +0200 Subject: [PATCH] build(ci): use PAT for continuous benchmark results MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .github/workflows/benchmark.yml | 2 +- CHANGELOG.md | 8 ++++---- benchmarks/README.md | 10 +++++----- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 64172d43..68f07da7 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -36,7 +36,7 @@ jobs: name: Internal benchmark tool: 'benchmarkjs' output-file-path: ./benchmarks/internal/output.txt - github-token: ${{ secrets.GITHUB_TOKEN }} + github-token: ${{ secrets.BENCHMARK_RESULTS_TOKEN }} auto-push: true alert-threshold: '200%' comment-on-alert: true diff --git a/CHANGELOG.md b/CHANGELOG.md index 7b5e9bfa..87f4a866 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added -- Continuous internal benchmarking. +- Continuous internal benchmarking: https://poolifier.github.io/benchmark-results/dev/bench. ## [2.6.44] - 2023-09-08 @@ -649,7 +649,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Optimize worker alive status check. - BREAKING CHANGE: Rename worker choice strategy `LESS_RECENTLY_USED` to `LESS_USED`. - Optimize `LESS_USED` worker choice strategy. -- Update benchmarks versus external threads pools. +- Update benchmark versus external threads pools. - Optimize tasks usage statistics requirements for worker choice strategy. ### Fixed @@ -671,7 +671,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Optimize worker alive status check. - BREAKING CHANGE: Rename worker choice strategy `LESS_RECENTLY_USED` to `LESS_USED`. - Optimize `LESS_USED` worker choice strategy. -- Update benchmarks versus external threads pools. +- Update benchmark versus external threads pools. ### Fixed @@ -837,7 +837,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Optimize fair share task scheduling algorithm implementation. -- Update benchmarks versus external pools results with latest version. +- Update benchmark versus external pools results with latest version. ## [2.3.3] - 2022-10-15 diff --git a/benchmarks/README.md b/benchmarks/README.md index 76cc86a6..d217c260 100644 --- a/benchmarks/README.md +++ b/benchmarks/README.md @@ -4,8 +4,8 @@ Welcome to poolifier benchmarks and thanks to look into this project. ## Folder Structure -The [internal](./internal) folder contains poolifier internal benchmarks. -The [versus-external-pools](./versus-external-pools) folder contains benchmarks versus other Node.js pools. +The [internal](./internal) folder contains poolifier internal benchmark. +The [versus-external-pools](./versus-external-pools) folder contains benchmark versus other Node.js pools. ## Poolifier vs other pools benchmark @@ -34,15 +34,15 @@ We chose to use this tool because it allows to run isolated Node.js processes so - [microjob](https://github.com/wilk/microjob): removed because unmaintained since more than 5 years. - [threads.js](https://github.com/andywer/threads.js/): removed because not a threads pool. -> :warning: **We would need funds to run our benchmarks more often and on Cloud VMs, please consider to sponsor this project** +> :warning: **We would need funds to run our benchmark more often and on Cloud VMs, please consider to sponsor this project** -Read the [README.md](./versus-external-pools/README.md) to know how to run these benchmarks. +Read the [README.md](./versus-external-pools/README.md) to know how to run the benchmark. ## Poolifier internal benchmark ### Usage -To run the internal benchmarks, you just need to navigate to the root of poolifier project and run `pnpm benchmark` +To run the internal benchmark, you just need to navigate to the root of poolifier project and run `pnpm benchmark` ### Results -- 2.34.1