From 3e66bccb4d44bb2bde002f802bb43573586f3406 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Tue, 17 Mar 2026 00:02:44 +0100 Subject: [PATCH] ci: move coverage/lint/typecheck/sonar pipeline from Node 22.x to 24.x Node 22 --experimental-test-coverage has known bugs (nodejs/node#55510) that cause false CI failures. Move all gated steps (coverage, lint, typecheck, SonarCloud, dependency review) to Node 24.x. Node 22 remains in the test matrix for regular pnpm test runs. --- .github/workflows/ci.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 048ef1f4..80440b4a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -67,13 +67,13 @@ jobs: with: fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis - name: Dependency Review - if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} uses: actions/dependency-review-action@v4 with: base-ref: ${{ github.ref_name }} head-ref: ${{ github.sha }} - name: Pull Request Dependency Review - if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} uses: actions/dependency-review-action@v4 - uses: pnpm/action-setup@v4 - name: Setup node ${{ matrix.node }} @@ -84,24 +84,24 @@ jobs: - name: pnpm install run: pnpm install --ignore-scripts --frozen-lockfile # - name: pnpm audit - # if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + # if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} # run: pnpm audit --prod - name: pnpm lint - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} run: pnpm lint - name: pnpm typecheck - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} run: pnpm typecheck - name: pnpm build run: pnpm build - name: pnpm test - if: ${{ !(github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x') }} + if: ${{ !(github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x') }} run: pnpm test - name: pnpm test:coverage - if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} run: pnpm test:coverage - name: SonarCloud Scan - if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} uses: sonarsource/sonarqube-scan-action@v7.0.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -122,13 +122,13 @@ jobs: with: fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis - name: Dependency Review - if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} uses: actions/dependency-review-action@v4 with: base-ref: ${{ github.ref_name }} head-ref: ${{ github.sha }} - name: Pull Request Dependency Review - if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} uses: actions/dependency-review-action@v4 - uses: pnpm/action-setup@v4 - name: Setup node ${{ matrix.node }} @@ -139,21 +139,21 @@ jobs: - name: pnpm install run: pnpm install --ignore-scripts --frozen-lockfile # - name: pnpm audit - # if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + # if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} # run: pnpm audit --prod - name: pnpm lint - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} run: pnpm lint - name: pnpm build run: pnpm build - name: pnpm test - if: ${{ !(github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x') }} + if: ${{ !(github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x') }} run: pnpm test - name: pnpm test:coverage - if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} run: pnpm test:coverage - name: SonarCloud Scan - if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} + if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '24.x' }} uses: sonarsource/sonarqube-scan-action@v7.0.0 with: projectBaseDir: ui/web -- 2.43.0