From 47b4907bf693f29d6f88de776747ea30e4c800ce Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Sat, 20 Sep 2025 22:07:27 +0200 Subject: [PATCH] refactor(reforcexy): ensure HPO trial start is always logged MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- ReforceXY/user_data/freqaimodels/ReforceXY.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ReforceXY/user_data/freqaimodels/ReforceXY.py b/ReforceXY/user_data/freqaimodels/ReforceXY.py index e1843a5..67e6fca 100644 --- a/ReforceXY/user_data/freqaimodels/ReforceXY.py +++ b/ReforceXY/user_data/freqaimodels/ReforceXY.py @@ -937,6 +937,8 @@ class ReforceXY(BaseReinforcementLearningModel): """ Defines a single trial for hyperparameter optimization using Optuna """ + logger.info("------------ Hyperopt trial %d ------------", trial.number) + if "PPO" in self.model_type: params = sample_params_ppo(trial, self.n_envs) if params.get("n_steps", 0) * self.n_envs > total_timesteps: @@ -962,6 +964,8 @@ class ReforceXY(BaseReinforcementLearningModel): # Ensure that the sampled parameters take precedence params = deepmerge(self.get_model_params(), params) + logger.info("Trial %s params: %s", trial.number, params) + nan_encountered = False if self.activate_tensorboard: @@ -975,9 +979,6 @@ class ReforceXY(BaseReinforcementLearningModel): else: tensorboard_log_path = None - logger.info("------------ Hyperopt trial %d ------------", trial.number) - logger.info("Trial %s params: %s", trial.number, params) - train_env, eval_env = self._get_train_and_eval_environments( train_df, test_df, dk, trial=trial ) -- 2.43.0