From 528db71629bde2fbb2332fadc1011df3a61dd7c7 Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@piment-noir.org>
Date: Sun, 3 Sep 2023 15:51:52 +0200
Subject: [PATCH] refactor: code cleanups
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---
 max.mjs | 13 ++++++++-----
 min.mjs | 13 ++++++++-----
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/max.mjs b/max.mjs
index 8f1f698..8914520 100644
--- a/max.mjs
+++ b/max.mjs
@@ -10,11 +10,11 @@ const testArray = generateRandomNumberArray(size)
  * @returns
  */
 function loopMax (values) {
-  let max = -Infinity
+  let maximum = -Infinity
   for (const value of values) {
-    if (value > max) max = value
+    if (value > maximum) maximum = value
   }
-  return max
+  return maximum
 }
 
 /**
@@ -23,7 +23,10 @@ function loopMax (values) {
  * @returns
  */
 function reduceTernaryMax (values) {
-  return values.reduce((a, b) => (a > b ? a : b), -Infinity)
+  return values.reduce(
+    (maximum, num) => (maximum > num ? maximum : num),
+    -Infinity
+  )
 }
 
 /**
@@ -32,7 +35,7 @@ function reduceTernaryMax (values) {
  * @returns
  */
 function reduceMathMax (values) {
-  return values.reduce((a, b) => Math.max(a, b), -Infinity)
+  return values.reduce((maximum, num) => Math.max(maximum, num), -Infinity)
 }
 
 /**
diff --git a/min.mjs b/min.mjs
index 3ea46c4..2ac02b5 100644
--- a/min.mjs
+++ b/min.mjs
@@ -10,11 +10,11 @@ const testArray = generateRandomNumberArray(size)
  * @returns
  */
 function loopMin (values) {
-  let min = Infinity
+  let minimum = Infinity
   for (const value of values) {
-    if (value < min) min = value
+    if (value < minimum) minimum = value
   }
-  return min
+  return minimum
 }
 
 /**
@@ -23,7 +23,10 @@ function loopMin (values) {
  * @returns
  */
 function reduceTernaryMin (values) {
-  return values.reduce((a, b) => (a < b ? a : b), Infinity)
+  return values.reduce(
+    (minimum, num) => (minimum < num ? minimum : num),
+    Infinity
+  )
 }
 
 /**
@@ -32,7 +35,7 @@ function reduceTernaryMin (values) {
  * @returns
  */
 function reduceMathMin (values) {
-  return values.reduce((a, b) => Math.min(a, b), Infinity)
+  return values.reduce((minimum, num) => Math.min(minimum, num), Infinity)
 }
 
 /**
-- 
2.34.1