From 56c884e35992d6971e771fc605449c91314e8635 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Sun, 16 Feb 2025 12:25:26 +0100 Subject: [PATCH] fix(qav3): brown paper bag bug in optuna_study_has_best_params() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .../user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py | 3 ++- .../user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py index 5438566..69d50fb 100644 --- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py @@ -407,7 +407,8 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): if not study: return False try: - _ = study.trials + _ = study.best_params + return True except KeyError: return False diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py index 7038dff..cdc6dce 100644 --- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py @@ -408,7 +408,8 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel): if not study: return False try: - _ = study.trials + _ = study.best_params + return True except KeyError: return False -- 2.43.0